From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QOM3Itgm9WMhgwEAbAwnHQ (envelope-from ) for ; Tue, 21 Feb 2023 21:17:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ALZpIdgm9WOpEAAAG6o9tA (envelope-from ) for ; Tue, 21 Feb 2023 21:17:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0010C3223B for ; Tue, 21 Feb 2023 21:17:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUZ4Z-00069l-He; Tue, 21 Feb 2023 15:17:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUZ4Q-00068o-On for bug-guix@gnu.org; Tue, 21 Feb 2023 15:17:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUZ4Q-0005Wo-Gb for bug-guix@gnu.org; Tue, 21 Feb 2023 15:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUZ4P-0004Mb-Re for bug-guix@gnu.org; Tue, 21 Feb 2023 15:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61684: can't compose 'with-patch' with 'with-source' Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 21 Feb 2023 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61684 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 61684@debbugs.gnu.org Received: via spool by 61684-submit@debbugs.gnu.org id=B61684.167701058316722 (code B ref 61684); Tue, 21 Feb 2023 20:17:01 +0000 Received: (at 61684) by debbugs.gnu.org; 21 Feb 2023 20:16:23 +0000 Received: from localhost ([127.0.0.1]:57284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUZ3m-0004Ld-IY for submit@debbugs.gnu.org; Tue, 21 Feb 2023 15:16:22 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:34629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUZ3h-0004LM-BV for 61684@debbugs.gnu.org; Tue, 21 Feb 2023 15:16:21 -0500 Received: by mail-wr1-f44.google.com with SMTP id c12so5722343wrw.1 for <61684@debbugs.gnu.org>; Tue, 21 Feb 2023 12:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677010571; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=nYy2xuwPrsvs2KWnLQqwhVo9Etux7cu/DHOdLrx4nls=; b=SVw7vSne5XdnikUr2g6G18vu1Ufqf0rhuUJD92EZGovrD2Ks7Il3KgvijbFo/sS6K8 QFqtsTdaSicLD1FME7LM0a/fluivJ8PRNKd3Nh/QAXtbmWmzmqUP5LxYKwb15HD6MZpv bA+Yx0R/6rg8AFBuT2AaWWSBj+HunStmWb/rE8aHL4RbkAvc/jmo9FjV+OBvwWrod2HA ocjksWxfpkHjkP872JuQdgAoX76+0Ng5efb/fGDp5eDThYWxXw/ErmIgSjDbFXXPIJvP h2MXVeAEmVvHesJBvJ4J6505zUTWEG/59T32BmkFeflY3iiNrUEmaLpnbUeGKwtndNjI O/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677010571; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nYy2xuwPrsvs2KWnLQqwhVo9Etux7cu/DHOdLrx4nls=; b=mwQKZio8gr+EmivJJnD/pY/YKRfSLILpDlAoIVfsBM+5547086G3gH+r19J6mckIgm JViCafkO1WRr9Pi5JRneL8SgmdAm9/dJEQZ5Tr4SEPdLWhnFwq2ooA+bo5oGOuJSgSzP AQ4YpxbIcgtc7i8EN7o+p0I45e4OFNcq9qyzUptec3lnulLtvfEqLgjlhKonvxOASYaK fCLpzsjwlsQJBwBnhSsCI0zKlJ6mc9u9h2QEwxZscdvAWoeXOlONPOTPHn64+X8jceUW IqpzUNNbJJkqb67OD9w58phCCQe3Bfcgb0HdRbONFakMlJoapTb+27a7A+l2EhKteJyX SXCA== X-Gm-Message-State: AO0yUKVPpVglCadtEFMmNQybuIZVlqXQ+bk7T5pjBwMLA1CYH6ZpHRb4 cxFuPF2sQVKX4xcfFjNsHk5/aIMbuZ0= X-Google-Smtp-Source: AK7set+72Q7Iz5WH9K37Fi/H1MDN0vNp/m4bZml8aUVaCQumA1F3p7wj/plcK07u4PZRqGu0fsrOdw== X-Received: by 2002:adf:fb45:0:b0:2c4:80a:e842 with SMTP id c5-20020adffb45000000b002c4080ae842mr4084384wrs.3.1677010571156; Tue, 21 Feb 2023 12:16:11 -0800 (PST) Received: from lili ([88.126.110.68]) by smtp.gmail.com with ESMTPSA id k9-20020a5d6289000000b002c56af32e8csm4392185wru.35.2023.02.21.12.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 12:16:10 -0800 (PST) From: Simon Tournier In-Reply-To: <87mt56gac6.fsf@gmail.com> References: <87mt56gac6.fsf@gmail.com> Date: Tue, 21 Feb 2023 20:05:32 +0100 Message-ID: <86sfeyvnyb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677010648; a=rsa-sha256; cv=none; b=Avy3xRwtgEsz9+afLPIqBWWlvYUQpQTrB5+7E7goV7hatET5WSs830bzgzC4g0hEPdRxjw RlPcvhGe9GW8+ieszYBrHTzgGI88OnzkdAKsqOxPYKBWjzYaL9swcqIU2ziGrXJW6LLCSw u01YI2ejcgde/jY+zeI98tgEbE4DcOkUFjUP+AcPIXDKT4UWKStWcpXFY0zFn+/4Hoaaj3 2RlD9jUTqlpqw3eAMCe7y/F1QmvqlsaWG3bT/yOBoCHnRIPOPBFqsvTgbhf0vZtdewM+MB R9tpYaW0HAQTlP1GwMf/Ip8bkKJdZJpLjBIJ4zmx/2miOrDIISgUyE5sBRlzgQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SVw7vSne; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677010648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=nYy2xuwPrsvs2KWnLQqwhVo9Etux7cu/DHOdLrx4nls=; b=d3kEJJmTaQ/UrrNsfSL4w7PSeBioquD/AwR3YpylCuvsPwoCl9E9IuZRtgnlqODpuMF7h5 8Rg7QcPhlRL53mccEH0of6XxCn1GT3lrj0LFW60QrzmPPxWYnUfgdXnFymldmXv6B1GbAo 9ncznewmWFyW0GkyvUgnvNwXEayT0GVOpaXZBm5SW+/g1mqCvuCi6iMxGvDM+dcJCQDfUt ir7EWNEkgCZur3qgNVOpqLHoQS2VRH2NvyrkKoi8UgfJZlxVjSlkVXD0n3Y0quZNTqOE80 vRhPrzMxJYnd1NPaEwapda5OluuJq0/syQYhWjKtulTZ5bIcJO5FPIySF1fe3Q== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SVw7vSne; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.80 X-Spam-Score: -2.80 X-Migadu-Queue-Id: 0010C3223B X-TUID: ykrgioCBolFB Hi Maxim, On Tue, 21 Feb 2023 at 13:08, Maxim Cournoyer wrote: > Given 'with-source' discards any patch from the original source, I thought > I could at least add them back via 'with-patch', but it appears this > does not work: I remember some headaches with this thread [1]. :-) 1: > > --8<---------------cut here---------------start------------->8--- > scheme@(gnu packages jami)> (options->transformation > `((with-source . "libjami@20230220.0=/home/maxim/src/jami/jami-20230220.0.tar.gz") > (with-patch . ,(string-append > "libjami=" (search-patch > "jami-disable-integration-tests.patch"))))) > $6 = # > scheme@(gnu packages jami)> ($6 libjami) > $7 = # > scheme@(gnu packages jami)> (package-source $7) > $8 = #< uri: "/home/maxim/src/jami/jami-20230220.0.tar.gz" recursive?: #t> > scheme@(gnu packages jami)> > --8<---------------cut here---------------end--------------->8--- > > The downloaded-file resulting package source has lost the patch, and no > error got produced, leaving the user to discover this limitation by > themselves. Well, it is probably unrelated because I guess the transformation makes sense here but indeed you can have bad surprise if the transformation does not make sense and then silently ignored. Well, I have never finished my attempt to raise more information about the transformation because the code about the transformation is hard to follow, from my point of view. Anyway! Thanks for having open this ticket. :-) Maybe with-source and with-patch are the first incremental change. ;-) Cheers, simon