From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gAdlCf/PGWMk1wAAbAwnHQ (envelope-from ) for ; Thu, 08 Sep 2022 13:20:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CGJ0CP/PGWNiywAAG6o9tA (envelope-from ) for ; Thu, 08 Sep 2022 13:20:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8FB65A78 for ; Thu, 8 Sep 2022 13:20:30 +0200 (CEST) Received: from localhost ([::1]:44538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWFa9-0004qS-NF for larch@yhetil.org; Thu, 08 Sep 2022 07:20:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWFWk-0002eT-Ja for guix-devel@gnu.org; Thu, 08 Sep 2022 07:17:02 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWFWi-0003FV-8s for guix-devel@gnu.org; Thu, 08 Sep 2022 07:16:58 -0400 Received: by mail-wr1-x436.google.com with SMTP id bq9so12570591wrb.4 for ; Thu, 08 Sep 2022 04:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date; bh=IRhH5FMZ4qfTUMVOcxt8N06sSVYWELqJR/NfEJGdl8Q=; b=gOXWuBnilYuDHl7LBuY3XxWLHdLQsQffEh0W7VsHySBtoh/VOjMI8JaIISb6vhepzo gNONpkCvJX7qQAd95r+zTlikg0zDxCaKHEbReALPQXbWdfDXP9As61e4Fny0ZmmjLKx2 a0um2mSZ05uH+Nk4+ZD5h2ddSf5d28bSwKcYga8scsQ4HIE46/cxj5Nh6pxOPsIFSMSU yNpDkX6Ln7rC90q+EvjuuWxbdpXhZWAOB+ZPuQP4HmOZ7eEtfgo3dPaUWuJOOVEAPGEq i6y/zjCEqwsLZfpRpD1td7eiMzaDeBv2iiVUkjq0nMCoXQ5iJCy6xd1KIMCGHudhWQRY kTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date; bh=IRhH5FMZ4qfTUMVOcxt8N06sSVYWELqJR/NfEJGdl8Q=; b=YPIzSEd5V5M18FzxXQRVEq+TSQwY0kT9ijOyHaOCE2bU4cZyeLMcOVgXVqtn9tYQwc ZjWm2aVnEcroeLnPEGuo1OPcSCqlIXSZBS3+CDyMKoEmRiOS7pa9BUVLodXvkvh/LIUc cEpvhSI1xeMkIE5nRirWI6oPKZ0245uv8iurbs5WI0mMbmUmTJPK4K5f/ZyfmvHkbW16 d7JVckde9rHxzjFFverBn8oShdsMXskYUGVkPntLERNffay0VKgqo1MZckAW7nphoXes AvoNYSpGVnjrXWAch91wqJO+P3zNjznq6CYg+VhzuhlH+6P3lTRb/1fYX2fkIyiN38p1 kHXQ== X-Gm-Message-State: ACgBeo1V7+zVBziGojcMhanZzcTN1FYk3OzVVtULn2oJNBhF1l+H4kHU Oc68eTYfBR48HOWm4U7I0sovnl+z2dI= X-Google-Smtp-Source: AA6agR5UZpIue8Uz8M9sc1hkAITE/grq3rBYSOto22VrhhzLyVTIXxrfPbgnvW94wFrDso2f1u0zuQ== X-Received: by 2002:adf:e74d:0:b0:226:d514:8c29 with SMTP id c13-20020adfe74d000000b00226d5148c29mr4718029wrn.664.1662635814652; Thu, 08 Sep 2022 04:16:54 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h6-20020a05600016c600b00228d8420f57sm10957895wrf.95.2022.09.08.04.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 04:16:54 -0700 (PDT) From: zimoun To: Maxime Devos , Guix Devel Subject: Re: Sanitizer of record fields? In-Reply-To: References: <868rmuxpnw.fsf@gmail.com> Date: Thu, 08 Sep 2022 13:16:07 +0200 Message-ID: <86r10mw1zc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662636030; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=IRhH5FMZ4qfTUMVOcxt8N06sSVYWELqJR/NfEJGdl8Q=; b=pyzyEfY9sxZvlHbTK/tEkC5WgrOUSca/YA5jfc8zHjCqxaXQCmSTEZaYtY7g0Hg9V65mbx j2Jc120+lxlr2s3Z6XMVj2aZBi+jH5zgoD0c2FU5BUVXj5bKCr+GEjUAlJpsLjhPpKlAhO KNSJO7NJ97OkkJxgXzra2EEcedtVoboAqJ4027HswYkTeXMm1Q3IpuTsy4shSHVL/+iyPr 1irBNgAjBw5aBwLSf/OeOp7dQxuExbTpQfHfZsCTA6MC1rCwvFIHFEQo2gi+0/msHGCEH5 nUat+7HcL1WMpD3f2Yexebt6ZKZI0KQ5RZHDrQ/6FnN6AsPiwDnu+N2mjYn6Vw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662636030; a=rsa-sha256; cv=none; b=Sq91pMAd5SUPMuLckcXkD3VTANMLg8tgLfXy8Sv+6ZFMGN5mmzYs5/QY00ZczUijipVX9u MPW14Fx+WYrUb3WxXxE83h4kQJ60yggu9cxktU8sE8XRtdxjP/pVjLBHrEGqqIUIqfCjJb O2YCU9HZFPO1CNCvDEbXwsrR6icXbNFuaZMjyYmELOwlvAb7F7vL0wyiHhR9X3YjFi4MVH 3N7du20d2QaVkqEOKgziRFh3adproGm/HQHh/hJNz3Vrx4mONtFkTwc4X0I2q/TdzOlzdG twdP9Qacg4a5VStZB4bq8qqArRGJIVeKy/yL2jlnFV1oYbAE69hELcN07NIvzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gOXWuBni; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.28 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gOXWuBni; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C8FB65A78 X-Spam-Score: -4.28 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZB3Bp5CLLe/G Hi, On Thu, 08 Sep 2022 at 11:32, Maxime Devos wrote: > On 08-09-2022 09:59, zimoun wrote: >> We could add a lint checker. Is it a =E2=80=9Cgood=E2=80=9D idea? > > We already have one, 'check-license'. Yeah, but I was talking about check if the field return the expected record type. Not only for the license one. >> Because lint is not always applied, a check should be done when running >> =E2=80=99make=E2=80=99 or a special target. Is it a =E2=80=9Cgood=E2=80= =9D idea? > > I suppose it is a possibility, but it adds a few seconds to every 'make': > > time ./pre-inst-env guix lint --checkers=3Dlicense > make=C2=A0 all-recursive=C2=A0 [...] > gnu/packages/qt.scm:1373:13: qtshadertools@6.3.1: invalid license field > gnu/packages/tex.scm:11816:2: texlive-setspace@59745: invalid It means that =E2=80=9Cguix lint=E2=80=9D is not systematically run. :-) I agree that the overhead on =E2=80=99make=E2=80=99 is probably not worth. = Maybe, more checks could be run by the pre push hook. WDYT? Cheers, simon