From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yKtlEqkHm2MQSAAAbAwnHQ (envelope-from ) for ; Thu, 15 Dec 2022 12:40:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aDhmEqkHm2MjMAAA9RJhRA (envelope-from ) for ; Thu, 15 Dec 2022 12:40:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05CD01D743 for ; Thu, 15 Dec 2022 12:40:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5maq-0003rw-3X; Thu, 15 Dec 2022 06:40:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5mao-0003pH-Np for guix-patches@gnu.org; Thu, 15 Dec 2022 06:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5mao-0000op-EQ for guix-patches@gnu.org; Thu, 15 Dec 2022 06:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5mao-0002P7-5T for guix-patches@gnu.org; Thu, 15 Dec 2022 06:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60013] [PATCH 1/3] gnu: Add libmodule Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Dec 2022 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60013 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Florian , 60013@debbugs.gnu.org Received: via spool by 60013-submit@debbugs.gnu.org id=B60013.16711043849223 (code B ref 60013); Thu, 15 Dec 2022 11:40:02 +0000 Received: (at 60013) by debbugs.gnu.org; 15 Dec 2022 11:39:44 +0000 Received: from localhost ([127.0.0.1]:42852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5maW-0002Og-Ai for submit@debbugs.gnu.org; Thu, 15 Dec 2022 06:39:44 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5maS-0002OG-6k for 60013@debbugs.gnu.org; Thu, 15 Dec 2022 06:39:41 -0500 Received: by mail-wr1-f46.google.com with SMTP id h11so2691868wrw.13 for <60013@debbugs.gnu.org>; Thu, 15 Dec 2022 03:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=M3JmAFT8+7NiwNzORn+PZJpM/w2592lH9C7M2KJVKMA=; b=Vi98idBs0UuU/2waXyFJx2FD7U/DunoLfp4oy1U9uaXZ+bfVb6VT50dmkVkiqkR3G7 ZGb8rwwa8gBHr/70aTMeU80rxy2Be1O7IvUxyJhFLcaB1Y/BZj/vwE/cc352Q8DrhLWy hH2cesal0LUYTsasqImmVnTJLpydX837aq7PptJWSY2C/N6tjijBkoF3i+6o2jWRps+I ArYXYBX3Cnd2z0gSfq6sZYaWS4LfCecytJCu7bFFtorBTjN1nKg9ZTrYGDJcyXZ/MWq2 8I2E7k+rxnGLubMp5hQ1U6EHyDN9TZeWc6Ycb8fvYcQ64v0rlVN9JOdp73m463ByFWnp A5KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=M3JmAFT8+7NiwNzORn+PZJpM/w2592lH9C7M2KJVKMA=; b=VpDf8FyA7v9oTk1kcjkpkdMqarsTVx+t/8kuGmpfnrMCpMuC1nUvRWGnOxTdmLq27h fJDjUZNbOTvAKRTeItfzpnFbh0b8AO1cIGUw3qq7Dw8bLcu7S0M2jEmdP04rZATx4Li3 LnvNH8w8WXLXVsLs2HUCJbLOQ4SpMF/M149B7iln0Rd1ywuAmZvWxUx/1BOtFZYRRVSf EGQJ0hlMP0QSvwcZSkFlO5I433mjmxNTmE0w44Y2NR0Jjgd7RjkyvNIGFOF+ePvDaOKc lzwcwHvlo2fpWCiy0lvr0a/RNYIfa6PXG4eu8QkwcslBoRoEf0xxmvw/HWRMP374hLUP dzyw== X-Gm-Message-State: ANoB5pnu3oztG1v+X20XDrBCxo8cXZ1AVH969xeUVArF9wRIiKWTkDkL oLDTdmz5kaBSY809dZpSvogQNNMT/P0= X-Google-Smtp-Source: AA0mqf64jDM4Tpgp91Qywul1VWTd+KR/mrxXlvwAF03gunD3HeZTlpD7ssWU1rd2/X4tJw68v6sxzw== X-Received: by 2002:a5d:5a82:0:b0:232:be5a:f09b with SMTP id bp2-20020a5d5a82000000b00232be5af09bmr3925373wrb.7.1671104374494; Thu, 15 Dec 2022 03:39:34 -0800 (PST) Received: from lili (eduroam-113070.grenet.fr. [130.190.113.70]) by smtp.gmail.com with ESMTPSA id w2-20020a5d4042000000b002421db5f279sm5893358wrp.78.2022.12.15.03.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 03:39:34 -0800 (PST) From: zimoun In-Reply-To: <87tu1zr072.fsf@posteo.net> References: <87edt47ecz.fsf@posteo.net> <91575b0f95b5a71b18108b57fa1a366e0f6044c9.1670876889.git.florhizome@posteo.net> <86tu20b2uu.fsf@gmail.com> <87tu1zr072.fsf@posteo.net> Date: Thu, 15 Dec 2022 12:31:11 +0100 Message-ID: <86pmckdhts.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Vi98idBs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671104425; a=rsa-sha256; cv=none; b=tJ1djfhF1+I3zG6jrGyrBesbJbdS5n33GVlwni6LTMt1rJpCvnkriIZU2YrGnaOZhROew1 p+ejA2fGfdjT4PQZYjB94na8ucyo2vSWpGaJXmpuX/nX8ZJTylb2XppQ/I+U5+wv5+Y+WS QfkMhKItzyck0930OcY0ftPGf3APZUeLB8Wbl1FjZ8JCjMj03YslaGVCG15fCQWQ22HpMR zTT9xLLxHg40AYSX+oG15dc37+aCHnHoREEikGgX9r9+KFdsuIUCDzBQeDcT5QR3mun4GM AXodbw7VaRF+ex/idIxbhBlWbXHswk7qWmLkeGJRyimHAXFCQypRzlDsqb9VIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671104425; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=M3JmAFT8+7NiwNzORn+PZJpM/w2592lH9C7M2KJVKMA=; b=uW5pll2zT8awEjHANg1m29xtMdn4Bp1PqZRUIeXG7V0fRcjTHta5qB62Bf3/9/E4UibXNu WzAv7B0ff15/H8Oofxn53t1J9gCQG0pVLEB3EeODdksw1wRYtb7DeAeSPT8ILaZkA5vwiS 0jv19XjH+sr0nIVITH6/OfstTTB24p0i18edzjEsoWwYWWJFici2j87WnBOOmnz6EO4ok0 ygUl1MLh7v1lVjWMjMytE2ojFcJ6EHjKVSvrB0ACb1ChWqVAq7Arjpo65J6Me2MGeSAbmW WtbWj0e+1yzd/HVz4cEKzMu20vlcO97qwLV96Qob9mNpOtlX/LP1DAAf76wWmA== X-Migadu-Spam-Score: 5.22 X-Spam-Score: 5.22 X-Migadu-Queue-Id: 05CD01D743 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Vi98idBs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-TUID: f8TrZxIvYAe1 Hi Florian, On Tue, 13 Dec 2022 at 11:51, Florian wrote: > These also would be those "prerequisite-patch-ids" hanging around, that > are generated by the --base=3Dauto flag I use with git send-email like a > good manual follower. I don't want to operate on multiple guix repos or b= ranches, I find > the workflow to keep one updated time-consuming enough so far... So I > guess, to be frank, what can I actually do about that? I understand. My point is just that it can be hard to be sure that the patch set correctly applies; because some prerequisite-patch-ids could modifies something without being included. For instance, I think it is what is happening with this current patch set. On the top of, base-commit: 0ce1f82e5aaac951b21d579eb46bf75cfe6713c0 from the master branch, PATCH 1/3 correctly applies but I am failing to apply PATCH 2/3. --8<---------------cut here---------------start------------->8--- error: patch failed: gnu/packages/wm.scm:102 error: gnu/packages/wm.scm: patch does not apply hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch Applying: gnu: Add clightd Patch failed at 0001 gnu: Add clightd --8<---------------cut here---------------end--------------->8--- Well, I understand your workflow, I guess. My point is just to mention that creating a branch with Git costs nothing. For instance, --8<---------------cut here---------------start------------->8--- git checkout -d example git reset --soft 0ce1f82e5aaac951b21d579eb46bf75cfe6713c0 git cherry-pick 5ad571d5a145a7a33ec9241bf75f25cf4864e629 git format-patch -1 --cover-letter --base=3D0ce1f82e5aaac951b21d579eb46bf75= cfe6713c0 git checkout master git branch -D example --8<---------------cut here---------------end--------------->8--- where 0ce1f82e5aaac951b21d579eb46bf75cfe6713c0 is =E2=80=99origin/master=E2= =80=99 when you created this patch set. And where 5ad571d5a145a7a33ec9241bf75f25cf4864e629 is the commit adding libmodule. >From my point of view, it changes almost nothing for you and, IMHO, it helps the review, both the human and the automated [1] ones. Obviously, it is an opinionated minor comment. :-) And for sure, the most important is that you send your contributions=E2=80=93meaning, the way= that is comfortable for you. 1: https://qa.guix.gnu.org/issue/60013 Cheers, simon