From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0KwoFBb9z2OZNAEAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 16:45:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0FFSExb9z2M3kQAAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 16:45:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 206D71C37F for ; Tue, 24 Jan 2023 16:45:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKLTk-0002xo-4D; Tue, 24 Jan 2023 10:44:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKLTe-0002xQ-2O for guix-devel@gnu.org; Tue, 24 Jan 2023 10:44:50 -0500 Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKLTc-0007e5-Ft for guix-devel@gnu.org; Tue, 24 Jan 2023 10:44:49 -0500 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4P1WW26cQrzDqMX; Tue, 24 Jan 2023 15:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1674575087; bh=HwBxDflbSgB8lPfjmJz0ei77ah75NfUO6BK9AAP5BRo=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=oL5n8kwJask44gF8WKKudEDIBNcAZir+1WFWeLBIpzpzGEyasIO3Ho73Mj3oR9GSc GuiUvtIqNMl8+llL87a1E1FGhskoZxj1m4SMjJ7ppRzuRKRHjcJtCZ0ppJMomv1WqA rh9KZosRzmChWqoYolZi82MpijIwr2dL79zq40CU= X-Riseup-User-ID: 7CAC7CCDD5C26A8B423EBBC6351CA0D184903BF1B1C88CB6DF9B6D1772AEC006 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4P1WW21hMfz5vRl; Tue, 24 Jan 2023 15:44:45 +0000 (UTC) References: <864jsg63pj.fsf@riseup.net> From: Csepp To: Ekaitz Zarraga Cc: Csepp , Guix Devel Subject: Re: etc/commiter.scm should not commit Date: Tue, 24 Jan 2023 16:42:35 +0100 In-reply-to: Message-ID: <86pmb43pjr.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674575126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HwBxDflbSgB8lPfjmJz0ei77ah75NfUO6BK9AAP5BRo=; b=PqZabwJIZ4IqNSk99/dcXqqjkeOb5iztKZE9XAhW7ImlvN1jGmfIlkL2Xw1zxf518D8zDc xerrheWOQlVg9+X+fk3idWNSOSU/VwURJQoi6J7LEbvn8kfF/f1Q0n2geVuICcdar/DbZ+ CWROOBKUJT6Rpr2++GR91MoO/WYyHKocLxnaHf/J0alkXMB105t87YqX4WEY9FYa9tjLC9 OV9nXzeE1z4tnzFyCvuYNKBhmM0IMdJ/mY09dPits7OSvD+OTzLO+YgKmPe1Afm9awMsHU nhnI5LKYmRMsw3SnkVQxQW5cAiQxdMeOVOJxCKnlHoG0jRLiqU7kfTwtyHdbRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b=oL5n8kwJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=riseup.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674575126; a=rsa-sha256; cv=none; b=hrIg3sRaHxYOp50necD+6VAZ5vNDsIpWT0nXhMuNOjF1uudCXn81ugWSS1CfWzSYfc7req BO1EtMB0zIoNFXQtIcg11QYfpMvgkg5qBJJQgz5qTnEFr9W/y1Xm+w+Uesw26nSAJPSyhd rw6f/uwflbggAU9LN3pPghAt2up8qwjV9NMLqevqhXXyBe29JD9cgFUpoNiWFfKx0sQY+1 XnOfnhvK8mbPapMmyToHQAC5tpiS3EoF4G1MhkNFb4OE3LuNXkcg9xWZV4RYtDQOHkbGrt qUkvQExiiQtkvhPj/PJCE2dLdBbweDO8igTL1ddVRSeU/bBk5Xxwwwnh4qAHNw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b=oL5n8kwJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=riseup.net X-Migadu-Spam-Score: -4.92 X-Spam-Score: -4.92 X-Migadu-Queue-Id: 206D71C37F X-TUID: 6vd1TaYkhdxa Ekaitz Zarraga writes: > ------- Original Message ------- > On Tuesday, January 24th, 2023 at 2:50 AM, Csepp wrote: > > >> There have been countless times when I was using etc/commiter.scm and it >> commited more than it should have and then slapped an incorrect message >> on it. >> I think it would make a lot more sense if adding changes was left up to >> the human at the keyboard (at least by default) and the script was >> invoked only when editing the commit message. > > That could be done on a git hook but developers would need to configure it. It does not need to be a hook, it can be done by setting EDITOR or VISUAL, or commiter.scm can even retain its current interface and just internally git add everything and call the script that would decide the message based on the staged diff.