all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: Eric Brown <ecbrown@ericcbrown.com>, 40764-done@debbugs.gnu.org
Subject: [bug#40764] New package: r-restrserve
Date: Tue, 15 Dec 2020 15:35:45 +0100	[thread overview]
Message-ID: <86o8ivm91a.fsf@gmail.com> (raw)
In-Reply-To: <87czzcvhji.fsf@gmail.com>

Hi,

On Mon, 14 Dec 2020 at 12:54, Oleg Pykhalov <go.wigust@gmail.com> wrote:

> It adds ‘base-commit’ and optionally ‘prerequisite-patch-id’ (see [1]), which will
> help you to checkout base-commit and apply a patch, but still you will
> need to rebase on origin/master with solving conflicts AFAIK.

“with **hypothetically** solving conflicts”.  Well, it is by-design
because of Git.

It is still better than the current situation IMHO where it is boring to
apply old patches.


> Also, on git version 2.29.2 --base requires an argument.  If we apply
> the patch on 43946 issue, we should mention this in example.

Agree.

> And, IMHO, the --base flag should be mention inside the first paragraph
> of [2], where format-patch is recommended for patch submission.
> Otherwise people will send with and without --base, which probably
> will not hurt, but still.

Yes, the first paragraph seems better.

More people will send with base-commit and easier automation will be.
For example, we could imagine that the testing build-farm builds the
patch applied at the base-commit, so the reviewer can use the substitute
instead of burning CPU (sometimes the test suite is really resource
hungry).  The reviewer checks the compliance and rebase if needed.


All the best,
simon




  reply	other threads:[~2020-12-15 14:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 11:12 [bug#40764] New package: r-restrserve Eric Brown
2020-05-30 17:56 ` Marius Bakke
2020-12-09 19:36 ` bug#40764: " Christopher Baines
2020-12-10 12:36   ` [bug#40764] " zimoun
2020-12-10 13:18     ` Ricardo Wurmus
2020-12-10 14:22       ` Efraim Flashner
2020-12-10 14:25       ` zimoun
2020-12-14  9:54         ` Oleg Pykhalov
2020-12-15 14:35           ` zimoun [this message]
2021-05-26 22:33 ` [bug#48690] " Eric Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o8ivm91a.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=40764-done@debbugs.gnu.org \
    --cc=ecbrown@ericcbrown.com \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.