From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oJioN8A4wWB6OgEAgWs5BA (envelope-from ) for ; Wed, 09 Jun 2021 23:55:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wPjDMsA4wWAHBAAAB5/wlQ (envelope-from ) for ; Wed, 09 Jun 2021 21:55:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2943B15A06 for ; Wed, 9 Jun 2021 23:55:12 +0200 (CEST) Received: from localhost ([::1]:53920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr6AJ-0000mw-2l for larch@yhetil.org; Wed, 09 Jun 2021 17:55:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr6AA-0000mh-ST for bug-guix@gnu.org; Wed, 09 Jun 2021 17:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lr6AA-0006Y3-J6 for bug-guix@gnu.org; Wed, 09 Jun 2021 17:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lr6AA-0003r2-1d for bug-guix@gnu.org; Wed, 09 Jun 2021 17:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 09 Jun 2021 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45645 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Received: via spool by 45645-submit@debbugs.gnu.org id=B45645.162327569114789 (code B ref 45645); Wed, 09 Jun 2021 21:55:02 +0000 Received: (at 45645) by debbugs.gnu.org; 9 Jun 2021 21:54:51 +0000 Received: from localhost ([127.0.0.1]:34817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr69y-0003qO-H7 for submit@debbugs.gnu.org; Wed, 09 Jun 2021 17:54:50 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:53807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr69x-0003q9-34 for 45645@debbugs.gnu.org; Wed, 09 Jun 2021 17:54:49 -0400 Received: by mail-wm1-f46.google.com with SMTP id b205so240042wmb.3 for <45645@debbugs.gnu.org>; Wed, 09 Jun 2021 14:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TpeFUfag+6Opsb+PLTlVFLNnmMLGJid9bbDz/jJTvUQ=; b=m5X28m4H0CStNS3+I6gQTYWKWJv5m2PcuOUqeq7fR0fkLlfvlx2QNCYND4dFlsCUVo sp3RhYr4x4/gAAfiKFxMVDP35WSKPmyVmiybZnV4pcf3mQEzTGuuIy4nOliUwbHJ8Zl2 la4NJ1kRJI8bacQl3mi0zsjrh0GAGIkQxubB4WscIKGLHsqJl5GIhHXIV4rOMYnyr/Mv H3mnMxPgiWlTn/FOHU/Leqgpt4eR7SheRP/Qpbz0s5DAeqy+pvkOFcls19w50jCygHjs oSPfqnhF8Bo3bAJpkTxNkwmxBK/+SbOFfaqC1O92Dhua4OhAiJay49RbcXW0M03qeeTn Hpow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TpeFUfag+6Opsb+PLTlVFLNnmMLGJid9bbDz/jJTvUQ=; b=bUklS9xMwORVN1AsXCS7SrKLBh0AB8miQEhh8UJcYcF2E5qOMmPuq8kC5uEzTYusmf 4ExRj2X6TOfBgXrY39aXdw/8Cqe61XjJQCy+HQYyHP7Z5hpS5+hInMuhzu+vKzUGvEPD Q6kqwpdltJESazjuaqKPGlrklSU5Ffx++XCelVSGOOrwcLVxoB/WZQSitQ6dDiSmtlZ4 tT1mepmvsQ30pA8NJVby6JD4eUD7WrUf7mp/rWqMFr0wGl+f9S05yLNWXqJ2GQbAKAH1 DeHTZjHTVkBoQS1PAUXZivcH99+OSPKts4RoACdsrnJR7c9Ofvi1tqhzm/u1lWs+5EsQ ah8g== X-Gm-Message-State: AOAM533QyD9ohOvxnuG1zYfYQeO6oCYbTs8C1qS00lt4ii8o/3+xpxya x9TNcG3/3Jqu+Z665xpLYA4= X-Google-Smtp-Source: ABdhPJwqbgZNKeR7aDoRR5zb2gEUi1LzOyMSeHuT4AVmphRZ5FaVmK2oLSeo10CKKziPX+FeaMNeyw== X-Received: by 2002:a05:600c:1553:: with SMTP id f19mr1836848wmg.158.1623275683264; Wed, 09 Jun 2021 14:54:43 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id i16sm925318wmm.9.2021.06.09.14.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 14:54:42 -0700 (PDT) From: zimoun References: <86o8f69so0.fsf@gmail.com> Date: Wed, 09 Jun 2021 23:48:48 +0200 In-Reply-To: (Efraim Flashner's message of "Mon, 29 Mar 2021 16:15:00 +0300") Message-ID: <86o8celnen.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45645@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623275712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TpeFUfag+6Opsb+PLTlVFLNnmMLGJid9bbDz/jJTvUQ=; b=Emtl8MqoEOd9RGMCTsCu+1ZZHVg/X2vHnH0cCH3aTE403JcyG7G4rAKr7ugLqyyhLvphA4 b3x6JPtUAMTdYsfdkjv+Wgl9ETS3CiWQaQgr9mv7AmmyHxg0pgSxgLl5N6KPuqeJjV4hXd czvV5YLPEws1AjjngzlOUkK194tk8Z8TfL4Jet6hdVYTHl5a4vt/bU/B96GOe4Tv7W5gBl MFLZe+xgf40NIrXPARQI2FuxSTWLrOdJBi7W1t/ZRg1jdMQXAwXTERGzOjWDP2M7AfGO6w 9cb9tmfnKv5FPlhC7LQDAFm3ciQmoF6HeFfaSIsXhDrZy/uO61SZkhKxXeSwLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623275712; a=rsa-sha256; cv=none; b=dbXh9JTGywxILqDF+D1N0mdO5j5kMUVpzPhT8VkZySyGDRqEzfm3d0HuY60HE9jTvk7OzG 242dPwRlTakhqXjGQLRMvKp+C2O9ELdqaHak7VMvOkGc3f0j1CH/syvrdhwcdcuIavu0Oa h3MrijRrNdBCOXgfpvut60hmLOwRPIRUAqbFu2lQ7uSXPfGRB1ZkYoNvdabeqLcZKvCwz1 TakiMOwX/5nRFKm2qqJYrqM3RDx2evov2Yov/PZpcsa2nZWE++hwkH9ZZsWbl9QufVc/4R StMp5Xrb8rHwKm6kN1rfvauVtPug5lNL6am+6KPFUHiQtywqnmIIqM381HrsUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=m5X28m4H; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=m5X28m4H; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 2943B15A06 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: oTZo/9FiJoet Hi, On Mon, 29 Mar 2021 at 16:15, Efraim Flashner wrote: > On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote: >> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner wrote: >> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote: >> >> >> ``` >> >> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR"); >> >> std::string data_dir; >> >> if (!opt_data_dir) { >> >> if (!only_data_dir) { >> >> if (stardict_data_dir) >> >> data_dir = stardict_data_dir; >> >> else >> >> data_dir = "/usr/share/stardict/dic"; >> >> } >> >> } else { >> >> data_dir = get_impl(opt_data_dir); >> >> } >> >> >> >> ``` >> >> >> >> Please revoke the content of this commit. >> >> I am not seeing a commit reverting >> 7dd1a2174a8376c521dcf271e3b76f64096074fe. Am I correct? > > That's right, I didn't end up reverting it. > >> > Do you have an easy test case? Something like 'guix environment --ad-hoc >> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What >> > is it looking for, just one directory? >> >> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a >> proper fix or is it let as it is? >> >> In order to close this. :-) > > I suppose we could revert it for now. I don't know of any dictionaries > that it would currently use and according to the bug report it isn't > working as expected. I was hoping to get it working but moved on to > other things. The commit 7dd1a2174a8376c521dcf271e3b76f64096074fe is not reverted. Let revert and close this bug report. Or add a comment in gnu/packages/dictionaries.scm and close this bug report. :-) Cheers, simon