From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YM1TLt0c+WQz4AAAG6o9tA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 02:44:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YM1TLt0c+WQz4AAAG6o9tA (envelope-from ) for ; Thu, 07 Sep 2023 02:44:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F03163977 for ; Thu, 7 Sep 2023 02:44:12 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=YM0Ha1IH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694047453; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=YYqrk60Wemz6HEJbTSOI1U3oiGLWNkXz19TBlI3s2Yo=; b=VCep2ekV+6LDUM5TzVJ8F0ZrssIMVwf9J2ZCUT4qXvtHv6xRgb4E0x8adZB6JAFI/xnyDC oOyVUdQQxidTSGy04IIm2cBQhGt7sLZYJ4PO5wXWHLY/RRQpzvGOvElPN6kj2q3GlPJjRJ 4mgxDxtHj3MoGG6S0rFvUwp2AWBviP4rzYbObpWOoMD24G34sJxjdUJKr6PSP4tYcHl3lQ b/ayTVMO18ZL6OhtOahr55sAwWS5C4+EeyTyAeONHAtZ6sD/jAij1jzPxNMCUW0xqFfpCs SRVqEJq1DM2rG2bOWV/VQBNhpRHrszkPj2G0hJ/6FSPQjL3QiNKDhgSdYzKiPw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694047453; a=rsa-sha256; cv=none; b=XGGtdW7wZPbheHrPE28SGfKzrpPg7jixBAn/Mk+O89AQP2nUgr+fUao/aEY4eQKsvrhjSc +FFwrYcXuJqAsmxse1zh9USnO5Ki0DJnk4FzyKc83vHVtUoYHW6y5t26LRZITQSDHk6JSl D2SpltArlVYUv3gaahCTDVm0mZWCS7ObsLTwYUBumJyG0Y+peTZrewWdGx5P+TZRxW+dhI GwJrAgilYdd5l/3Xq+Nb9uF/eaOMuMT7nX76l5Cv2bktKgFWnrdKxz0+qq4xxU+eQQ7Yi0 0OcCpcMFws2mlVchlvWCZP5uvu+IifcKH4olNhIWHa+tjtnUXUHZkTFcmpD1+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=YM0Ha1IH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qe37f-0006pW-Cw; Wed, 06 Sep 2023 20:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe37Q-0006Qe-Bv for guix-devel@gnu.org; Wed, 06 Sep 2023 20:43:37 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qe37N-0002j3-IH for guix-devel@gnu.org; Wed, 06 Sep 2023 20:43:36 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-401e6ce2d9fso1031195e9.1 for ; Wed, 06 Sep 2023 17:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694047411; x=1694652211; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YYqrk60Wemz6HEJbTSOI1U3oiGLWNkXz19TBlI3s2Yo=; b=YM0Ha1IHEP7Dww3+soS2UN2lM6CQdha8a6CaQPIZZ9hGoQ7xNyvOIuvWYttfjgJD1E i6AH4qaV+u4Uwxwume53HeNSluuOtcsnycx3d9vG+sCcf8m1LQ821P2Ijf5B22a4vKDT CO2RPZHZmDtVyWqwQ16oCTNi49HiexN4ssm+zdFxJxIh7Ufd1XNsx7LzaKUkFgs4i2Dc 5FRJC1+TtHc9iDv97VO8PYrYva4DhYiGH3uYjpAO5SJly8j57It9VKGL+ks/NWfrfaCa f8PVaCyRjmf7M9+Ek9SxX0m5bq5dFb5E82i3PpDn671sjU+Mj7ol2hqz+z0O4yO8cit1 Gbag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694047411; x=1694652211; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YYqrk60Wemz6HEJbTSOI1U3oiGLWNkXz19TBlI3s2Yo=; b=cYxDM8wIh1dDri1y3kXGWIn239Lnj5Z3m10xLKL8MY9mAZt7hGh2W1AlGFEUPIGtCY SCFoNYPsa2z0HjX3LPIWEdRZjuKLMiipZzBuQPELeNHHLIHGDafwOsbZNXv4A1sxF2Iy uO8kAFZWWmkZ0n/Kzqye2isdQiySaJp3gpotu1YiUVJeGgimJCkuindv2kF7BifeUG8z AVqiwNLmik05GoDRC2+9mhce+hOEB+xHdHLk3z8Aa+jNYoavLQXzJw+B7C0rdJnOQlcH tjl0boViwwpIOmiyKgiSEgQ5pVX06bX66A0dIQn8YJy38htpXPmS0MNrNLQ5upi3VlO7 3Sng== X-Gm-Message-State: AOJu0YyLBKoJy4B3LfIEjDlF+AUhHKRl3Q1Hn4RxRw9jgXWSqh6lFKcp yUp6uxOap0gfUsCrJrwKOLI= X-Google-Smtp-Source: AGHT+IFdOYLU/u7z1+AijheOhbfrbkzPzoGWluurQqTyl/NQT+PzDmhhAZS1LJjh/8H4P3ePrg4CfA== X-Received: by 2002:a05:600c:4f14:b0:402:dd10:42d with SMTP id l20-20020a05600c4f1400b00402dd10042dmr3302108wmq.4.1694047410760; Wed, 06 Sep 2023 17:43:30 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id n17-20020a1c7211000000b003feef5b0bb7sm898842wmc.40.2023.09.06.17.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 17:43:30 -0700 (PDT) From: Simon Tournier To: Maxim Cournoyer , Giovanni Biscuolo Cc: guix-devel@gnu.org, Vagrant Cascadian Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <87edjb5le5.fsf@gmail.com> References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> Date: Thu, 07 Sep 2023 02:23:33 +0200 Message-ID: <86o7ien856.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.18 X-Spam-Score: -5.18 X-Migadu-Queue-Id: 2F03163977 X-TUID: nER7/gr6bJpQ Hi, On Wed, 06 Sep 2023 at 12:14, Maxim Cournoyer w= rote: >> Let's avoid manual gardening as much as possible! :-) > > I like the idea! I think that automatizing is not trivial. Sadly. There are many corner cases: 1. series as attachement 2. not all the series is applied 3. commit message had been tweaked 4. etc. The potential issue is the number of false-positive; closing and the submission is not applied. Maybe patchwork already running (I think) could help, trying to regularly rebase the branch dedicated to the submission on the top of master, then if all is fine, somehow the two heads from the master branch and the dedicated branch should match, and it would indicate the patches are included and it is safe to close. More or less. :-) That=E2=80=99s said, I always find annoying to loose the track between the = Git history and the discussion that happened in the tracker. Sometimes, rational of some details of the implementation had been discussed in the tracker and it is impossible to find then back. Therefore, I would be in favor to add =E2=80=99Close #1234=E2=80=99 in the commit message, say th= e first one from the series tracked by #1234. Doing so, it would ease automatic management of guix-patches. However, it would add again some burden on committer shoulder. Similarly, we are already adding in the commit message something like =E2=80=99Fixes =E2=80=99. And that= could be used for closing. Again, the concern is about false-positive; closing when it should not be. Well, I think that automatizing is not trivial. :-) Cheers, simon