all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 25752@debbugs.gnu.org, Hank Donnay <hdonnay@gmail.com>
Subject: bug#25752: Acknowledgement (go incremental builds broken)
Date: Fri, 18 Dec 2020 21:00:14 +0100	[thread overview]
Message-ID: <86mtyavq9d.fsf@gmail.com> (raw)
In-Reply-To: <20170225155814.GB3227@jasmine> (Leo Famulari's message of "Sat,  25 Feb 2017 10:58:14 -0500")

Hi,

On Sat, 25 Feb 2017 at 10:58, Leo Famulari <leo@famulari.name> wrote:
> On Fri, Feb 24, 2017 at 02:50:10PM -0500, Hank Donnay wrote:
>> After talking on IRC, it seems like grafts are the problem. Adding
>> `--no-grafts` to the above commands has them succeed.
>> 
>> The GOROOT (store location, in this case) gets encoded in the
>> generated source by the 'dist' tool, so changing that is going to
>> cause issues.
>> 
>> Is there a way to disable grafts on a per-package basis, in the definition?
>
> You can disable them on the command-line for any tool that builds
> things, using the '--no-grafts' option, which is a "Common build option"
> [0]. For example, `guix environment --ad-hoc go --no-grafts`.
>
> If you do this, you should understand that the ungrafted Go package will
> contain some serious security vulnerabilities, since we only use grafts
> to fix vulnerabilities in core packages. [1]
>
> We should figure out why this issue manifests when go is grafted, and
> fix the root cause.

I suspect closing this bug had been forgotten.  If yes, feel free to
close it.  Otherwise, I do not understand what is the next actionable
step.

<http://issues.guix.gnu.org/issue/25752>

All the best,
simon




  reply	other threads:[~2020-12-18 20:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 15:05 bug#25752: go incremental builds broken Hank Donnay
     [not found] ` <handler.25752.B.14872575426869.ack@debbugs.gnu.org>
2017-02-24 19:50   ` bug#25752: Acknowledgement (go incremental builds broken) Hank Donnay
2017-02-25 15:58     ` Leo Famulari
2020-12-18 20:00       ` zimoun [this message]
2020-12-18 21:31         ` Leo Famulari
2021-01-11 12:46           ` zimoun
2021-01-11 20:01             ` Efraim Flashner
2021-06-09 21:38               ` zimoun
2021-11-26  1:12               ` zimoun
2021-09-14 10:43           ` bug#25752: go incremental builds broken zimoun
2022-10-26 20:42             ` zimoun
2022-10-27 10:21               ` Maxime Devos
2022-10-28  8:22                 ` zimoun
2023-10-16 22:44                   ` Simon Tournier
2017-03-07 21:50 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mtyavq9d.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=25752@debbugs.gnu.org \
    --cc=hdonnay@gmail.com \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.