From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AFcGB7gSzGMnEgAAbAwnHQ (envelope-from ) for ; Sat, 21 Jan 2023 17:28:40 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AIwYBrgSzGP/oAAAG6o9tA (envelope-from ) for ; Sat, 21 Jan 2023 17:28:40 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8CA6101BF for ; Sat, 21 Jan 2023 17:28:39 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJGiu-0003aC-Ob; Sat, 21 Jan 2023 11:28:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJGit-0003a0-Qj for guix-devel@gnu.org; Sat, 21 Jan 2023 11:28:07 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJGis-000798-25 for guix-devel@gnu.org; Sat, 21 Jan 2023 11:28:07 -0500 Received: by mail-wr1-x430.google.com with SMTP id d2so7291177wrp.8 for ; Sat, 21 Jan 2023 08:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vx5Q2Ewr/x51l5f9HLbpc0S0cwMOhiZYNAG3e61Eb7c=; b=cdSs5hLcRgZqtN2Vc226zb+MlmF1yQ0rfHOkyu3qLbf0EaTvUBhXU4xKV/RCtcwTZQ 47eY8maLamyykr0SRX1aPWIZJ9FOcZZ6FVzw/ceZa4uVA6vV4rb8yfVbbMEtJuZeYL49 hh+IR14jUy/bqubCUfrcyZTolpOSCLEnAy5TzEWBXvHupzEfMciMsC2+odMA1DcP05dp X86JV9+tbix4qWjgo8tl6Vfzx10uGhtRUuEvmrQgt9/1ejpGjXDYuZnYjjDjeM7lSHO6 rodYuQ0otAfqmFjl1qB2UHOO0xsTddfSQIZxvgjPeEfIPFuGyHpaYqZE+kYNs3aEWdfW NkGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vx5Q2Ewr/x51l5f9HLbpc0S0cwMOhiZYNAG3e61Eb7c=; b=R6RdZABWFnkabjiOb6z6mn1S34QAwsNuE/3LuSDJdynh25yKMdEgHNZfp/QEIS1+5f E4bky7N6U+xtIBEWNx/F+XcvhnToSR3+ThlbYJZ9R0lgG7jghkPDcuHWqOO0AinTAs/u AJx5IbuRZJqUwmX02ugfFoxfmC3UT3MpAcUcMTlKLAln5gUtGmMZYERaeJbye6sOKsCC Jln/iwTUwUONbmcqv1vHTSy+BCobZB6/l1arFoW8KQnDnTo+H3PgRj5PQcDXRvlYAyW6 AVbaiw5nT5opxn3qyCbXXL3Djb3b0WM1k5oZ9C2868aEay15DIFeDAN4vW4sYilmzqJ/ Yk2Q== X-Gm-Message-State: AFqh2kqh2jcSKwU//LMV+iGOiaBceHYqk4OSYL+iHDngeVRx8O6aeHZW LJXAMlnuxM/4lUK3qfK/RQ3Fjq2c2xI= X-Google-Smtp-Source: AMrXdXsvb3kyts6iL+l0fSstvbUj0b/cu/GrVOuQNc/LWRAeJzghzkZkkVV0q7ak0ThlQ5RfB/2RNw== X-Received: by 2002:a05:6000:789:b0:2bd:e738:a58b with SMTP id bu9-20020a056000078900b002bde738a58bmr3514905wrb.4.1674318484112; Sat, 21 Jan 2023 08:28:04 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id c14-20020a5d4cce000000b002426d0a4048sm1116379wrt.49.2023.01.21.08.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jan 2023 08:28:03 -0800 (PST) From: zimoun To: Tobias Platen , Guix Devel Subject: Re: My first package In-Reply-To: References: Date: Sat, 21 Jan 2023 16:50:06 +0100 Message-ID: <86mt6b3n0x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674318519; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vx5Q2Ewr/x51l5f9HLbpc0S0cwMOhiZYNAG3e61Eb7c=; b=Pg4/7vO7jQocZ/rhNIlAkPVMwPZA0fJ9RsQX+oRehPFl+e2k1ZpMQKt7FZAeSjO+bR9sY0 xaMq7V1yR7lV+YLdqikppUblyek2jZ6UqzE09bNrdnzdjZ+Mbm6nO35S+VTIX1+p+xPqIH JizbgZBaG8imya3uta2w18DNEJIcPX1n0pc+Q2Dlq2ib8C2cmogtWkPgOHBZTW47yGmskS Jey6R4usklhLzEMs1Lxk9MCYQmq3abYdH6xBkFgJRkqoxBKit0WeYq262OFdnTcrPr1WPh Ji4Yw0n0CBZb/ME+B5ouxmbyjw3GquQj/Aky9FuUzwjsKpDxo/Q1B4KSyyWosw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cdSs5hLc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674318519; a=rsa-sha256; cv=none; b=apwgb5anqUbbrceEZ8QhA1i6L7iAsVDFqyMPFmb4gfoLXH+Ek4V9vGmEv6ibSLGO/ABYuy gH1gDaYY/PioAn6Soc0lxcBsWQkBl0maiauE6eSeENw1KqCWDkRsYwHk/Ai8hBZCtBCUlO qiluLI3Myk5Uo/M2IwDSjRbRF9UUFOJA78nz6P5SgFALXQjov4xKJfr6NEtB2XRtI9wdth SKqyU1PouKqtftNe6MiEGWlgpzJ91cJB4iSM6VCT1OgLhuljCuMc0hRbr5ZzPZcD/a9XH8 EhVUuplGWVaXGHSpHC86eYwfATNpiQcvQEzNbSRJLarfsqyuMsWryG6YXzI0gw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.77 X-Spam-Score: -4.77 X-Migadu-Queue-Id: D8CA6101BF Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cdSs5hLc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-TUID: u23sxx/ek4k3 Hi Tobias, Sorry for this late reply. On Thu, 15 Sep 2022 at 09:35, Tobias Platen wrote: > I've created my first package for guix, the sekai speech synthesis > toolkit which I use mainly for producing singing voice with lilypond. > I'll also plan a talk at the gnu hackers meeting how I make Desktop > Music using the Guix System. Two more packages will follow next. Cool! Thank you for your contribution. For easing the merge, could you send to guix-patches@gnu.org this patch using git-format-patch with a commit message. Well, please give a look at the section =C2=AB Submitting Patches =C2=BB [1] from the manual. :-) 1: Two minor comment starting the review. :-) > #:use-module (gnu packages textutils)) >=20=20 > + Here, you introduced an extra line. > +(define-public sekai > + (package > + (name "sekai") > + (version "0.6.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://notabug.org/isengaara/sekai") > + (commit "0.6rc0"))) > + (sha256 > + (base32 > + "0j55pipx3hcp0xl4v0d72fdwysnz9a9a40x65a9lxpl4k6wyp4nm"))= ))=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > + (build-system cmake-build-system) > + (arguments '(#:tests? #f)) The tests are disallowed. Any specific reason? If yes, the usual practise is to add a one line comment. For example, (arguments '(#:tests? #f)) ; no tests > + (inputs `(("fftw" ,fftw) > + ("libsndfile",libsndfile) > + ("pkg-config",pkg-config) > + ("gsl",gsl) > + ("jsoncpp",jsoncpp) > + ("boost",boost) > + ("jack" ,jack-1) > + )) Now, you can use directly, (inputs (list fftw libsndfile pkg-config gsl jsoncpp boost jack-1)) Cheers, simon