bug#48213: offlineimap build fails

bug#48213: offlineimap build fails

[Bone Baboon via Bug reports for GNU Guix]

On a x86_64 computer when I run `guix build --no-substitutes
offlineimap` the build fails because the "test_ipv6_available" test
fails.

In the system configuration ipv6 is disabled:

```
(kernel-arguments
 (append
  (list "nomodeset" "ipv6.disable=1")
  %default-kernel-arguments))
```

Taking the failing test's name "test_ipv6_available" literally I would
like to ask if having this test required to build this offlineimap
dependency is necessary?  Could this test be allowed to fail or be
skipped without failing the build?  This would accommodate Guix users
who have disabled ipv6.

`guix describe` outputs:

```
Generation 18   May 03 2021 13:15:55    (current)
  guix 065d2cd
    repository URL: https://git.savannah.gnu.org/git/guix.git
    commit: 065d2cd6ced96ddb38c15a46f798488f61660a33
```

Build error:

```
starting phase `check'
============================= test session starts ==============================
platform linux2 -- Python 2.7.17, pytest-4.6.11, py-1.8.1, pluggy-0.13.1
rootdir: /tmp/guix-build-python2-rfc6555-0.0.0-1.1a181b4.drv-0/source
plugins: hypothesis-4.57.1
collected 5 items

tests/test_ipv6.py F....                                                 [100%]

=================================== FAILURES ===================================
_____________________________ test_ipv6_available ______________________________

    def test_ipv6_available():
>       assert rfc6555._detect_ipv6()
E       assert False
E        +  where False = <function _detect_ipv6 at 0xf6c2887c>()
E        +    where <function _detect_ipv6 at 0xf6c2887c> = rfc6555._detect_ipv6

tests/test_ipv6.py:11: AssertionError
====================== 1 failed, 4 passed in 0.19 seconds ======================
command "pytest" "tests/test_ipv6.py" failed with status 1
builder for `/gnu/store/4clr8jgvlbhp9qvyx2izdl5dmb8b0xsd-python2-rfc6555-0.0.0-1.1a181b4.drv' failed with exit code 1
build of /gnu/store/4clr8jgvlbhp9qvyx2izdl5dmb8b0xsd-python2-rfc6555-0.0.0-1.1a181b4.drv failed
View build log at '/var/log/guix/drvs/4c/lr8jgvlbhp9qvyx2izdl5dmb8b0xsd-python2-rfc6555-0.0.0-1.1a181b4.drv.bz2'.
cannot build derivation `/gnu/store/pxqzkh8b6266qdrrxhfc74j6bjnb1567-offlineimap-7.3.3.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/pxqzkh8b6266qdrrxhfc74j6bjnb1567-offlineimap-7.3.3.drv' failed
```

bug#48213: offlineimap build fails

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Babs,

Bone Baboon via Bug reports for GNU Guix 写道：
> Taking the failing test's name "test_ipv6_available" literally I 
> would
> like to ask if having this test required to build this 
> offlineimap
> dependency

I think not, but you should report this upstream first.  They look 
asleep but I didn't hold a mirror under their nose.  If they don't 
respond we might hack around it in Guix.

I suggest that you enable IPv6 support in the meantime.

> This would accommodate Guix users who have disabled ipv6.

Guix doesn't virtualise the kernel and expects it to provide all 
that is needful.  Linux offers knobs for *everything*; that 
doesn't mean everything is supported.  Disabling kernel support 
for basic things (namespaces, UNIX domain sockets, IPv6) *will* 
break certain software.

We shouldn't feel obligated to accommodate strange configurations 
out of the box, but we try to do so when the maintenance cost is 
very low.  In this case, you'd need to ensure the test still runs 
on the vast majority of systems with IPv6.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#48213: offlineimap build fails

[Mark H Weaver]

Hi,

Bone Baboon via Bug reports for GNU Guix <bug-guix@gnu.org> writes:
> On a x86_64 computer when I run `guix build --no-substitutes
> offlineimap` the build fails because the "test_ipv6_available" test
> fails.
>
> In the system configuration ipv6 is disabled:
[...]
> Taking the failing test's name "test_ipv6_available" literally I would
> like to ask if having this test required to build this offlineimap
> dependency is necessary?  Could this test be allowed to fail or be
> skipped without failing the build?  This would accommodate Guix users
> who have disabled ipv6.

I will defer to the Guix maintainers on this question, but I just wanted
to point out that since 'offlineimap' is the _only_ package in Guix that
depends on the 'python2-rfc6555' package, it's quite painless to work
around this particular issue using Guix's "--without-tests" package
transformation option.

From the command line, you can simply do this:

  guix build offlineimap --without-tests=python2-rfc6555

Within an OS configuration, or within a profile "manifest" file (if you
use "guix package --manifest", which is highly recommended), you can use
the following Scheme expression in place of 'offlineimap':

--8<---------------cut here---------------start------------->8---
  (let ((transform (options->transformation
                    '((without-tests . "python2-rfc6555")))))
    (transform offlineimap))
--8<---------------cut here---------------end--------------->8---

Note that you'll also need to put "(use-modules (guix transformations))"
at the top of the file, to import the 'options->transformation'
procedure.

Please let us know if this works for you.

     Thanks,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.

bug#48213: offlineimap build fails

[Bone Baboon via Bug reports for GNU Guix]

>> This would accommodate Guix users who have disabled ipv6.
>
> Guix doesn't virtualise the kernel and expects it to provide all that
> is needful.  Linux offers knobs for *everything*; that doesn't mean
> everything is supported.  Disabling kernel support for basic things
> (namespaces, UNIX domain sockets, IPv6) *will* break certain software.
>
> We shouldn't feel obligated to accommodate strange configurations out
> of the box, but we try to do so when the maintenance cost is very low.
> In this case, you'd need to ensure the test still runs on the vast
> majority of systems with IPv6.

Sorry I should have explained the rationale for this in my initial
message.

For privacy conscious individuals one tool for improving online privacy
is a VPN service. Many VPN service providers recommend disabling
ipv6. This is because of ipv6 leaks. 

https://ipv6leak.com/ is a ipv6 leak testing site.  It is the first
result when searching for "ipv6 leak" with searx.ir.  Using this website
I can see that the privacy provided by my VPN service provider is
compromised by an ipv6 leak when I enable ipv6.  This is why I have ipv6
disabled.

I am open to suggestions on free software alternatives to using a VPN
service that do not require ipv6 to be disabled. The current VPN service
I am using allows the use of a openvpn client so I do not need to
install any proprietary software on my computer to use their service.  I
am aware of Tor or I2P but have not yet looked into how I could to send
my network traffic over those networks.

bug#48213: offlineimap build fails

[Bone Baboon via Bug reports for GNU Guix]

Tobias Geerinckx-Rice writes:
> you should report this upstream first

I have reported this to Seth Michael Larson the maintainer of rfc6555.
https://pypi.org/project/rfc6555/

I also asked Seth Michael Larson if the rfc6555 test suite could be
modified so that test_ipv6_available does not fail if IPv6 is disabled.

bug#48213: offlineimap build fails

[Bone Baboon via Bug reports for GNU Guix]

Mark H Weaver writes:

> Hi,
>
> Bone Baboon via Bug reports for GNU Guix <bug-guix@gnu.org> writes:
>> On a x86_64 computer when I run `guix build --no-substitutes
>> offlineimap` the build fails because the "test_ipv6_available" test
>> fails.
>
> 'offlineimap' is the _only_ package in Guix that
> depends on the 'python2-rfc6555' package, it's quite painless to work
> around this particular issue using Guix's "--without-tests" package
> transformation option.
>
> From the command line, you can simply do this:
>
>   guix build offlineimap --without-tests=python2-rfc6555
>
> Within an OS configuration, or within a profile "manifest" file (if you
> use "guix package --manifest", which is highly recommended), you can use
> the following Scheme expression in place of 'offlineimap':
>
> --8<---------------cut here---------------start------------->8---
>   (let ((transform (options->transformation
>                     '((without-tests . "python2-rfc6555")))))
>     (transform offlineimap))
> --8<---------------cut here---------------end--------------->8---
>
> Note that you'll also need to put "(use-modules (guix transformations))"
> at the top of the file, to import the 'options->transformation'
> procedure.
>
> Please let us know if this works for you.

Thank you

I can build offlineimap with this command `guix build offlineimap
--no-substitutes --without-tests=python2-rfc6555`.

How would I refer to offlineimap (built without tests) in the
configuration of a substitute server's client?  The client is not
building it's own packages and is instead relying on a substitute
server to build offlineimap without tests.

bug#48213: offlineimap build fails

[zimoun]

Hi,

On Tue, 04 May 2021 at 16:39, Mark H Weaver <mhw@netris.org> wrote:

>From the command line, you can simply do this:
>
>   guix build offlineimap --without-tests=python2-rfc6555
>
> Within an OS configuration, or within a profile "manifest" file (if you
> use "guix package --manifest", which is highly recommended), you can use
> the following Scheme expression in place of 'offlineimap':
>
>   (let ((transform (options->transformation
>                     '((without-tests . "python2-rfc6555")))))
>     (transform offlineimap))

The package offlineimap will go sooner or later since Python 2 is EOL.
The migration from Py2 to Py3 is not clear [1] and the README [2] says:

  > As one of the maintainer of OfflineIMAP, I'd like to put my efforts into
  > [imapfw](http://github.com/OfflineIMAP/imapfw). **imapfw** is software in
  > development that I intend to replace OfflineIMAP with in the long term.
  >
  > That's why I'm not going to continue OfflineIMAP development. I'll continue
  > to maintain OfflineIMAP (fixing small bugs, reviewing patches and merging,
  > and rolling out new releases), but that's all.
  >
  > While I keep tracking issues for OfflineIMAP, you should not expect future support.
  >
  > You won't be left at the side. OfflineIMAP's community is large enough so that
  > you'll find people for most of your issues.
  >
  > Get news from the [blog][blog].
  >
  >                                  Nicolas Sebrecht. ,-)

IMHO, the transformation is the easiest to still have the package and
let the time to switch (to Offlinemap or something else).  For instance,

<https://github.com/OfflineIMAP/offlineimap3>

Note the package should always be available via inferiors.

All the best,
simon

1: <https://github.com/OfflineIMAP/offlineimap/issues/670>
2: <https://raw.githubusercontent.com/OfflineIMAP/offlineimap/master/README.md>

bug#48213: offlineimap build fails

[Mark H Weaver]

Hi Simon,

zimoun <zimon.toutoune@gmail.com> writes:
> The package offlineimap will go sooner or later since Python 2 is EOL.
> The migration from Py2 to Py3 is not clear [1] and the README [2] says:
>
>   > As one of the maintainer of OfflineIMAP, I'd like to put my efforts into
>   > [imapfw](http://github.com/OfflineIMAP/imapfw). **imapfw** is software in
>   > development that I intend to replace OfflineIMAP with in the long term.
>   >
>   > That's why I'm not going to continue OfflineIMAP development. I'll continue
>   > to maintain OfflineIMAP (fixing small bugs, reviewing patches and merging,
>   > and rolling out new releases), but that's all.
[...]
> 1: <https://github.com/OfflineIMAP/offlineimap/issues/670>
> 2: <https://raw.githubusercontent.com/OfflineIMAP/offlineimap/master/README.md>

Thanks for bringing this to our attention.

Incidentally, I used 'offlineimap' for several years, and one day it
stopped working for me with an inscrutible error ("invalid literal for
int() with base 10: ''") , and I was never able to get it working again.

I eventually switched to 'mbsync' from the 'isync' package, and it has
been working very well for my purposes.

      Thanks,
        Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.

bug#48213: offlineimap build fails

[zimoun]

Hi,

On Sun, 30 May 2021 at 15:27, Mark H Weaver <mhw@netris.org> wrote:
> zimoun <zimon.toutoune@gmail.com> writes:

>> The package offlineimap will go sooner or later since Python 2 is EOL.
>> The migration from Py2 to Py3 is not clear [1] and the README [2] says:
>>
>>   > As one of the maintainer of OfflineIMAP, I'd like to put my efforts into
>>   > [imapfw](http://github.com/OfflineIMAP/imapfw). **imapfw** is software in
>>   > development that I intend to replace OfflineIMAP with in the long term.
>>   >
>>   > That's why I'm not going to continue OfflineIMAP development. I'll continue
>>   > to maintain OfflineIMAP (fixing small bugs, reviewing patches and merging,
>>   > and rolling out new releases), but that's all.
> [...]
>> 1: <https://github.com/OfflineIMAP/offlineimap/issues/670>
>> 2: <https://raw.githubusercontent.com/OfflineIMAP/offlineimap/master/README.md>
>
> Thanks for bringing this to our attention.
>
> Incidentally, I used 'offlineimap' for several years, and one day it
> stopped working for me with an inscrutible error ("invalid literal for
> int() with base 10: ''") , and I was never able to get it working again.
>
> I eventually switched to 'mbsync' from the 'isync' package, and it has
> been working very well for my purposes.

Since ’isync’ seems the standard replacement of ’offlineimap’, I propose
to remove ’offlineimap’.  For example, add a news entry and deprecate
it, wait X months, and complete the remove.  WDYT?

Cheers,
simon

bug#48213: offlineimap build fails

[zimoun]

Hi,

On Thu, 27 May 2021 at 22:55, zimoun <zimon.toutoune@gmail.com> wrote:
> On Tue, 04 May 2021 at 16:39, Mark H Weaver <mhw@netris.org> wrote:
>
>>>From the command line, you can simply do this:
>>
>>   guix build offlineimap --without-tests=python2-rfc6555
>>
>> Within an OS configuration, or within a profile "manifest" file (if you
>> use "guix package --manifest", which is highly recommended), you can use
>> the following Scheme expression in place of 'offlineimap':
>>
>>   (let ((transform (options->transformation
>>                     '((without-tests . "python2-rfc6555")))))
>>     (transform offlineimap))
>
> The package offlineimap will go sooner or later since Python 2 is EOL.
> The migration from Py2 to Py3 is not clear [1] and the README [2] says:
>
>   > As one of the maintainer of OfflineIMAP, I'd like to put my efforts into
>   > [imapfw](http://github.com/OfflineIMAP/imapfw). **imapfw** is software in
>   > development that I intend to replace OfflineIMAP with in the long term.
>   >
>   > That's why I'm not going to continue OfflineIMAP development. I'll continue
>   > to maintain OfflineIMAP (fixing small bugs, reviewing patches and merging,
>   > and rolling out new releases), but that's all.
>   >
>   > While I keep tracking issues for OfflineIMAP, you should not expect future
>   > support.
>   >
>   > You won't be left at the side. OfflineIMAP's community is large enough so
>   > that
>   > you'll find people for most of your issues.
>   >
>   > Get news from the [blog][blog].
>   >
>   >                                  Nicolas Sebrecht. ,-)
>
> IMHO, the transformation is the easiest to still have the package and
> let the time to switch (to Offlinemap or something else).  For instance,
>
> <https://github.com/OfflineIMAP/offlineimap3>
>
> Note the package should always be available via inferiors.
>
> All the best,
> simon
>
> 1: <https://github.com/OfflineIMAP/offlineimap/issues/670>
> 2: <https://raw.githubusercontent.com/OfflineIMAP/offlineimap/master/README.md

Considering the package 'offlineimap' is not supported upstream because
it is Python 2 based and Python 2 is now End Of Life since January 1rst
2020, I propose to close this bug.  The package 'offlineimap' will go
soon or later.  A standard replacement is the package 'isync'.

All the best,
simon

bug#48213: offlineimap build fails

[zimoun]

Hi,

On Tue, 13 Jul 2021 at 10:24, zimoun <zimon.toutoune@gmail.com> wrote:
> On Thu, 27 May 2021 at 22:55, zimoun <zimon.toutoune@gmail.com> wrote:
>> On Tue, 04 May 2021 at 16:39, Mark H Weaver <mhw@netris.org> wrote:
>>
>>>>>From the command line, you can simply do this:
>>>
>>>   guix build offlineimap --without-tests=python2-rfc6555
>>>
>>> Within an OS configuration, or within a profile "manifest" file (if you
>>> use "guix package --manifest", which is highly recommended), you can use
>>> the following Scheme expression in place of 'offlineimap':
>>>
>>>   (let ((transform (options->transformation
>>>                     '((without-tests . "python2-rfc6555")))))
>>>     (transform offlineimap))
>>
>> The package offlineimap will go sooner or later since Python 2 is EOL.
>> The migration from Py2 to Py3 is not clear [1] and the README [2] says:
>>
>>   > As one of the maintainer of OfflineIMAP, I'd like to put my efforts into
>>   > [imapfw](http://github.com/OfflineIMAP/imapfw). **imapfw** is software in
>>   > development that I intend to replace OfflineIMAP with in the long term.
>>   >
>>   > That's why I'm not going to continue OfflineIMAP development. I'll continue
>>   > to maintain OfflineIMAP (fixing small bugs, reviewing patches and merging,
>>   > and rolling out new releases), but that's all.
>>   >
>>   > While I keep tracking issues for OfflineIMAP, you should not expect future
>>   > support.
>>   >
>>   > You won't be left at the side. OfflineIMAP's community is large enough so
>>   > that
>>   > you'll find people for most of your issues.
>>   >
>>   > Get news from the [blog][blog].
>>   >
>>   >                                  Nicolas Sebrecht. ,-)
>>
>> IMHO, the transformation is the easiest to still have the package and
>> let the time to switch (to Offlinemap or something else).  For instance,
>>
>> <https://github.com/OfflineIMAP/offlineimap3>
>>
>> Note the package should always be available via inferiors.
>>
>> All the best,
>> simon
>>
>> 1: <https://github.com/OfflineIMAP/offlineimap/issues/670>
>> 2: <https://raw.githubusercontent.com/OfflineIMAP/offlineimap/master/README.md
>
> Considering the package 'offlineimap' is not supported upstream because
> it is Python 2 based and Python 2 is now End Of Life since January 1rst
> 2020, I propose to close this bug.  The package 'offlineimap' will go
> soon or later.  A standard replacement is the package 'isync'.

Considering this discussion, I do not see what could be done on the Guix
side.  Therefore, I am closing.

Feel free to reopen if I miss something.

All the best,
simon