From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4GT7KF4grmFI7AAAgWs5BA (envelope-from ) for ; Mon, 06 Dec 2021 15:38:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GN6jJF4grmEaCQAAbx9fmQ (envelope-from ) for ; Mon, 06 Dec 2021 14:38:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 487FC15117 for ; Mon, 6 Dec 2021 15:38:22 +0100 (CET) Received: from localhost ([::1]:55324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muF8F-0005IZ-Tb for larch@yhetil.org; Mon, 06 Dec 2021 09:38:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muF38-0003Ix-No for bug-guix@gnu.org; Mon, 06 Dec 2021 09:33:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muF38-0004Ad-Fs for bug-guix@gnu.org; Mon, 06 Dec 2021 09:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muF38-0003tn-BC for bug-guix@gnu.org; Mon, 06 Dec 2021 09:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52316: Package example from cookbook has bugs Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 06 Dec 2021 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52316 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos , 52316@debbugs.gnu.org Received: via spool by 52316-submit@debbugs.gnu.org id=B52316.163880115314948 (code B ref 52316); Mon, 06 Dec 2021 14:33:02 +0000 Received: (at 52316) by debbugs.gnu.org; 6 Dec 2021 14:32:33 +0000 Received: from localhost ([127.0.0.1]:60917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muF2e-0003t2-NZ for submit@debbugs.gnu.org; Mon, 06 Dec 2021 09:32:32 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:43784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muF2c-0003sZ-9Y for 52316@debbugs.gnu.org; Mon, 06 Dec 2021 09:32:30 -0500 Received: by mail-wr1-f41.google.com with SMTP id v11so22794633wrw.10 for <52316@debbugs.gnu.org>; Mon, 06 Dec 2021 06:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=aAIYdlkyc9i1mwHU01R3nS5P5+LMLeYuxljGUpwjjHg=; b=lYNN3uJf2+uf5/CQu8AbczEg30pn4fXO7VJOTjeiAds02y6Oq9859bReC7SAQ/U/KM FtWCLp/NHkDbx3DBzHQ8UMTBVySpQRsL17/5kNQewKmTBTQf2+R4xyiKO0e8rKCyOGcN l1gwayqUTg6WXGV18CuN2E3SCBwzbEfWG7L3M6uIL1txCKOVLt9a9lA+E6a/z9txyQHo Ttouoxv9zmeNLF1qV3yP+AsZkl/hmyEfgM3ALmhhuZu0XWIoRUNPAgv+kZmCIIT/iPxZ 47Ek9l0ovWu+jKzcHpDz6NKy101Alr92O2x09ByRvie0T2JSK9GsXnK7QWHtMF682Q+1 0t8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=aAIYdlkyc9i1mwHU01R3nS5P5+LMLeYuxljGUpwjjHg=; b=oDH8mTuc47i5PKgXjEMNyc/EPduZgcSLPZ7kVbWulyA6MFoQ7R1qx1vq0UfOmSkqvN nNp/wUE/qhTrG1LjGh7XN8Bseaq06j/X3xwvkzKadUZWLPL6QSRxcD5xk78XDzQGeV0d k+23Bx4jZp3Ltb+TNQzNd1grlEBEjYHJp0LXL6QNP5xWjJD3MGrBtn5CVg1se8lqdVzC 6lnfuTJxWX8mzOqr0T1J/MEdwZCRHubVlk05eYHXKUazWQX8TIfbaQFBzXu3H5FhOumH +8Qcd6IYW1EogL1UouGQjDSBsRyjLA91zF2Ddtx6q8b5+WAkkbltP4JgUe9zsAxzDOJM R4+g== X-Gm-Message-State: AOAM530KL3YJ2ZJ8LGCqEbOJtoJY/CBgYavkmdt3oadEWkuA6EMlrlfr 8IOc5V92Ery7dKLDpeiZWI64VVveoFM= X-Google-Smtp-Source: ABdhPJzRSod+a8QpJDBhpupii6tAWmVrLWRQejdFck5xqlZ2Vz87YNha2zog9agXG0Uupb3VFyq5TA== X-Received: by 2002:a5d:6dc3:: with SMTP id d3mr43676940wrz.159.1638801143503; Mon, 06 Dec 2021 06:32:23 -0800 (PST) Received: from lili ([88.126.110.68]) by smtp.gmail.com with ESMTPSA id o9sm11651157wrs.4.2021.12.06.06.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 06:32:23 -0800 (PST) From: zimoun In-Reply-To: References: Date: Mon, 06 Dec 2021 15:30:11 +0100 Message-ID: <86lf0xolfw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638801502; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aAIYdlkyc9i1mwHU01R3nS5P5+LMLeYuxljGUpwjjHg=; b=HBXHBnd1ah1YoYIDFbTok7cTZhDjByEz/Q0o3gaWrtTL9g17nDN8gVPrCRLI9G3o1JvuJ3 JHz6QrfbBIqJFnMS8Ns6bIDZbNXkVKFYVAmc6ds9Ze+R1k6u6WCF6p7pliOrYylMIwJVDr F4J5/537owXQKYoMkmqZvSK4lN4qK21dYKw7aXGjckNkenXZ23bpouEbqVk6+JTIKrDZXA /fUuwVpjzlwP8c9FYU0wzr4nRV5UYOkho+PRIUCocyLfCrxDe+YJEd41k667n0Q5e/UUXX EIR6x5bwdtdhheicyuBSu7iArj0vDrcu+7CKfviqSbIYDUt893nV6HVPiedlBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638801502; a=rsa-sha256; cv=none; b=pSEzpRhuIYDbBktbQID+BUSbTqk5dxO8/lGzUhaGN0oEaArEHLUmp0VSU7mayYbd2Psao+ RJXkHVhiqC8aAVBCW5tlMXaLg0o3HHsIeiP/tPgjYFn7ISTFJhAK5RS/4QV2COvLLusqM8 RofyfYl0ZWzTkuwnlmxwKPLgq6vu0aKwFr6bVyuDxyn93u5A8YLRRaCZ5aeqHY0g+aAOtr bMiRhwSyNEhzCs0G4DYlVVGl7mZplrPdlwJGSGl1Cxf5YtCPB8CM96S4RvA6DJnxkiTA4B AbeOoL8D11cO0HgUdIEhWLXxpnLKEKLIadZpNx8Kw4kOs6eTeeOAi+q+87I8xQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=lYNN3uJf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=lYNN3uJf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 487FC15117 X-Spam-Score: -0.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: tDHakHhRELQL Hi Maxime, On Sun, 05 Dec 2021 at 19:18, Maxime Devos wrote: > The example at > https://guix.gnu.org/cookbook/en/html_node/Extended-example.html has > two bugs: > > #:tests? is unconditionally set to #true. This is bad for cross- > compilation and --without-tests=3DPACKAGE reasons, and would be flagged > by the linter. For cross-compilation, yes. For =E2=80=99--without-tests=E2=80=99, it is n= ot an issue, IMHO, or why is it? > In the new 'check' phase, libgit2_clar is invoked unconditionally. This > would be flagged by the linter. Since it is an example showing non-trivial things, maybe it can be pedagogical to have something half good, if and only if, =E2=80=9Cguix lint= =E2=80=9D reports the half bad. And add an explanation. WDYT? > Also, not exactly a bug, but still bad practice: the web page suggests: > > #:make-flags (list (string-append "prefix=3D" (assoc-ref %outputs "out")) > "CC=3Dgcc") > > however, hardcoding gcc is bad for cross-compilation reasons. It should > use (cc-for-target) instead. I agree. Cheers, simon