From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2BC0JouXv2HGrQAAgWs5BA (envelope-from ) for ; Sun, 19 Dec 2021 21:35:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MJxmIouXv2ELbgAAB5/wlQ (envelope-from ) for ; Sun, 19 Dec 2021 20:35:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 45AD014EB8 for ; Sun, 19 Dec 2021 21:35:23 +0100 (CET) Received: from localhost ([::1]:48626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mz2tu-0000qO-1w for larch@yhetil.org; Sun, 19 Dec 2021 15:35:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz2tZ-0000pt-Vu for guix-patches@gnu.org; Sun, 19 Dec 2021 15:35:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mz2tZ-0004F6-NB for guix-patches@gnu.org; Sun, 19 Dec 2021 15:35:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mz2tZ-0005x1-Ko for guix-patches@gnu.org; Sun, 19 Dec 2021 15:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Dec 2021 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Philip McGrath , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163994609422858 (code B ref 51838); Sun, 19 Dec 2021 20:35:01 +0000 Received: (at 51838) by debbugs.gnu.org; 19 Dec 2021 20:34:54 +0000 Received: from localhost ([127.0.0.1]:48297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz2tS-0005wc-Ae for submit@debbugs.gnu.org; Sun, 19 Dec 2021 15:34:54 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:44876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz2tP-0005wS-Q4 for 51838@debbugs.gnu.org; Sun, 19 Dec 2021 15:34:52 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1639946090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYC+3V8Wd7k6+shUCEpPhHXbMifmVsPXPygQEpPvros=; b=uxmS5JIeANeKieQpSES7oIz/PK20u6vK4JcC9XVUFULx2Iyvtlh3PSztzi8v9DeArRUAZE cUrmZPDZaXsitSLUVtd6AC/Unzlfmj4g2rTS3d2yTcCK9HzannvzNjqASFWLSm0khBo5dI 5a6PHUh773f472BS6q0F/MMGLin1UdE= In-Reply-To: <39f8ce0c54d60adb54c1bb9035ff1b31d40cb5be.camel@gmail.com> References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-21-philip@philipmcgrath.com> <39f8ce0c54d60adb54c1bb9035ff1b31d40cb5be.camel@gmail.com> Date: Sun, 19 Dec 2021 21:34:49 +0100 Message-ID: <86lf0gcp06.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639946123; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YYC+3V8Wd7k6+shUCEpPhHXbMifmVsPXPygQEpPvros=; b=jReLUf58VH6W/3XKdAilHvJNzwfv0w5lVPND45PI5D0GbzcS3t6IZtbAoGjNaujFJ0vX2T zg/S2xYFetF2cK0rNL08dU0WawQK3M7oVJepCqbulqW5AsAwbrtYpiklgITNga0rjps1u1 9UvJPMZufpeV4F0+Qxs+Lt61OhIFpABgjUPUjMXKX5KABlH7JQ7euRj8JLSGfk1GqsvA7n dUiyF3eznD9f5+oUJeSPJ/vbFl83N8DUIF6NSKdY+dqIZ6dRcDxIZXkVgb+FPj72JO6Q7e hSupOHARUiDRbNU6yhODHIhSQjNAiT+6SxQgz63en4pYYK9tccyr7Wrhb1AkoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639946123; a=rsa-sha256; cv=none; b=agNbbQc3ckGpZnlG6B+TSiS32h+2HjGjrhtuUcLTv/TCqfVcXOWf53EIqSG7I4yTuxBOPl 4+pXtlRR3jIcf5hEntr+9xj6iAgcG+SOA9ltBIZuto/KdUCS/6ZsP2Hefz9omKgNgXU10r EBFpK5sLWzmaBnwXmkAoXwaPzicUUloeiRIKOyIfBDW0MzEmoh8Y/Uy1C3qmuChta/Ucvz 7QGLLskf7KPU/3ik/JXVfNcBjZfXkBoWlcfKrXTtvAktV5yVoiXzUNVe2JF9TKbZaQLxo0 3XWupjXMe5CCbHym4bBVe9mCRUksiyvzpzHu0s9/O5EkiTqFzpxjBjSlNsM75Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=uxmS5JIe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=uxmS5JIe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 45AD014EB8 X-Spam-Score: -0.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7L5vO9gDu2fv Liliana Marie Prikler writes: > Hi, > > Am Samstag, dem 18.12.2021 um 11:16 -0500 schrieb Philip McGrath: >> >=20 >> > Do this and #21 have to be separated so far from the rest?=C2=A0 If no= t, >> > I'd do build system first, then new packages.=C2=A0 Otherwise fair >> > enough. >>=20 >> I tried to follow Tim's suggestion in=20 >> to put the changes related to=20 >> #:absent-dependencies before the changes to support native addons, so >> that the earlier changes could potentially be applied even if there >> was more discussion needed for the later ones (if #:absent- >> dependencies were less controversial. > Fair enough, that does make sense. However, I do think that "add > package X" is not too big of a review burden, so I personally think the > fact we're deleting 'configure everywhere is holding back the change to > support native addons rather than the other way around. > >> But note that the patches before this one aren't adding new packages; >> they are changing existing packages to use #:absent-dependencies >> rather than deleting the configure phase. So the series is ordered >> overall as: >>=20 >> =C2=A0 1. Changes to the `node` package itself >> =C2=A0 2. Build system changes for #:absent-dependencies >> =C2=A0=C2=A0=C2=A0=C2=A0 (including the delete-lockfiles phase, because = un-deleting the >> =C2=A0=C2=A0=C2=A0=C2=A0 configure phase exposes those problems) >> =C2=A0 3. Packages changes to use #:absent-dependencies >> =C2=A0 4. Build system changes to support native addons >> =C2=A0 5. New packages to exercise the support for native addons > There is an unspoken bit here in #5 in that those packages still need > to get rid of unwanted dependencies, which makes this set still > unsplittable in a sense. > > If everyone else here agrees, I think we could at least upstream the > changes to node itself while we still discuss 2-5. Timothy, Pierre, > Jelle, WDYT? Agreed, thanks for asking.