From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MBgADS3ufGPqfwAAbAwnHQ (envelope-from ) for ; Tue, 22 Nov 2022 16:43:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mD3wDC3ufGPEHAEAauVa8A (envelope-from ) for ; Tue, 22 Nov 2022 16:43:41 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0665E2BACE for ; Tue, 22 Nov 2022 16:41:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxVOM-0007PH-Pf; Tue, 22 Nov 2022 10:40:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxVOH-0007P0-Uy for guix-devel@gnu.org; Tue, 22 Nov 2022 10:40:54 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxVOB-0004pf-0g for guix-devel@gnu.org; Tue, 22 Nov 2022 10:40:52 -0500 Received: by mail-wr1-x429.google.com with SMTP id s5so8111820wru.1 for ; Tue, 22 Nov 2022 07:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=d/NHBKGDOX3nKvbZw/BiBdsAsPSLYwVPAHS5TiK63CM=; b=ie2jswgIwR9SmIN1vGi//3Zu9Op8Fduc/pixh0vB7fqO395uB5OvTZSwTmbHqcPAAV dfM9yElk33C0Tg76UvrsDhK4dbDSQ49JE10JA50R+XQ/pW1Rooi64kipCtvLL4E8L+uo 343Ixh5wKBXPOXVnWTCBRFEUJ8Sy0FwocfGV09OQcFevBFYoAGmEmHnunq60mkGugSrR JQ62nyLXJpSwtZZgrO4aaUMntXkY2PorAYuEUkxNW4KFFMhTGTi0QmyrIcqKfZMFLFt4 17/YQzdD6ueiQ2oy/BQPmt7UaDbqC5t9n380r7VNUxwPIo6CxF3/3NYp9q+3y9YPoukh Iteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=d/NHBKGDOX3nKvbZw/BiBdsAsPSLYwVPAHS5TiK63CM=; b=DXSaeoRZEKdCcBF/MoH8P5ae7TXF83gp6t8vw3jbxDziQ3KuYVcgtWOlnF3aluyI8r It+9hbedzTIdZso+cEXMdI2Vjcb55st7XMatgUebmcXxxc9EOCSzV4rF4pJDr7kBOkrh 6YCZUVkC1Mp024xFNZN1KlhZq3wAidOsLiGiNsl9oON5UdPDDGsMBhnaA5vTWYCDE4yO Q8V2TB+5DIhN6U0ynwCJYpaInPNnQBhZ8Gt5azjcvPYXjFWD/KwsKaGc19N5K0KfiK6u CTWDa7vF+edagulI0ZuWmomKFA/N5SBIzJegjqt0+8dF3kjKDDuYqGfV6flDm5+MQlWZ Jgzw== X-Gm-Message-State: ANoB5plOkl+R2L88bYUE11jlKFDjqcS5NVRbsiV4J2HUK/fFc/MvPAZH pZS2c3gP813l5c+OmKA7RH8Y5cGYsss= X-Google-Smtp-Source: AA0mqf5UKzjJSxzo/OQZeLhIQJax0BmuDL50W3TP17DCLMRPWRrHn85SyNwLGQ2U3tT4Npwk0ECBrQ== X-Received: by 2002:a5d:6a08:0:b0:241:da26:bddf with SMTP id m8-20020a5d6a08000000b00241da26bddfmr5542303wru.591.1669131644818; Tue, 22 Nov 2022 07:40:44 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id az14-20020a05600c600e00b003cf78aafdd7sm4797876wmb.39.2022.11.22.07.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 07:40:44 -0800 (PST) From: zimoun To: Maxim Cournoyer , guix-devel Subject: Re: RFC: libgit2 is slow/inefficient; switch to git command? In-Reply-To: <87cz9fpw4x.fsf@gmail.com> References: <87cz9fpw4x.fsf@gmail.com> Date: Tue, 22 Nov 2022 16:39:38 +0100 Message-ID: <86leo3c81x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669131671; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=d/NHBKGDOX3nKvbZw/BiBdsAsPSLYwVPAHS5TiK63CM=; b=u/IsqfXoBTEj91NRPkvNALpFCO0qTN1K8h9pHhfT+KzZaE7fvV7GqHoHyAAWViNFlRDxge y1kT+RypAagIDg9PQKIW8qprGnSye+1hG901ya1Q0g8KQMTCucpOCPIBBFsIi7oL8FjiGJ z7XWmm9lw/BYVDE7JJ0XkasGdDhZsxEsBSZFpt159JiMjje7sfWyDNEUg+WXa6DJ6FF/UH 8EmYZ7UxFfIPTFHESc+hRzZ+W+orEQEKzq89iNgHPM7Ikgnp9W9aV3zmQg0Ajexpj3QeBU MoJjlC2REGH3Z8vpnuqNBzrJN2nqLaJMTOhRU6wviwyEj8TTwmplGnzBtUkqGw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669131671; a=rsa-sha256; cv=none; b=FYEa91q+I0oZRKchJEQFnxX/CHX3g9lKshvh+XAd9UCrNkESx7k31VtbuyLvKVXulPsbKq lReXKrAhCmviQ219IXPr8/+vT0Gq8dBffCkF1+RAG7oy7/CCl4/v3oREY/CGiKMMhJOEAd spia08I4Q/IRY2R9+1VJ4NAXN+5WKyyUMUSCdsi8YYJbVHh9usvTZmHaGNATMVZt8LzUAd zG383wD3A6LdcpAxs+vJSkfU3pTvJXY6zpuKwmDGR57KA4kQbf5u2L1MAiPw/wxNGvcv6i 9bJvO08KwX+49zdCf6KbbXYLhQNF0K287lCW8BHtDT9czb7ZM43WkkQTzFEjag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ie2jswgI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.00 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ie2jswgI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0665E2BACE X-Spam-Score: -3.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7SPcmHj/ilMO Hi, On Mon, 21 Nov 2022 at 21:21, Maxim Cournoyer w= rote: > Given that: > > * the git CLI doesn't suffer from such poor performance; > * This kind of performance problem has been known for years in libgit2 > [0] with no fix in sight; > * other projects such as Cargo support using the git CLI and that > projects are using it for that reason [1]; And I would add the lack of =C2=ABSupport for shallow repositories=C2=BB [1= ]. 1: > Would it make sense to switch to use the git command directly instead of > calling into this libgit2 C library that ends up being slower? It would > provide a hefty speed-up when using 'guix refresh' or building new > packages fetched from git without substitutes, or using 'git-checkout', > etc. Well, the question is about the closure and the bootstrap. For instance, --8<---------------cut here---------------start------------->8--- $ guix size guix | grep 'total:' total: 629.5 MiB $ guix size guix git-minimal | grep 'total:' total: 671.0 MiB --8<---------------cut here---------------end--------------->8--- which is not nothing but not so worse neither. However, it would require a fine scrutinizing about what would be added as dependencies. The proposal is to fully drop =E2=80=99guile-git=E2=80=99 and instead run = =E2=80=99(invoke "git" )=E2=80=99 as in the module =E2=80=99(guix build git)=E2=80=99, righ= t? Cheers, simon PS: For the record, Software Heritage, which ingests *a lot* of Git repositories, relies on Dulwhich [2] (pure Python implementation), IIUC. 2: