From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OB2TCEcqQGHWOwAAgWs5BA (envelope-from ) for ; Tue, 14 Sep 2021 06:51:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mEZjBEcqQGFzQQAA1q6Kng (envelope-from ) for ; Tue, 14 Sep 2021 04:51:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C430BCA6A for ; Tue, 14 Sep 2021 06:51:17 +0200 (CEST) Received: from localhost ([::1]:47046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ0Pb-0000EA-Q2 for larch@yhetil.org; Tue, 14 Sep 2021 00:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ0PP-0000Dk-Ir for bug-guix@gnu.org; Tue, 14 Sep 2021 00:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ0PO-0003cy-7H for bug-guix@gnu.org; Tue, 14 Sep 2021 00:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ0PO-00048I-2A for bug-guix@gnu.org; Tue, 14 Sep 2021 00:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#33609: fortune-mod build (test) failure Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Sep 2021 04:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33609 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pierre Neidhardt Received: via spool by 33609-submit@debbugs.gnu.org id=B33609.163159503615853 (code B ref 33609); Tue, 14 Sep 2021 04:51:01 +0000 Received: (at 33609) by debbugs.gnu.org; 14 Sep 2021 04:50:36 +0000 Received: from localhost ([127.0.0.1]:47224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ0Oy-00047d-Jo for submit@debbugs.gnu.org; Tue, 14 Sep 2021 00:50:36 -0400 Received: from out0.migadu.com ([94.23.1.103]:22394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ0Ov-00047T-UJ for 33609@debbugs.gnu.org; Tue, 14 Sep 2021 00:50:35 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631595032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iJc/a93ql7HpF+GtRBNpbvt1DR+po9UKjGlKR3M8blQ=; b=hyojCc03VIeedRog53MWkfUIiRsaciYCtSmlF1kcA52ODr9b43jS53HCbmJzqaVT/Grwr7 5/54jwXMIa+KNtqLfLny8FC3DqVbGFZ4XdbXrLISfUHxe9h21YjoSyYgb72ZK+hyzYMXIU v40CBEQzcnMqQ5fl9mPGgXtX+XbydmE= From: Sarah Morgensen References: <20181204111033.0aa0d4c6@scratchpost.org> <87womxk6h5.fsf@ambrevar.xyz> Date: Mon, 13 Sep 2021 21:50:30 -0700 In-Reply-To: <87womxk6h5.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Mon, 21 Jan 2019 23:09:58 +0100 (2 years, 33 weeks, 4 days ago)") Message-ID: <86k0jjiwvd.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 33609@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631595078; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=iJc/a93ql7HpF+GtRBNpbvt1DR+po9UKjGlKR3M8blQ=; b=gLbs4pcXYQhnK/EIA1ntCUyCPDJPGa4L4bobJgxNuki/yrPqdxwPa9RKnsbHc2xHHihFId QzlWBueBp7TyXlUffosxXeoWAsba7K79f8dCTfH869NJTBCKRRc9pDY28LjDS8w9e2zCYI yV7Cdv+3Gk3pmX4mQhXGMJHUWVBk3VElbRRDD5ef5BdktyY5FLzUrAUcDaz9dWrxLfspK4 UegZCyMt6dUnaqVa+aZ1qT0Cr31v9BCADccjxCVoBXkXIyqaj1O6sR06wutFTaRX9KbS3Y 772WH4YNn9HIauq4EWsCigDALOGSEIWdELKuZM6Dj1HlEFEa/V8QBLCAjJyjfA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631595078; a=rsa-sha256; cv=none; b=hXh8Pg4v4FATk6BhMrMxmezwOGm33YcthX30jZLgDlg8IYXJ7Jm+3XjrSbjTRFr89kzfDm H67AMfRYbqCaCTybnIAYnYvLkVxPUluACCvfbQ3mrle/YOVnBewf7sDbbWLriOOyjyBkCX cgMifDMM0y7af/rwrxtMkCVTQGdYRxTmr5cSQaciabi2uRGLyCjM3csFJn/b44pTuFtNE6 2PblPUPtAS5iw/ECI3g3E4R8/zX0tZgPZiT1Vp0+DVZoDujXxX3anwQ+ivtp2p84Km/D68 KaEa+gjX5vXAelsurmD0Q6WgXTAznPl7QVj9BCLQxyXurzWlUfqcmK/Dos9CbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hyojCc03; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 0.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hyojCc03; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: C430BCA6A X-Spam-Score: 0.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: cED1wxEgAthS --=-=-= Content-Type: text/plain Hi, Pierre Neidhardt writes: > I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the > valgrind test. This is not ideal but better than having a broken > package. > > Upstream has https://github.com/shlomif/fortune-mod/issues/21 which > could be related. This seems to be fixed now. I've attached a patch below to reenable it. It could probably do with an update, too. It now vendors 'rinutils' (which we already have as an input) so that would need to be removed. -- Sarah --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-fortune-mod-Re-enable-test.patch Content-Description: gnu: fortune-mod: Re-enable test. >From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001 Message-Id: <5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskarian@mgsn.dev> From: Sarah Morgensen Date: Mon, 13 Sep 2021 21:40:43 -0700 Subject: [PATCH] gnu: fortune-mod: Re-enable test. Re-enable the valgrind test, fixed in a previous version update. * gnu/packages/games.scm (fortune-mod)[arguments]<#:phases> {fix-build-env}: Re-enable test. --- gnu/packages/games.scm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index a2f756e3a7..4236560143 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -7633,11 +7633,7 @@ original.") (copy-file cmake-rules (string-append "fortune-mod/cmake/" (strip-store-file-name cmake-rules))) - (chdir "fortune-mod") - ;; TODO: Valgrind tests fail for some reason. - ;; Similar issue: https://github.com/shlomif/fortune-mod/issues/21 (?) - (delete-file "tests/t/valgrind.t") - #t))) + (chdir "fortune-mod")))) (add-after 'install 'fix-install-directory (lambda* (#:key outputs #:allow-other-keys) ;; Move binary from "games/" to "bin/" and remove the latter. This base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1 -- 2.33.0 --=-=-=--