all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sarah Morgensen <iskarian@mgsn.dev>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 33609@debbugs.gnu.org
Subject: bug#33609: fortune-mod build (test) failure
Date: Mon, 13 Sep 2021 21:50:30 -0700	[thread overview]
Message-ID: <86k0jjiwvd.fsf@mgsn.dev> (raw)
In-Reply-To: <87womxk6h5.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Mon, 21 Jan 2019 23:09:58 +0100 (2 years, 33 weeks, 4 days ago)")

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi,

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
> valgrind test.  This is not ideal but better than having a broken
> package.
>
> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
> could be related.

This seems to be fixed now.  I've attached a patch below to reenable it.

It could probably do with an update, too.  It now vendors 'rinutils'
(which we already have as an input) so that would need to be removed.

--
Sarah


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnu: fortune-mod: Re-enable test. --]
[-- Type: text/x-patch, Size: 1469 bytes --]

From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001
Message-Id: <5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskarian@mgsn.dev>
From: Sarah Morgensen <iskarian@mgsn.dev>
Date: Mon, 13 Sep 2021 21:40:43 -0700
Subject: [PATCH] gnu: fortune-mod: Re-enable test.

Re-enable the valgrind test, fixed in a previous version update.

* gnu/packages/games.scm (fortune-mod)[arguments]<#:phases>
{fix-build-env}: Re-enable test.
---
 gnu/packages/games.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a2f756e3a7..4236560143 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7633,11 +7633,7 @@ original.")
                (copy-file cmake-rules
                           (string-append "fortune-mod/cmake/"
                                          (strip-store-file-name cmake-rules)))
-               (chdir "fortune-mod")
-               ;; TODO: Valgrind tests fail for some reason.
-               ;; Similar issue: https://github.com/shlomif/fortune-mod/issues/21 (?)
-               (delete-file "tests/t/valgrind.t")
-               #t)))
+               (chdir "fortune-mod"))))
          (add-after 'install 'fix-install-directory
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Move binary from "games/" to "bin/" and remove the latter.  This

base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1
-- 
2.33.0


  reply	other threads:[~2021-09-14  4:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 10:10 bug#33609: fortune-mod build (test) failure Danny Milosavljevic
2018-12-04 21:34 ` Leo Famulari
2019-01-21 22:09 ` Pierre Neidhardt
2021-09-14  4:50   ` Sarah Morgensen [this message]
2022-07-13 15:06     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k0jjiwvd.fsf@mgsn.dev \
    --to=iskarian@mgsn.dev \
    --cc=33609@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.