From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp1 ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms0.migadu.com with LMTPS
	id 8NW1ATq6imE/XQEAgWs5BA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 09 Nov 2021 19:13:14 +0100
Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp1 with LMTPS
	id 8GrfODm6imFSKQAAbx9fmQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 09 Nov 2021 18:13:13 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id C530C1174F
	for <larch@yhetil.org>; Tue,  9 Nov 2021 19:13:13 +0100 (CET)
Received: from localhost ([::1]:46250 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1mkVcO-00064T-Vj
	for larch@yhetil.org; Tue, 09 Nov 2021 13:13:13 -0500
Received: from eggs.gnu.org ([209.51.188.92]:49698)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mkVcE-00062K-UQ
 for guix-patches@gnu.org; Tue, 09 Nov 2021 13:13:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:52415)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mkVcE-0004EH-4s
 for guix-patches@gnu.org; Tue, 09 Nov 2021 13:13:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mkVcD-0008HU-Sr
 for guix-patches@gnu.org; Tue, 09 Nov 2021 13:13:01 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when
 deleting specific items.
Resent-From: zimoun <zimon.toutoune@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Tue, 09 Nov 2021 18:13:01 +0000
Resent-Message-ID: <handler.51427.B51427.163648152731758@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>,
 Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 51427@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.163648152731758
 (code B ref 51427); Tue, 09 Nov 2021 18:13:01 +0000
Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 18:12:07 +0000
Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mkVbK-0008G9-Iw
 for submit@debbugs.gnu.org; Tue, 09 Nov 2021 13:12:07 -0500
Received: from mail-wr1-f52.google.com ([209.85.221.52]:35512)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@gmail.com>) id 1mkVbG-0008FZ-75
 for 51427@debbugs.gnu.org; Tue, 09 Nov 2021 13:12:06 -0500
Received: by mail-wr1-f52.google.com with SMTP id i5so34550724wrb.2
 for <51427@debbugs.gnu.org>; Tue, 09 Nov 2021 10:12:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; 
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-transfer-encoding;
 bh=igOMW7/LxyPhnthkg1r8UsoLFc+ken1DuL708ye5DIw=;
 b=jS7YeWdd3Db2zgA8BmAhUD0Zw3ctHI6cP9wv0ovyJOkd6lvOidwK4GLhGAAaJhw3hx
 kQnlTDPp5RKYp4FsxgpKyo8zmdHRh407rrueptMUkVQx6x9Q5Bv00npUBJT9gW7cxzdn
 BFpMHuufsZ9z/13oNzaj3gpLZ1B+WRaEPsw5ktTeNn1Ip9E1z20nvwntoPjygXwuk48z
 R25H3jENatCNWls+jvoS2U97WxQAYq0gJLJ7bIJlvRjvwKWB1g+x0gwHQMlfltCpLI1T
 Go0ZGTKhfltfUeHnEpMn9GqlHGwg+kExHYLuwUHxk4egiSXepPuHd45gBBaD1KnArfLZ
 Lrtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=igOMW7/LxyPhnthkg1r8UsoLFc+ken1DuL708ye5DIw=;
 b=tHikYwKclcOBbDSXvBqqsf5m1UK2H0Qe4JO0TVmL8XRgCqWTmk5rt/rFu4kd/DIonJ
 3Kiqg/hWFvEwxuHnvKJvfdw1kJRQwPDZzkaLSNPY+/Q1XEpGHxoOI3jQxUwAR+YHde+H
 UPS1EASWYxJV+ArtXEx7N3y9GcHpPJhZfCoL+vl9NOI8A9U+07nqI19s1xKT2eTCG6GU
 5QvHTcjqfng//rd0zcEOdrWiyS+VbRN0Tsh75OP3XiMXkxpH97HtEySbz7rqt77ifaLy
 2lRevbZxwv5FVmdjc/Kj+Ev0q5OuLuYrpGvnyrVc1j5jNhhtvdj6QD4A2ylF20Y3SV3i
 yWrQ==
X-Gm-Message-State: AOAM531BrIFRdKrk0ojLevlEXIYDZbIx/CS7ZeTafD2FP93SAYbK9Z3r
 uCpcA17ojZ1JeGK5UuLUvJ8=
X-Google-Smtp-Source: ABdhPJxsmFCrtbPIXzyVmwB9rmi3X6IgTGcvuzywpZ6ve1RcC+g4nhK77YuGKHJSLPRFzzFUAIrS7g==
X-Received: by 2002:adf:fd4c:: with SMTP id h12mr11569851wrs.429.1636481516268; 
 Tue, 09 Nov 2021 10:11:56 -0800 (PST)
Received: from lili (214.13.23.93.rev.sfr.net. [93.23.13.214])
 by smtp.gmail.com with ESMTPSA id f7sm1463301wmg.6.2021.11.09.10.11.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 09 Nov 2021 10:11:55 -0800 (PST)
From: zimoun <zimon.toutoune@gmail.com>
In-Reply-To: <87ee7tmdbd.fsf@gnu.org>
References: <20211027034918.4591-1-maxim.cournoyer@gmail.com>
 <87o8795j61.fsf@gnu.org>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com>
 <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com>
 <87ee7tmdbd.fsf@gnu.org>
Date: Tue, 09 Nov 2021 19:10:27 +0100
Message-ID: <86k0hhnqss.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1636481593;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=igOMW7/LxyPhnthkg1r8UsoLFc+ken1DuL708ye5DIw=;
	b=uPJDNX07U6k1IGVkHQR3vN0XMJika1CY9YiOjfYKDJDWPJ8r/mIV0DxJ2gwz2wFxLtJ62D
	fCnkGfY2YF0bzrNqI9XJzwoELtD5kHJnFOATD308jvfhUCWktPpM6Y+SRAOilP+zRbwJhl
	IcZpUWI1XwEHBCcLjKMsG20eNZp0KEUeDjQajkm3yVF+lOils9mb6q3ZRM7Zc07ILRtEjY
	u1Q+LApQt/2oaQnfXke4ay31RZCZ+LelYYY8/l50VL8aun4TYwE9uP6ktbijwqzNCFEJqy
	UarkCNqQKuR4vvn04Fk81KWL09UqhCJlX8kx6ZsSRavuqj3tc3Q0N2lYNJK3rA==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636481593; a=rsa-sha256; cv=none;
	b=KiLyA7C6dzbMnia0uT7bfUYgCipiB2Qcg3ce6ObYKdYn4q8m5wy/vUoa6AJOcN5Wqt3xK8
	sy+iG63WbrAcppIOoOdgpmgWrlemUFRCLMhbEyvDjhmY0QdqjiiTW55ebVJ40W0OcWB2Sp
	mFa1CpbGOff2hRDoap2AaOqsFr0vjBLQ2j+oD4OZO1qwALJQJKtP4Kpsh0h8JaWlU/Ucfn
	dqqAV+j2S7XhIz8omMuzAre95swox2GavOjDAE469ouxzegiU6OcORsVjsyi+IJv45l+hJ
	neLOI+8lBYnqicU3qd9iRoZt7+ER/3rKfO/1msNBQXHcGB6r8vVnqKRwFbHHjg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jS7YeWdd;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org
X-Migadu-Spam-Score: 0.18
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jS7YeWdd;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org
X-Migadu-Queue-Id: C530C1174F
X-Spam-Score: 0.18
X-Migadu-Scanner: scn0.migadu.com
X-TUID: nffq92Cp7Z3k

Hi Ludo,

On Sat, 06 Nov 2021 at 17:57, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:

> The ideal solution as zimoun writes would be to address
> <https://issues.guix.gnu.org/24937>.

Cool for your last reply with a plan for mitigating the issue.

Even if the phase is drastically speed up, it would be probably still
too slow when using the option =E2=80=99-D=E2=80=99 remove only one <item>;=
 or just
some.

I have not checked the code, maybe I should start by that. ;-) Is it not
possible to simply skip the deleting phase when the option =E2=80=99-D=E2=
=80=99 is used?


Cheers,
simon