all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Vagrant Cascadian <vagrant@debian.org>,
	Christopher Baines <mail@cbaines.net>,
	guix-devel@gnu.org
Subject: Re: Thoughts on committers pushing simple changes from other committers?
Date: Tue, 21 Feb 2023 22:20:12 +0100	[thread overview]
Message-ID: <86k00avhpv.fsf@gmail.com> (raw)
In-Reply-To: <87v8juq29l.fsf@yucca>

Hi,

On Tue, 21 Feb 2023 at 10:52, Vagrant Cascadian <vagrant@debian.org> wrote:

> There is also no sign like "this has been reviewed by N people" better
> than one person authoring it and another person pushing and signing it,
> with some Reviewed-by or other relevent tags in the commit.

I agree that Reviewed-by would be helpful.

Once reviewed, the author or the reviewer could roll the count and
re-send the patch (or series), applying the line Reviewed-by.

It would reward the reviewer for their work.  And it would help the
committer work.

Cheers,
simon


  reply	other threads:[~2023-02-22 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 12:54 Thoughts on committers pushing simple changes from other committers? Christopher Baines
2023-02-21 14:57 ` Andreas Enge
2023-02-21 18:00   ` Leo Famulari
2023-02-22  9:35     ` Andreas Enge
2023-02-21 17:58 ` Leo Famulari
2023-02-21 18:52 ` Vagrant Cascadian
2023-02-21 21:20   ` Simon Tournier [this message]
2023-02-25 18:06     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k00avhpv.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.