all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Elsing <david.elsing@posteo.net>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: 65155@debbugs.gnu.org, i@dan.games
Subject: [bug#65155] [PATCH] gnu: mesa: Add native-search-paths.
Date: Sun, 11 Feb 2024 17:36:52 +0000	[thread overview]
Message-ID: <86jznanbrf.fsf@posteo.net> (raw)
In-Reply-To: <87msuy8lte.fsf@protonmail.com> (message from John Kehayias on Tue, 28 Nov 2023 05:54:25 +0000)

Hello,

John Kehayias <john.kehayias@protonmail.com> writes:

> So perhaps this belongs in vulkan-loader? Although I admit I'm less sure
> for XDG_* related paths. Is there a test case or something we can see if
> this does what is intended for vulkan?

I also noticed the same problem and agree that the search path belongs
in the vulkan-loader package:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index 285d6be7f5..98ce979652 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -303,6 +303,11 @@ (define-public vulkan-loader
            wayland))
     (inputs
      (list vulkan-headers libxrandr))
+    (native-search-paths
+     (list
+      (search-path-specification
+       (variable "XDG_DATA_DIRS")
+       (files '("share")))))
     (home-page
      "https://github.com/KhronosGroup/Vulkan-Loader")
     (synopsis "Khronos official ICD loader and validation layers for Vulkan")
--8<---------------cut here---------------end--------------->8---

I tested it with
--8<---------------cut here---------------start------------->8---
guix shell -C vulkan-tools vulkan-loader mesa --no-grafts -- vulkaninfo
--8<---------------cut here---------------end--------------->8---
which works with the patch applied. As documented in [1], vulkan-loader
still needs to be part of the profile for the search path to take effect.

Cheers,
David

[1] https://guix.gnu.org/manual/en/html_node/Search-Paths.html




  reply	other threads:[~2024-02-11 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:08 [bug#65155] [PATCH] gnu: mesa: Add native-search-paths dan
2023-11-28  5:54 ` John Kehayias via Guix-patches via
2024-02-11 17:36   ` David Elsing [this message]
2024-03-06  5:55     ` John Kehayias via Guix-patches via
2024-03-06  6:59       ` dan
2024-03-25  1:05         ` John Kehayias via Guix-patches via
2024-04-18  4:46           ` bug#65155: " John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jznanbrf.fsf@posteo.net \
    --to=david.elsing@posteo.net \
    --cc=65155@debbugs.gnu.org \
    --cc=i@dan.games \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.