From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mE1FL3yQTmF0FQAAgWs5BA (envelope-from ) for ; Sat, 25 Sep 2021 04:59:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GBveKnyQTmFFOAAAbx9fmQ (envelope-from ) for ; Sat, 25 Sep 2021 02:59:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E171F18599 for ; Sat, 25 Sep 2021 04:59:07 +0200 (CEST) Received: from localhost ([::1]:52482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTxu7-00051r-3Z for larch@yhetil.org; Fri, 24 Sep 2021 22:59:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTxu2-00051g-75 for guix-patches@gnu.org; Fri, 24 Sep 2021 22:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTxu1-0006Em-Vh for guix-patches@gnu.org; Fri, 24 Sep 2021 22:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTxu1-0002yo-VG for guix-patches@gnu.org; Fri, 24 Sep 2021 22:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50793] [PATCH 2/2] gnu: Add cloudflare-cli Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Sep 2021 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50793 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stephen Paul Weber Cc: 50793@debbugs.gnu.org Received: via spool by 50793-submit@debbugs.gnu.org id=B50793.163253873811436 (code B ref 50793); Sat, 25 Sep 2021 02:59:01 +0000 Received: (at 50793) by debbugs.gnu.org; 25 Sep 2021 02:58:58 +0000 Received: from localhost ([127.0.0.1]:59955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxtx-0002yN-KU for submit@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:57 -0400 Received: from out1.migadu.com ([91.121.223.63]:41440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxtw-0002yE-73 for 50793@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:57 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632538735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bylx/aJnf3IcRZKm3OOW6wviIy+ifWg/44zgcGvG11c=; b=VjQ+A4PrJczBjptdYfISucXP7jvazZGgSwNQS48qB63JsMo+O3W6DUtJUnd4mRhW+Pims4 w3ztz35y0lz0zTke8Cz9O1lVKkQuJdlcuXy+m7ERHdhrJXK0hrURaE98v01I0ZuMefLqTs jNHAOTXs3HFXNiStNu4iZ3BPy3qf6Rk= From: Sarah Morgensen References: <20210925013934.2763-1-singpolyma@singpolyma.net> <20210925013934.2763-2-singpolyma@singpolyma.net> Date: Fri, 24 Sep 2021 19:58:54 -0700 In-Reply-To: <20210925013934.2763-2-singpolyma@singpolyma.net> (Stephen Paul Weber's message of "Fri, 24 Sep 2021 20:39:34 -0500 (1 hour, 5 minutes, 51 seconds ago)") Message-ID: <86ilypwec1.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632538748; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Bylx/aJnf3IcRZKm3OOW6wviIy+ifWg/44zgcGvG11c=; b=ldM7uczOvn8ZaRgWeNmMBoAcLaMRwECZQj0TxIOXc8FJuR3l64weFRRth4yrqtM//i9c/0 hJXIEb/kK/Jk7VaS+lNWUZ826BFbuppXdvbmxfvr2ZV257gf1UfR3+R3qQYjPkfBsO49a/ jHJY3Vex8vg87k/Txz4qWzDQXknOPchmz1Z8z+62D/U8JdDR+HKLNdUtl4tK844RU4q9g+ hhON761aSDVFOYjV07BnJ6ED0/nhzLQe8FIb3cK5p4RAgYDdBmT8OzDutRYzLbdDS8sC12 yKu0y2d23IYR7Bdd+kjRQKmq3kpdsbH+aBoMbaySsszS4alr7FO9RaamZx6Fww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632538748; a=rsa-sha256; cv=none; b=F9LsG4ja0WUbAxBGarLgh661CYMSp6oDdtMK5SGbG2hveoJohDJWGmKAU/3ez8kfCUwX/M a2fao9B5YIViQ53/30sg38zpCuIQ6pTiI9NLqzXeDUf/3gF8lnWPU5gmCRXtBOHySVtx6X BXstKeYpTrWg0cbhotAouLEftgP4bikLqUCg8maV2D5HfUME0NqC3G8PBWlemQEI+3goau d8m5kVfcwn8xkeWvAMd+sc1IRa/imX3lUcSw8I0uFw2ZfIlWJHEfeoOlAg1WzH5Z5/yhFR 00iMaoZyiE9S7Dul6JnXHVykaqquWI5nlRSuzXGHBtCg+7xeA3TJuf/FAKV2LQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=VjQ+A4Pr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=VjQ+A4Pr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E171F18599 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: JmBi9T204mA1 Hi, I've (naturally) got a few suggestions for this one, too. Stephen Paul Weber writes: > * gnu/packages/dns.scm (cloudflare-cli): New variable. > --- > gnu/packages/dns.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm > index 45e250138e..9e68d76a93 100644 > --- a/gnu/packages/dns.scm > +++ b/gnu/packages/dns.scm > @@ -42,6 +42,7 @@ > #:use-module (gnu packages bash) > #:use-module (gnu packages certs) > #:use-module (gnu packages check) > + #:use-module (gnu packages curl) > #:use-module (gnu packages databases) > #:use-module (gnu packages documentation) > #:use-module (gnu packages compression) > @@ -69,6 +70,7 @@ > #:use-module (gnu packages python) > #:use-module (gnu packages python-xyz) > #:use-module (gnu packages ragel) > + #:use-module (gnu packages serialization) > #:use-module (gnu packages shells) > #:use-module (gnu packages sphinx) > #:use-module (gnu packages swig) > @@ -82,11 +84,61 @@ > #:use-module (guix download) > #:use-module (guix git-download) > #:use-module (guix utils) > + #:use-module (guix build-system copy) > #:use-module (guix build-system glib-or-gtk) > #:use-module (guix build-system gnu) > #:use-module (guix build-system meson) > #:use-module (guix build-system trivial)) > > +(define-public cloudflare-cli > + (package > + (name "cloudflare-cli") > + (version "2d986d3") Please use the 'git-version' pattern as I mentioned in the other patch. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/earlchew/cloudflare-cli") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0f86g6n86kwykl3jnhqjrdfy8ybkp03ghr3dlr70q2552qw4axw2")))) > + (build-system copy-build-system) > + (arguments > + `(#:install-plan '(("cloudflare-cli" "bin/") ("cloudflare-cli.sh" "bin/")) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'find-jsonsh > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "cloudflare-cli.sh" > + (("\\$\\{0%/\\*\\}/jsonsh") > + (string-append (assoc-ref inputs "JSON.sh") "/bin/JSON.sh"))) > + #t)) > + (add-after 'install 'wrap-program > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (wrap-program (string-append (assoc-ref outputs "out") "/bin/cloudflare-cli") > + `("PATH" ":" prefix > + (,(string-join > + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) > + '("grep" "curl" "coreutils")) I don't think this uses anything from coreutils either, but I just took a quick look. > + ":"))))))))) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("coreutils" ,coreutils) > + ("curl" ,curl) > + ("grep" ,grep) > + ("JSON.sh" ,JSON.sh))) > + (synopsis > + "CLI to edit Cloudflare DNS records") > + (description > + "This command line tool to update Cloudfare DNS records is useful in the > +following scenarios: > +* Keeping dynamic DNS records up to date > +* Updating DNS records as part of the ACME DNS-01 protocol") Could you update this description to use sentences rather than bullets (and, preferably, use active rather than passive verbiage)? (If you do ever need to write a list in the description, you can use @itemize (info "(texinfo) Lists and Tables"); see other packages for examples.) > + (home-page "https://github.com/earlchew/cloudflare-cli") > + (license license:expat))) > + > (define-public ldns > (package > (name "ldns") Thank you! -- Sarah