From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yJkxMA6IN2X1SAAAG6o9tA:P1 (envelope-from ) for ; Tue, 24 Oct 2023 11:02:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yJkxMA6IN2X1SAAAG6o9tA (envelope-from ) for ; Tue, 24 Oct 2023 11:02:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D6E36AA0D for ; Tue, 24 Oct 2023 11:02:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OwxLNcwQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698138126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=li8ggQWWKb4FHRHSGVZdvNVc09pVZtJne+HMPfTltmk=; b=k2yHgntTuMvtwgnLp/Fcr+zgtJ9iHxKBEwgi70JRiOt1YByID+qEMKiWMxWPNVdp4UBD8j BREeLxczSyQtfUEBK9sNXLIc2uVJnjZxeqMT8sWOyDxJvYOtYaJW7f7z74Vy4ricetzCQp 8lM6LXu06Ss6itQ5T+SF0jv2/qrCZbm4lF+QdAljfaTFxaOAd5k3iS9Byg3lOsaJ6hLIZn VMyKYzV8Y3vQYoOWVKD4KIItyMd5Q2E6/fkUCO6Gk4dtpUzNhrsFrXzylMV8IKPU9D5nMW ZkpdVqO84CJ3ciWHbx0eN+oT+SAvoW0vvo8qNo2wZp+P7T03zxfTY6szR3xCNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698138126; a=rsa-sha256; cv=none; b=Km9fF0pQUleOqSRpcSLQxSXdE6xUF/57ZkgnIQlDw9bjOBBd6MKa34IV4ruRNATozLiPrP kqNwZYFlr3Tz5SpenzV+acw9wDI+ehLkWTDgey227fjIe9Y51ALFNuRXGsJtzWcmdiKpzX xCBWTdUXcIdRb270ijUJjeku1DYZDQ5fIz4jniPwYFGT5dTlQ0QfBIRZNRK3EptrMCtxl4 m9zmEOgcTWpUFVGXCTYGYv6zCYLps7Diw4vR5W5ot4DH2lTDJhkUXaO22KyuqLzLDncfSb pPrY/BZRi1iF4RgClZbcZ1W0a8XqrP5w1xxjfCihZowbGKf03yfnHzHy/MVKIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OwxLNcwQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvDI9-0007XZ-8y; Tue, 24 Oct 2023 05:01:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvDI6-0007Up-Oc for guix-patches@gnu.org; Tue, 24 Oct 2023 05:01:34 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvDI6-000050-7W for guix-patches@gnu.org; Tue, 24 Oct 2023 05:01:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvDIZ-00073R-LP for guix-patches@gnu.org; Tue, 24 Oct 2023 05:02:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Oct 2023 09:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169813810927062 (code B ref 66436); Tue, 24 Oct 2023 09:02:03 +0000 Received: (at 66436) by debbugs.gnu.org; 24 Oct 2023 09:01:49 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIK-00072O-No for submit@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:49 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDI8-000714-SR for 66436@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:38 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c51774da07so14866761fa.1 for <66436@debbugs.gnu.org>; Tue, 24 Oct 2023 02:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698138061; x=1698742861; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=li8ggQWWKb4FHRHSGVZdvNVc09pVZtJne+HMPfTltmk=; b=OwxLNcwQDQMIgvvScAKXahlv5XNx2Jy4ZW1KLiKmkb0Uwsn1RNj01QSTxnA9VFIbBM p3Kp19N9cPULR91fRH74Wl4ioQ9uWq2oKa60mZPkx68+Oa8MZKVP07ws7bU+yz5wyyo0 oyR/OOK12pN9NO33gyldX59RR3vItVH9lBpkq+goLVT5+021vAWsJade3eYrDq6T9zNO m3rC4ZTmcrVwdjscNASumPlEm0+duRh5/U1HcdabmnyKsFSt/i8rInXqJzToZK004lll R/oHqRyWdCtGf5UujKj0jhViBEwEHf8qzb40qkxILL314imgEw2V9iX6fnViBDISCkrD UMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698138061; x=1698742861; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=li8ggQWWKb4FHRHSGVZdvNVc09pVZtJne+HMPfTltmk=; b=X11JeeqLki2GOdLB46nJxP2jbM5FI9LZVqUDj8ZEtAfu4FTxznOwVRZ78XmZJsB6Jt /QbeVNxpb1L0g3ZWLYt8Sfrq4GJYybBMQhwzkQpSzBqlyLyxYeT3Ym8H7APpqdFdWnmB 5Ee0L4e3uk8fufCUuZngpipz3OKWzbkHlcqvC7jQR15FJi/xoI0dGq2l+RSncswYBlDi 2yUfiPGxxROYZoN72E+LhwpcUcepZlpjLzorvOnRP8kskLDtHtCRRHWLqvFSMGQ9GF66 CEuRI5aodJPymfPWc2YebWQd+xxiJrnYCtspUW67vyDYb1oSlGd1ELBG9E6ScNCFxmaO 2XKg== X-Gm-Message-State: AOJu0YzTVcoOp+nxs3kN6wlq3X/wAXP1KzT4dyfDjGG6bBV7qcC5ch9w SZi6KSVdEN6abRSdAt24w80= X-Google-Smtp-Source: AGHT+IHs560xRcJAkl8Iq/9xSMdISQvT4ezksAs+bA50ocOQcrHqe5OkknVs1APJN5WrVAjudxtcHQ== X-Received: by 2002:a2e:a0d4:0:b0:2c5:409:7005 with SMTP id f20-20020a2ea0d4000000b002c504097005mr7595698ljm.4.1698138061102; Tue, 24 Oct 2023 02:01:01 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c320900b0040644e699a0sm16133994wmp.45.2023.10.24.02.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:01:00 -0700 (PDT) From: Simon Tournier In-Reply-To: <87r0logap6.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> Date: Tue, 24 Oct 2023 10:49:35 +0200 Message-ID: <86il6wv200.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 4.59 X-Migadu-Queue-Id: 9D6E36AA0D X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 4.59 X-TUID: dwq76i1g23Yr Hi, On Fri, 20 Oct 2023 at 19:01, Maxim Cournoyer w= rote: >> 3. Should the reviewer run the program being packaged? The above >> guidelines speak about applying, reading, building and linting but >> not running. (Making sure it works as expected.) > --8<---------------cut here---------------start------------->8--- > +Perhaps the biggest action you can do to help GNU Guix grow as a project > +is to review the work contributed by others. You do not need to be a > +committer to do so; applying, reading the source, building, linting and > +running other people's series and sharing your comments about your > +experience will give some confidence to committers, and should result in > +the proposed change being merged faster. > --8<---------------cut here---------------end--------------->8--- > > So it does mention trying out the software ("running"). If LGTM also implies =E2=80=9CI run it and it is OK=E2=80=9D, then submitte= r should provide how to run it. Otherwise, for what it is worth, I will stop to review stuff that I do not use myself because reviewing is asking me too much: read some doc about how to run something that I do not care. ( Similarly, if LGTM also implies =E2=80=9CI have read the source code = and it is OK=E2=80=9D, it appears to me too much. ) Well, =E2=80=9Crunning=E2=80=9D and =E2=80=9Ctrying out the software=E2=80= =9D seems ambiguous. What does it mean =E2=80=9Crun IceCat=E2=80=9D or =E2=80=9Crun Gmsh=E2=80=9D or = else? What I like with the proposal is that it makes better defined what are the expectations behind LGTM. But what means =E2=80=9Crunning=E2=80=9D is = not clear for me. IMHO, it is worth to clearly state: 1. what helps the review process: =C2=AB applying, reading the source, building, linting and running other people's series and sharing your comments about your experience will give some confidence to committers, and should result in the proposed change being merged faster. =C2=BB 2. what means LGTM, from my understanding: applying, building, linting, carefully checking the code that is merged to Guix. Cheers, simon