From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TqN-0007os-Ci
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:23:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TqI-0007Ur-F5
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:23:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33265)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d1TqI-0007Ug-AV
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TqI-0000SP-1z
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:23:02 -0400
Subject: bug#26544: [PATCH v2 0/8] system: Move "--load" and other
	guix-specific parameters from the grub module to the generic
	system module.
Resent-Message-ID: <handler.26544.B26544.14927629561706@debbugs.gnu.org>
References: <20170417170030.2212-1-dannym@scratchpost.org>
	<20170421022127.20524-1-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170421022127.20524-1-dannym@scratchpost.org>
Date: Fri, 21 Apr 2017 10:22:49 +0200
Message-ID: <86h91ikw4m.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26544@debbugs.gnu.org


Hi Danny,

Most of the serie LGTM.

However, I noticed that the grub menuentries in /boot/grub/grub.cfg
produced during a reconfigure are loosing their labels (#1, ...).

Thanks,

Mathieu

Danny Milosavljevic writes:

> Danny Milosavljevic (8):
>   system: Rename operating-system-kernel-arguments to
>     operating-system-user-kernel-arguments.
>   system: Rename operating-system-parameters-file to
>     operating-system-boot-parameters-file.
>   system: Factorize operating-system-boot-parameters-file.
>   system: Introduce operating-system-kernel-arguments and use it.
>   system: Introduce read-boot-parameters-file.
>   system: vm: Use operating-system-kernel-arguments.
>   system: Use operating-system-boot-parameters directly.
>   system: grub: Use boot-parameters instead of menu-entry where
>     possible.
>
>  gnu/system.scm          | 133 +++++++++++++++++++++++++++++++-----------------
>  gnu/system/grub.scm     |  14 ++++-
>  gnu/system/vm.scm       |   7 +--
>  guix/scripts/system.scm |  24 ++++-----
>  4 files changed, 110 insertions(+), 68 deletions(-)