From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KBKsCiBFZ2C4dQAAgWs5BA (envelope-from ) for ; Fri, 02 Apr 2021 18:24:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SK1bBCBFZ2AjDQAAbx9fmQ (envelope-from ) for ; Fri, 02 Apr 2021 16:24:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99BE71A9EE for ; Fri, 2 Apr 2021 18:23:59 +0200 (CEST) Received: from localhost ([::1]:57146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSMaU-0006Yb-QB for larch@yhetil.org; Fri, 02 Apr 2021 12:23:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSMVi-0001YR-VJ for guix-patches@gnu.org; Fri, 02 Apr 2021 12:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSMVi-0003L0-MQ for guix-patches@gnu.org; Fri, 02 Apr 2021 12:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSMVi-0005Lt-Hn for guix-patches@gnu.org; Fri, 02 Apr 2021 12:19:02 -0400 Subject: bug#47282: [PATCH 00/13] node going forward Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 02 Apr 2021 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 47282-done@debbugs.gnu.org Mail-Followup-To: 47282@debbugs.gnu.org, jlicht@fsfe.org, jlicht@fsfe.org Received: via spool by 47282-done@debbugs.gnu.org id=D47282.161738029420504 (code D ref 47282); Fri, 02 Apr 2021 16:19:02 +0000 Received: (at 47282-done) by debbugs.gnu.org; 2 Apr 2021 16:18:14 +0000 Received: from localhost ([127.0.0.1]:32793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSMUv-0005Kc-Tj for submit@debbugs.gnu.org; Fri, 02 Apr 2021 12:18:14 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:35030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSMUu-0005KT-8u for 47282-done@debbugs.gnu.org; Fri, 02 Apr 2021 12:18:12 -0400 From: Jelle Licht In-Reply-To: <87k0pprz6n.fsf@ngyro.com> References: <20210320145706.12308-1-jlicht@fsfe.org> <87k0pprz6n.fsf@ngyro.com> Date: Fri, 02 Apr 2021 18:18:08 +0200 Message-ID: <86ft083bjz.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617380639; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qcVlnwnwiY2bzI14Vy1Fh6qOjGYs4m9Rb/dYKZKRzBk=; b=RjMyhGEjstGe51k22LndHH9wEkF48tOBzFPFBtGxaoiwhb9/9NoeUEh70ZTK/sPs+erITf CR5V/A6zpRwXZVScwkGC1ez7qyZc4VTHLz4HofDwZm8gW3jCdfXgcvB5aUgvyutqSPltUe EqbsitKf0SISfozxOKH2c3Yl8qbRqgSt9lyPXLeFpnDyXL4h410DnEeCQOZYm+mULQmWBd Eeu2g9A9V4QLIaQKWhH5Gr7CkZZTwDGJzMGbW7sp8QM0gGp8HbETSzJB0OvZz+Xdmhgm9o 4jT/PtZ9HNyTTRvoRQzKMdcUCoY6e0Pogv7sUjTOBlYNq3oEsFgv7Pf4rDNsAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617380639; a=rsa-sha256; cv=none; b=sCBbPVNR6QKhmhkova6Ejq+iKjai9YmwAQJAfg11vqUWSHnQU1v9UIEiBGfIk8TOwSeACV q3U79pxp6sJQok9KUlAz9cwIXRnMYU4ggIqbBD/xUBfD+u1RvrLylAA89cgq8NhvNiVgUx cq7fLFNlVWk+xXaWWS6LGcMmUTbfQSRBkzbmcO++mI9LSMESMrJSeJp1YIlc1UnLcveauj sTaFjcZINdWgWweBSsXhGI7ckqCS+OFxs6+wa+RsaaRAfmmA0w2ZAZRMTZZkmPMTYRUrDI Pl6nxtYxhywH2CqIu2Ndwbgn4F4jK/YyF12YKk7RCVDB8SYeeMc1iJDsx3q4iQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 99BE71A9EE X-Spam-Score: -0.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: GSQT8lqRII89 Timothy, Timothy Sample writes: > Hi Jelle, > > Jelle Licht writes: > >> So, some people seem to be interested in this one; please review and tes= t. > > Now that I=E2=80=99ve finally taken the time to dig into what you=E2=80= =99ve done here =E2=80=93 > I must say it=E2=80=99s very impressive! If you bang your head against a wall often enough, it will crack eventually. Head or wall, either way works in this metaphor ;-). > I=E2=80=99ve taken the presumptuous step of re-rolling the series. The r= eason > is that all the =E2=80=9C(delete 'build)=E2=80=9D bits were bothering me.= I decided to > have the build system check the =E2=80=9Cpackage.json=E2=80=9D file for a= build script > before trying to run it. Since that change required changing all the > other patches, I thought it would be easier to just post the updated > patches. Also, I=E2=80=99m hoping to spare you some trouble (since you= =E2=80=99ve > already gone to a lot!). Makes sense, thanks! Please be presumptuous as often as you'd like. > > =E2=80=A2 Change the =E2=80=9CFix incorrect import semantics=E2=80=9D= comments to =E2=80=9CFix > imports for esbuild=E2=80=9D. To me, if TypeScript=E2=80=99s tsc l= ikes the > imports, they are correct TypeScript (despite the esbuild bug > report). "Something a native speaker of English can make sense of" !=3D "Proper English", and in that same vein I don't think a commmon mistake with workaround in place is not a mistake. I really don't care about what ends up in the codebase though, as long as it is clear why we do what we do, which works out just fine with your comment. > The final result is still a little messy, but I don=E2=80=99t think we sh= ould > hold this back any longer. It=E2=80=99s a significant step forward, and = it puts > us in better shape to improve things incrementally. > > WDYT? Let me know if I made anything worse! :) If the altered patches > look good to you, I suggest you go ahead and push them. I still adressed some of Efraim's remarks, and pushed it to master just now. There are quite some ways to go from here: * Get the 'binary' importer upstreamable (I will continue with this) * Properly support cross-compilation of Node and Node-packages I had a super quick look at this, but it seems that in building node, you build intermediate tools that run on the host. Perhaps some our x-compilation gurus can weigh in. * Make a Rome-based build system, once Rome does more than linting, to help untangle the knot that is JavaScript-packaging But for today (and the upcoming release), modern Node on guix \o/ Thanks folks! - Jelle