From: David Elsing <david.elsing@posteo.net>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>,
58261@debbugs.gnu.org
Subject: [bug#58261] [PATCH 03/11] gnu: Add sajson.
Date: Fri, 07 Oct 2022 15:10:48 +0000 [thread overview]
Message-ID: <86fsfz6553.fsf@posteo.net> (raw)
In-Reply-To: <61e7edbb4d21c916338e1433886b0abaf0732567.camel@ist.tugraz.at>
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:
> Am Montag, dem 03.10.2022 um 00:19 +0000 schrieb David Elsing:
>> * gnu/packages/cpp.scm (sajson): New variable.
>> ---
>> gnu/packages/cpp.scm | 63
>> +++++++++++++++++++
>> .../patches/sajson-parse_flags-linking.patch | 45 +++++++++++++
>> 2 files changed, 108 insertions(+)
>> create mode 100644 gnu/packages/patches/sajson-parse_flags-
>> linking.patch
>>
>> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
>> index 65df317100..7bfa3d6cdf 100644
>> --- a/gnu/packages/cpp.scm
>> +++ b/gnu/packages/cpp.scm
>> @@ -57,6 +57,7 @@ (define-module (gnu packages cpp)
>> #:use-module (guix build-system gnu)
>> #:use-module (guix build-system meson)
>> #:use-module (guix build-system python)
>> + #:use-module (guix build-system scons)
>> #:use-module (guix modules)
>> #:use-module (guix gexp)
>> #:use-module (gnu packages)
>> @@ -1957,3 +1958,65 @@ (define-public pocketfft
>> which is an reimplementation of FFTPack with several advantages,
>> such as
>> multidimensional algorithms, different datatypes and vector
>> instructions.")
>> (license license:bsd-3))))
>> +
>> +(define-public sajson
>> + (let ((commit "ec644013e34f9984a3cc9ba568cab97a391db9cd")
>> (revision "0"))
>> + (package
>> + (name "sajson")
>> + (version (git-version "0.0.0" revision commit))
> Note that the swift FFI is advertised as 1.0 and there has been a
> blogpost claiming it to be 1.0 in 2013.
Ah ok, then I'll set it to 1.0.
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/chadaustin/sajson")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (patches
>> + (search-patches "sajson-parse_flags-
>> linking.patch"))
>> + (sha256
>> + (base32
>> +
>> "0fjag27w7gvkc5pdhq3ad7yc09rabpzahndw1sgsg04ipznidmmq"))
>> + (modules '((guix build utils)))
>> + (snippet '(delete-file-recursively "third-party"))))
>> + (build-system scons-build-system)
>> + (arguments
>> + (list
>> + #:phases
>> + #~(modify-phases %standard-phases
>> + (add-after 'unpack 'disable-other-builds
>> + (lambda _
>> + (substitute* "SConstruct"
>> + (("for name, tools in builds:")
>> + "for name, tools in [('opt', [gcc, opt])]:"))
>> + #t))
>> + (add-after 'unpack 'use-external-unittest-cpp
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "SConscript"
>> + (("unittestpp_env\\.Library") "_dummy = ")
>> + (("test_env = env.Clone\\(tools=\\[unittestpp,
>> sajson\\]\\)")
>> + (string-append
>> + "test_env = env.Clone(tools=[sajson])\n"
>> + "test_env.Append(CPPPATH='"
>> + (search-input-directory inputs
>> "/include/UnitTest++")
>> + "', LIBPATH='"
>> + (string-append #$(this-package-native-input
>> "unittest-cpp")
>> + "/lib")
>> + "', LIBS=['UnitTest++'])")))
>> + #t))
>> + (replace 'check
>> + (lambda* (#:key tests? #:allow-other-keys)
>> + (when tests?
>> + (invoke "build/opt/test")
>> + (invoke "build/opt/test_unsorted"))
>> + #t))
>> + (replace 'install
>> + (lambda _
>> + (let ((out (string-append #$output "/include")))
>> + (install-file "include/sajson.h" out)
>> + (install-file "include/sajson_ostream.h" out))
>> + #t)))))
> You don't need the trailing #ts
Oh thanks, I think I read something outdated.
>> + (native-inputs (list unittest-cpp))
>> + (home-page "https://github.com/chadaustin/sajson")
>> + (synopsis "Lightweight, extremely high-performance JSON parser
>> for C++11")
>> + (description "sajson is a high-performance, in-place JSON
>> parser
>> +header-only library.")
> Cut down on the ads.
>> + (license license:expat))))
>> diff --git a/gnu/packages/patches/sajson-parse_flags-linking.patch
>> b/gnu/packages/patches/sajson-parse_flags-linking.patch
>> new file mode 100644
>> index 0000000000..878706dc79
>> --- /dev/null
>> +++ b/gnu/packages/patches/sajson-parse_flags-linking.patch
>> @@ -0,0 +1,45 @@
>> +This patch is from the upstream pull request
>> +https://github.com/chadaustin/sajson/pull/54.
>> +It fixes linking with GCC.
>> +
>> +diff --git a/include/sajson.h b/include/sajson.h
>> +index 8b4e05a..1bd045b 100644
>> +--- a/include/sajson.h
>> ++++ b/include/sajson.h
>> +@@ -138,12 +138,17 @@ constexpr inline size_t make_element(tag t,
>> size_t value) {
>> + // header. This trick courtesy of Rich Geldreich's Purple JSON
>> parser.
>> + template <typename unused = void>
>> + struct globals_struct {
>> ++ static const unsigned char parse_flags[256];
>> ++};
>> ++typedef globals_struct<> globals;
>> ++
>> + // clang-format off
>> +
>> + // bit 0 (1) - set if: plain ASCII string character
>> + // bit 1 (2) - set if: whitespace
>> + // bit 4 (0x10) - set if: 0-9 e E .
>> +- constexpr static const uint8_t parse_flags[256] = {
>> ++ template <typename unused>
>> ++ const unsigned char globals_struct<unused>::parse_flags[256] =
>> {
>> + // 0 1 2 3 4 5 6 7 8 9 A
>> B C D E F
>> + 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 2,
>> 0, 0, 2, 0, 0, // 0
>> + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>> 0, 0, 0, 0, 0, // 1
>> +@@ -162,15 +167,13 @@ struct globals_struct {
>> + };
>> +
>> + // clang-format on
>> +-};
>> +-typedef globals_struct<> globals;
>> +
>> +-constexpr inline bool is_plain_string_character(char c) {
>> ++inline bool is_plain_string_character(char c) {
>> + // return c >= 0x20 && c <= 0x7f && c != 0x22 && c != 0x5c;
>> + return (globals::parse_flags[static_cast<unsigned char>(c)] &
>> 1) != 0;
>> + }
>> +
>> +-constexpr inline bool is_whitespace(char c) {
>> ++inline bool is_whitespace(char c) {
>> + // return c == '\r' || c == '\n' || c == '\t' || c == ' ';
>> + return (globals::parse_flags[static_cast<unsigned char>(c)] &
>> 2) != 0;
>> + }
> Since this fixes an error that occurs when building with GCC 10, the
> patch name should reflect that, e.g. "sajson-build-with-gcc10" (whether
> you include or do not include a dash between gcc and 10 doesn't seem to
> matter).
>
> Cheers
next prev parent reply other threads:[~2022-10-07 15:46 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 22:55 [bug#58261] [PATCH 00/11] Add rdkit David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 01/11] gnu: Add fast-float David Elsing
2022-10-04 6:57 ` Liliana Marie Prikler via Guix-patches via
2022-10-07 15:08 ` David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 02/11] gnu: Add pocketfft David Elsing
2022-10-04 7:09 ` Liliana Marie Prikler
2022-10-07 15:10 ` David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 03/11] gnu: Add sajson David Elsing
2022-10-04 7:22 ` Liliana Marie Prikler
2022-10-07 15:10 ` David Elsing [this message]
2022-10-03 0:19 ` [bug#58261] [PATCH 04/11] gnu: Add tinydir David Elsing
2022-10-04 7:27 ` Liliana Marie Prikler
2022-10-07 15:11 ` David Elsing
2022-10-07 15:13 ` Liliana Marie Prikler
2022-10-03 0:19 ` [bug#58261] [PATCH 05/11] gnu: Add optionparser David Elsing
2022-10-04 7:42 ` Liliana Marie Prikler
2022-10-07 15:11 ` David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 06/11] gnu: Add gemmi David Elsing
2022-10-04 7:49 ` Liliana Marie Prikler
2022-10-07 15:11 ` David Elsing
2022-10-07 15:17 ` Liliana Marie Prikler
2022-10-03 0:19 ` [bug#58261] [PATCH 07/11] gnu: Add freesasa David Elsing
2022-10-04 8:02 ` Liliana Marie Prikler
2022-10-07 15:12 ` David Elsing
2022-10-07 15:19 ` Liliana Marie Prikler
2022-10-03 0:19 ` [bug#58261] [PATCH 08/11] gnu: Add maeparser David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 09/11] gnu: Add coordgenlibs David Elsing
2022-10-03 0:19 ` [bug#58261] [PATCH 10/11] gnu: Add yaehmop-tightbind David Elsing
2022-10-04 7:54 ` Liliana Marie Prikler
2022-10-07 15:12 ` David Elsing
2022-10-07 15:25 ` Liliana Marie Prikler
2022-10-03 0:19 ` [bug#58261] [PATCH 11/11] gnu: Add rdkit David Elsing
2022-10-04 8:13 ` Liliana Marie Prikler
2022-10-07 15:12 ` David Elsing
2022-10-07 15:29 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 00/13] Add rdkit v2 David Elsing
2022-10-09 10:02 ` Liliana Marie Prikler
2022-10-13 20:58 ` David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 00/15] Add rdkit v3 David Elsing
2022-10-15 14:37 ` bug#58261: " Liliana Marie Prikler
2022-10-17 9:55 ` [bug#58261] " David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 01/15] gnu: Add fast-float David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 02/15] gnu: Add pocketfft-cpp David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 03/15] gnu: Add sajson David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 04/15] gnu: Add cbehave David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 05/15] gnu: Add tinydir David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 06/15] gnu: Add optionparser David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 07/15] gnu: Add sajson-for-gemmi David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 08/15] gnu: Add gemmi David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 09/15] gnu: Add freesasa David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 10/15] gnu: Add maeparser David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 11/15] gnu: Add coordgenlibs David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 12/15] gnu: Add yaehmop David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 13/15] gnu: Add avalon-toolkit David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 14/15] gnu: Add ringdecomposerlib David Elsing
2022-10-13 21:04 ` [bug#58261] [PATCH v3 15/15] gnu: Add rdkit David Elsing
2022-10-07 15:21 ` [bug#58261] [PATCH v2 01/13] gnu: Add fast-float David Elsing
2022-10-09 10:04 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 02/13] gnu: Add pocketfft David Elsing
2022-10-09 11:42 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 03/13] gnu: Add sajson David Elsing
2022-10-09 11:46 ` Liliana Marie Prikler
2022-10-13 20:59 ` David Elsing
2022-10-14 21:30 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 04/13] gnu: Add tinydir David Elsing
2022-10-09 11:48 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 05/13] gnu: Add optionparser David Elsing
2022-10-07 15:21 ` [bug#58261] [PATCH v2 06/13] gnu: Add gemmi David Elsing
2022-10-09 11:54 ` Liliana Marie Prikler
2022-10-13 21:00 ` David Elsing
2022-10-14 21:32 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 07/13] gnu: Add freesasa David Elsing
2022-10-07 15:21 ` [bug#58261] [PATCH v2 08/13] gnu: Add maeparser David Elsing
2022-10-07 15:21 ` [bug#58261] [PATCH v2 09/13] gnu: Add coordgenlibs David Elsing
2022-10-09 11:56 ` Liliana Marie Prikler
2022-10-13 21:00 ` David Elsing
2022-10-07 15:21 ` [bug#58261] [PATCH v2 10/13] gnu: Add yaehmop-tightbind David Elsing
2022-10-09 12:02 ` Liliana Marie Prikler
2022-10-13 21:00 ` David Elsing
2022-10-14 21:33 ` Liliana Marie Prikler
2022-10-07 15:21 ` [bug#58261] [PATCH v2 11/13] gnu: Add avalontoolkit David Elsing
2022-10-09 12:06 ` Liliana Marie Prikler
2022-10-13 21:01 ` David Elsing
2022-10-07 15:22 ` [bug#58261] [PATCH v2 12/13] gnu: Add ringdecomposerlib David Elsing
2022-10-07 15:22 ` [bug#58261] [PATCH v2 13/13] gnu: Add rdkit David Elsing
2022-10-09 12:12 ` Liliana Marie Prikler
2022-10-13 21:01 ` David Elsing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fsfz6553.fsf@posteo.net \
--to=david.elsing@posteo.net \
--cc=58261@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.