From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +BfQC4IFpGNPcwAAbAwnHQ (envelope-from ) for ; Thu, 22 Dec 2022 08:21:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ECzMC4IFpGNIDQEAauVa8A (envelope-from ) for ; Thu, 22 Dec 2022 08:21:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9723522BC for ; Thu, 22 Dec 2022 08:21:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8Ft7-000132-Pz; Thu, 22 Dec 2022 02:21:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8Ft1-00011d-66 for guix-patches@gnu.org; Thu, 22 Dec 2022 02:21:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8Ft0-0006GS-UF for guix-patches@gnu.org; Thu, 22 Dec 2022 02:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p8Ft0-0003VQ-Po for guix-patches@gnu.org; Thu, 22 Dec 2022 02:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60120] [PATCH 01/28] gnu: Add ocaml-5.0. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Dec 2022 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 60120-done@debbugs.gnu.org Received: via spool by 60120-done@debbugs.gnu.org id=D60120.167169364813435 (code D ref 60120); Thu, 22 Dec 2022 07:21:02 +0000 Received: (at 60120-done) by debbugs.gnu.org; 22 Dec 2022 07:20:48 +0000 Received: from localhost ([127.0.0.1]:56644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8Fsl-0003Ud-So for submit@debbugs.gnu.org; Thu, 22 Dec 2022 02:20:48 -0500 Received: from mout02.posteo.de ([185.67.36.66]:59639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8Fsg-0003UI-5E for 60120-done@debbugs.gnu.org; Thu, 22 Dec 2022 02:20:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3154E240103 for <60120-done@debbugs.gnu.org>; Thu, 22 Dec 2022 08:20:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671693636; bh=nDH5F/4idQbMPDu7A3vmtnhLR5JNJ/cQJAP0gOhLrN8=; h=From:To:Cc:Subject:Date:From; b=ZU6t7DTNGooS+3q7/ZrEYW+5G3J07DXhyaS6dfkeUI3m2Mporg4aKyaojDO12+UW8 7Bb+OlP9isqtlYYZXykGFHZiT/02Kxj9o12mxhPMOgJqWs2E1x8rHK0GQVsD43q2vY v5l2gTsI1oAft82DyG52RP3tnuaJNiOLVGZHmHRuKObeEg0+2A1rGgVg319farv4De 8Wg/BXDoKFnkMmisXZKVnFM5fU/9aGYRCJCMW1FXUg1/HEzaFhUPPZsWBlDBt+qxrt V4Uv/u2VmFlC+q7Mgc5Hkzr0yTh2LDndJ0xUukDK6W+HjiYzKVlbDKhVvZAXggLw1C O+02zbTcrCARg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nd1tV3RfGz6tnw; Thu, 22 Dec 2022 08:20:31 +0100 (CET) References: <20221216132224.2229-1-pukkamustard@posteo.net> <20221216132527.2539-1-pukkamustard@posteo.net> <20221221221153.7915a496@sybil.lepiller.eu> From: pukkamustard Date: Thu, 22 Dec 2022 07:08:07 +0000 In-reply-to: <20221221221153.7915a496@sybil.lepiller.eu> Message-ID: <86fsd7dhvk.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671693698; a=rsa-sha256; cv=none; b=tZL8C2+HfBK2+xLdLtwvsd9AvZot/GTKKCHbw82onnq8/TtK1ZXM4dRqDpSCN72Uxb0Rzk eetvaTc5sFQdZMF38UB25pZUOXW3ZnjiLY+iYxlsljkPO85wR/qRGv/As4HZ/OfvsJHmHv qkJCTqPaxZrKAl/YjC+I1YLyWFRuZ+BW/rMz8M56fYHqQT/ggKUgqWKnSFl189Zhk/ZClE jB/hYIwBiFBBZYzGx4v8ZUrs9FUBZjiR3irn/V5WlaCU3gQX143E0zSQ6BBviBMC53fdv6 wUxSxKvjhKQoLqT7fh7BlE046IwZJi9ZD95OQ1/Af1D9Uqru3fie+cozD+HsPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ZU6t7DTN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671693698; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=nDH5F/4idQbMPDu7A3vmtnhLR5JNJ/cQJAP0gOhLrN8=; b=Qe0JZNiPbA0UpjIt/rYX5qjbUypOWj4wGuBTFl+S5ZCbcqzeLAnz3oGlZn7HtWoougXU9m W3E4T/1RIUE+qhDho7xhzU7FYpTMRE86+beWpWaulAuuKZ0R+viYaHwQrvBmnJR/4T8DQO ltuMgrb9273l0foeD1Oba2PfirnDnRxoLI6i6lbuoCbF+rLjwl/LONUj4Mdys71w9Q3oo8 KWg/itSE6ksK6GTl1oRqzysvQ+kP3nRXn/xIBOCdHoTe3oGW7siD81SSwEH/wbqQrYhi3o q4+r0KHuH3NKGhSweEczlcdjwvOHttYBNVy3vgXztZHqsuNNvBj0Zb80GzMYhA== X-Spam-Score: -2.90 X-Migadu-Queue-Id: 9723522BC Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ZU6t7DTN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.90 X-TUID: 0u6hgZRMPJe5 Hi Julien, Thanks for your review! I'm very sorry for the sloppiness. I guess these patches were collecting in a WIP status for months and I hurriedly fixed them up in OCaml 5 excitement. Julien Lepiller writes: > [20/28] > Description does not match our usual style. It seems you didn't define > ocaml-eio as public, because it fails to build. Would be great to fix, > wdyt? ocaml-eio is an OCaml 5 only package. It won't compile with OCaml 4.14. That's the reason for not making ocaml-eio public. I guess a comment shold have been added. Thanks again! -pukkamustard