From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +JBmAYcw7Ga0EwEAe85BDQ:P1 (envelope-from ) for ; Thu, 19 Sep 2024 14:09:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +JBmAYcw7Ga0EwEAe85BDQ (envelope-from ) for ; Thu, 19 Sep 2024 16:09:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ZjKn0Ol5; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=fK6wR9HV; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726754950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DDvMU8+G1qvDpbcUtfCZWP2PE2WDANvbqYKozHG+fvY=; b=s/w+iYWtumkggH3eQY/ZHHL6WmIEkyhjPV7Jm8oOseZpt7lD3G9vpiOAuiJe3K8Arz3cQI 3CVhpuLQO+sWDMbNn7qqpS0dV2+PhnanzqdM6/UyXW2zOoYLZ2zWKERI3TXZbSrocspaaI Wk53lbie9qr5vyn+ajIauF0HJ4ptc3lZjGPFNb8PEcTXc8ONQZEEbLKe5s+VvrUeuSp+Av A/h2SuwQ30dlGK6C6I2KMBJd+zwA/Q7y7zFbGiOVOKur1CoaENAScBEd5g+iUlqweI9Xe2 28rjCHiZ1RTuFJUM6AwAxKf+ir0c9gmFhnf2cAEDhyuTYSKqFNtx/msLsGQQZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726754950; a=rsa-sha256; cv=none; b=aVFEXVd7NfB8TrEvk0srNECSCuP39IGrgNr5VXqQqlj4Uc6LHbMi2Jga3b0tYoD/3z2jfT EzsTfidFun+bGdloj1aLhS3RvKlwZFI2+Z5HSt2jqaEmz1zFfT9rgunU4lYlo0tiki6XY5 4AzZuQ0BEW/+6aCm78/kYnnYyJGkDzGW7stescHI9Y/TKQVQNK+SjBAGeCQ3dtlnh2NIm2 MNR0s+z8JCeTbkVVc2D8Y9cL2767n98qAyD79R0kugoCKQ4l7xnTIa2ndmu0SWZQJDg1Yy JLELq9ZQcrefmazmBZ2yvMHYTNX4QmZ4szGxoE24+0XO4kz/hUL80HEulsHTBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ZjKn0Ol5; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=fK6wR9HV; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC290FE06 for ; Thu, 19 Sep 2024 16:09:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srHq3-0004uu-1Y; Thu, 19 Sep 2024 10:08:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srHpu-0004uQ-Ht for guix-patches@gnu.org; Thu, 19 Sep 2024 10:08:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srHpt-0000TX-BD for guix-patches@gnu.org; Thu, 19 Sep 2024 10:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=DDvMU8+G1qvDpbcUtfCZWP2PE2WDANvbqYKozHG+fvY=; b=ZjKn0Ol5tyvrQE4sjI5t2YHYX1RTY+IwR+g2JKUQ1Ki6f/JoplumOmuwvVEjWjnKSyXfCn9t/hM8rikZzf6+qUh3reSZNRh49GfFCvJ/YdObICbVVCH8yAWiAjsS88wHP6ARaxp1PEsS9drsB43WYHmvfh6iEyW1zUV2sCDW3uAOWG1jyODPPbE4h9tPiIKrqA7R8Wl9hI4nnvDtQMP34I2GUZuyN86LNMfRvF1WRDgoi0qcsth9JZEOtCHEvVaFHgM5qxdiuyMlE+IZhj6Cldf923e2phr6kdraSwB9kWE4s8ukMhAxrmrGIsGkrgirY21pAdJiz9AtEsaYtCs3ew==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srHqA-0001JD-I6 for guix-patches@gnu.org; Thu, 19 Sep 2024 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Sep 2024 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz Received: via spool by 73028-submit@debbugs.gnu.org id=B73028.17267548944960 (code B ref 73028); Thu, 19 Sep 2024 14:09:02 +0000 Received: (at 73028) by debbugs.gnu.org; 19 Sep 2024 14:08:14 +0000 Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHpN-0001Hw-O0 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 10:08:14 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srHpI-0001Hb-NY for 73028@debbugs.gnu.org; Thu, 19 Sep 2024 10:08:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7E171240027 for <73028@debbugs.gnu.org>; Thu, 19 Sep 2024 16:07:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726754864; bh=xfiNwFovoyD/a8iANUZSjjFjF2oJFJy8PnVTAJgiBag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=fK6wR9HVZWAW4yd56j01sCTS5hXxh3PSK0ZbV9me9833Vo6joIsrs5ZQDlZLWgwDO TaWhxq+OPYN/w65o/4AR36WNTQMKYN/vCJnVMRICW31ZC61s6nqnyoJDVRBZmKNYcE R1nzGyN8j/Av1b+SVAhuQlgx4M8LD46UK99LzMNNSAXmdghwNgwBu5YaV0bE458hUl BuANn/RZ76AEh0iHTrG4bQvz4uYs0vfDwfzdY7KkyervfbDHjedqUwjBlPEzWaJoit URfGL8fchww4BNgHUH3YfwFqeUU4DqxHOnRUgRYsB8B+v7hBLugpTClKqjGik/sORT qsYGI8I5juvnw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X8cmG6jtkz9rxD; Thu, 19 Sep 2024 16:07:42 +0200 (CEST) Message-ID: <86f53b3e-976c-4757-9dcb-d41dce7263b9@posteo.net> Date: Thu, 19 Sep 2024 14:07:10 +0000 MIME-Version: 1.0 References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> <87plp6s683.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87plp6s683.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.71 X-Spam-Score: -4.71 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Queue-Id: DC290FE06 X-TUID: 6ijPZHkH9Lns On 14.09.24 15:41, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > >> >> This does not work. I tried adding that to the arguments in the bag >> (and reverting the previous patch) but get an error: >> >> Unrecognized keyword: #:out-of-source? >> >> I guess this is because meson-(cross-)build now get a keyword they >> don't know. > > Hm. Thanks for trying it out. > Not an expert on how this works but it looks like when a phase has a keyword that is not being passed in by the build-system it is treated as #f even if there is no default parameter specified in install-license-files function itself. If there is no easy other way what about leaving the parameter undocumented as is? Maybe Ludo can elaborate on what the original concern was? >> Maybe we could replace the install-license-files function with a >> version that has #:out-of-source? set to #t?. Not sure if there is an >> elegant way to do this? > > Is this really the only reused phase from gnu-build-system that makes > use of #:out-of-source? I'd expect the 'configure' to be one, also. > And in general it'd be a bit more risky; new gnu-build-system phases > that would make use of #:out-of-source could start breaking in the > future until thye are specially handled. > As far as I can see only the configure phase and the install-license-phase in gnu-build-system use that parameter. As meson overwrites configure with its own it only the install-license-files phase uses it.