From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TrO-00080p-Jh
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:24:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TrG-00089j-C9
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:24:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33270)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d1TrG-00089f-91
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1TrG-0000UK-2H
	for guix-patches@gnu.org; Fri, 21 Apr 2017 04:24:02 -0400
Subject: bug#26544: [PATCH v2 2/8] system: Rename
	operating-system-parameters-file to
	operating-system-boot-parameters-file.
Resent-Message-ID: <handler.26544.B26544.14927629861812@debbugs.gnu.org>
References: <20170421022127.20524-1-dannym@scratchpost.org>
	<20170421022127.20524-3-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170421022127.20524-3-dannym@scratchpost.org>
Date: Fri, 21 Apr 2017 10:23:19 +0200
Message-ID: <86efwmkw3s.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26544@debbugs.gnu.org


LGTM!

Danny Milosavljevic writes:

> * gnu/system.scm (operating-system-parameters-file): Rename to ...
> (operating-system-boot-parameters-file): ... this.
> (operating-system-directory-base-entries): Adapt call site.
> ---
>  gnu/system.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 4032e8e15..44190bdfc 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -278,7 +278,7 @@ value of the SYSTEM-SERVICE-TYPE service."
>          (mlet %store-monad
>              ((kernel  ->  (operating-system-kernel os))
>               (initrd      (operating-system-initrd-file os))
> -             (params      (operating-system-parameters-file os)))
> +             (params      (operating-system-boot-parameters-file os)))
>            (return `(("kernel" ,kernel)
>                      ("parameters" ,params)
>                      ("initrd" ,initrd)
> @@ -769,7 +769,7 @@ device in a <menu-entry>."
>      ((label) (file-system-device fs))
>      (else #f)))
>  
> -(define (operating-system-parameters-file os)
> +(define (operating-system-boot-parameters-file os)
>    "Return a file that describes the boot parameters of OS.  The primary use of
>  this file is the reconstruction of GRUB menu entries for old configurations."
>    (mlet %store-monad ((initrd   (operating-system-initrd-file os))