From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uHqWGCoXAGWYvQAA9RJhRA:P1 (envelope-from ) for ; Tue, 12 Sep 2023 09:45:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uHqWGCoXAGWYvQAA9RJhRA (envelope-from ) for ; Tue, 12 Sep 2023 09:45:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E32C4451A7 for ; Tue, 12 Sep 2023 09:45:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eN0Qh6Fx; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694504746; a=rsa-sha256; cv=none; b=f9o6ze8kWtaKTPXQXiAFUpbQlVaap7C6iIDaomvWFg+/lhc/uXFPi9FEqJW/8w7XVMjwlC LsB+rSchqVdVRTOamt9gR7GNYjMDof9yJiB9mHMJwdw6xmSjDiaz/Z2ay2bRRbl5X17BCH ztuvsQ8RpFvcjfXZCf5z3XDCe5khpmHNjzqdGRsV5RSMuh00oGHewDF1I4H9ecnGH9v4F6 1JMvbsooS/GJGmt4Gia2Pq+gVq2NVcAtPM9CKAUtLBU/vzxsaqujHO5xeuJDD2BWhvr4ez dAZqEb2Ja4oUad9oQBX3TkG6OzLVS1Re82K+XgHPtHpq+MumMc7jxg0VcpkrtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694504746; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XNU9WlhZnXq0aTPOYgIi6SSVbpFySJZneD0vSWjhiss=; b=cdflfOzVh8MdmcyP5+LrGUNO+B7kyc2jmad4bfZSMSTEgWJsrpTqxPr66xEFcIys+Y0JMD p/6H2Fej+0qM6V8drL+vLOKruHoV2/DDomX6mH9LLGQkGfiVWNKn8vcXwfOlaOuouoFFIP fTpyJwkw2lG8cTyvp2mmu6olXnNo5XE+xqc5F4zXgTQ/3tH9nECcr+rM94GMvzvHRL/fn0 4mP25lqBX7VkPSYDuIKckDNQPdkG0y9zUN0FhwHM1acsiFQ1Di2UMB6vcwEIqCh273RMZ7 R4Lq3grhHoibOripaJvOhILNrrIMy6OXMX2sXgXQRZHt525EOplA4wV5DvWH5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eN0Qh6Fx; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfy56-0006JO-9Q; Tue, 12 Sep 2023 03:45:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfy54-0006J8-Q6 for guix-devel@gnu.org; Tue, 12 Sep 2023 03:45:06 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfy51-0006T6-1Y; Tue, 12 Sep 2023 03:45:06 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-31f2ab21231so825825f8f.0; Tue, 12 Sep 2023 00:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694504701; x=1695109501; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XNU9WlhZnXq0aTPOYgIi6SSVbpFySJZneD0vSWjhiss=; b=eN0Qh6FxP7w1tlnDx5Dd86pl7SiU2KR53o00tSN9eT23VO2BMbeOk4m/mXIxDZLUAi jYj3uZqkLeVhf2sUmx3gF/uJcC6Sp7F/K73Wm6tdddnE86JXmcv6OqXaDdibmdsy46rM FsxwUwVIYO+Vxx5NLIt8HixTDONoyCgWJyQBJ21rLJaUWr42q7fUyzZqxKT++a1VBhs1 vLjmnUqfoti0kYppPOyR+j4PLsKOq5UH8RKXmU09ppv3jwFBBK6Ek4hNM0+4/sbwAyWV qxzPKZqD7evZ87gkLNnqJl4HAfoBt/p/9cxIQOEOe8GYAuypTzbRGHlRjHKEBWQLUM/S XMFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694504701; x=1695109501; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XNU9WlhZnXq0aTPOYgIi6SSVbpFySJZneD0vSWjhiss=; b=IqqzHaN2wKogyV1SzQCfSCjkyxs8cNkGEOsYHFlqBjaTqEGuo0Hw/rpExpyCttLiWr s8kSFWt+I0h2Kn34Gry/CI6sGyiJIRfe7V/t6jNsjEHN/aRYxBh/H2SDpE/yvM2u9Z87 gmWVW7xATyihhtU0KkGy/R7QuGRwfIWzcj2TcB+GARTo5AC7PomQHJJqtqGvrVzhzx8c usRssjE6Fba55G9YUiezgED4PoF1jHUzGjqAYaPlDc1FTehfYLFsFK+Kp1lOr3v/cITh kyWLaApC+vsidQOFp5zBQWp+uIu4GOhmYxkLk7jDMkypX2Vw91UGIBXOvsgQ+6HUg+mw MIpw== X-Gm-Message-State: AOJu0YwfnJy6cwVdO3FkGnpjfyGjT3E4/+MNDLOj8IG+TDhi7b0aJe1T PSR0eorfZluy1jwB+KnyhVTKzj48z2A= X-Google-Smtp-Source: AGHT+IEmUYZRMtojWq53hLxwVBFbmQimveCG3RQt1U6NRBuCjMZWF8zRNc8mNxVpB1/XEKXTiPMb2w== X-Received: by 2002:a5d:4c85:0:b0:31d:3669:1c48 with SMTP id z5-20020a5d4c85000000b0031d36691c48mr9117822wrs.7.1694504700733; Tue, 12 Sep 2023 00:45:00 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b14-20020a5d550e000000b0031f34a395e7sm12131542wrv.45.2023.09.12.00.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 00:45:00 -0700 (PDT) From: Simon Tournier To: Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) In-Reply-To: <874jk0jyf2.fsf@wireframe> References: <871qf4ivsr.fsf@gmail.com> <874jk0jyf2.fsf@wireframe> Date: Tue, 12 Sep 2023 09:44:17 +0200 Message-ID: <86cyynygxa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.56 X-Spam-Score: -9.56 X-Migadu-Queue-Id: E32C4451A7 X-Migadu-Scanner: mx2.migadu.com X-TUID: XzCHolUuyycV Hi Vagrant, On Mon, 11 Sep 2023 at 12:35, Vagrant Cascadian wrote: > What about making git an optional dependency, and only calling out to > "git gc" if git is available in PATH? Somehow, that=E2=80=99s more or less the case, IIUC, --8<---------------cut here---------------start------------->8--- 15 candidates: ./build/android-repo.scm:57: (invoke git-repo-command "init" "-u" mani= fest-url "-b" manifest-revision ./build/android-repo.scm:59: (invoke git-repo-command "sync" "-c" "--f= ail-fast" "-v" "-j" ./build/git.scm:55: (invoke git-command "init" "--initial-branch=3Dmai= n") ./build/git.scm:56: (invoke git-command "remote" "add" "origin" url) ./build/git.scm:58: (invoke git-command "checkout" "FETCH_HEAD") ./build/git.scm:62: (invoke git-command "fetch" "origin") ./build/git.scm:63: (invoke git-command "checkout" commit))) ./build/git.scm:66: (invoke git-command "submodule" "update" "--init= " "--recursive") ./git-download.scm:175: (invoke "git" "-C" #$output= "init") ./git-download.scm:176: (invoke "git" "-C" #$output= "config" "--local" ./git-download.scm:178: (invoke "git" "-C" #$output= "config" "--local" ./git-download.scm:180: (invoke "git" "-C" #$output= "add" ".") ./git-download.scm:181: (invoke "git" "-C" #$output= "commit" "-am" "init") ./git-download.scm:182: (invoke "git" "-C" #$output= "read-tree" "--empty") ./git-download.scm:183: (invoke "git" "-C" #$output= "reset" "--hard") --8<---------------cut here---------------end--------------->8--- An =E2=80=9Coptional dependency=E2=80=9D, is it not already the case? I read hard-dependency as the idea behind a change like [1]. For instance, something like: --8<---------------cut here---------------start------------->8--- diff --git a/guix/self.scm b/guix/self.scm index 81a36e007f..41c5f40786 100644 --- a/guix/self.scm +++ b/guix/self.scm @@ -68,6 +68,7 @@ (define %packages ("gzip" . ,(ref 'compression 'gzip)) ("bzip2" . ,(ref 'compression 'bzip2)) ("xz" . ,(ref 'compression 'xz)) + ("git-minimal" . ,(ref 'version-control 'git-minimal)) ("po4a" . ,(ref 'gettext 'po4a)) ("gettext-minimal" . ,(ref 'gettext 'gettext-minimal)) ("gcc-toolchain" . ,(ref 'commencement 'gcc-toolchain)) @@ -825,6 +826,9 @@ (define* (compiled-guix source #:key (define guile-lzma (specification->package "guile-lzma")) + (define git + (specification->package "git-minimal")) + --8<---------------cut here---------------end--------------->8--- In the context of the proposal patch#65866 [1], this hard-dependency makes sense. From my point of view, once we have git-minimal as a hard-dependency, I do not see the point to keep slower Git operations using libgit2; as =E2=80=99commit-relation=E2=80=99 for one example. But maybe I am missing something. Cheers, simon 1: [bug#65866] [PATCH 5/8] build: Add dependency on Git. Ludovic Court=C3=A8s Mon, 11 Sep 2023 16:25:23 +0200 id:4eca94501c2c1e9986e1f718eeccb3eb9276dcd4.1694441831.git.ludo@gnu.org https://issues.guix.gnu.org//65866 https://issues.guix.gnu.org/msgid/4eca94501c2c1e9986e1f718eeccb3eb9276dcd4.= 1694441831.git.ludo@gnu.org https://yhetil.org/guix/4eca94501c2c1e9986e1f718eeccb3eb9276dcd4.1694441831= .git.ludo@gnu.org