From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 389oFjMMSWC5XwAA0tVLHw (envelope-from ) for ; Wed, 10 Mar 2021 18:13:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SO6UETMMSWDpPAAAbx9fmQ (envelope-from ) for ; Wed, 10 Mar 2021 18:13:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 11232153E7 for ; Wed, 10 Mar 2021 19:13:07 +0100 (CET) Received: from localhost ([::1]:35548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK3KU-0004DW-6m for larch@yhetil.org; Wed, 10 Mar 2021 13:13:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK30S-0001Qz-E7 for guix-devel@gnu.org; Wed, 10 Mar 2021 12:52:24 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:38857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK30Q-0001q0-RZ for guix-devel@gnu.org; Wed, 10 Mar 2021 12:52:24 -0500 Received: by mail-wm1-x32b.google.com with SMTP id m20-20020a7bcb940000b029010cab7e5a9fso11600025wmi.3 for ; Wed, 10 Mar 2021 09:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=MWSbKUif8uCI26/Q5WwtcTQf0kerW5dI4Aa4kBgOWK0=; b=MOKhjseqa0/AnOUMkr3O9oEOEeqv5xRsMxxqmm8tlPMJK5884wFWO0uZQWNGzSeCkq 2nZli0yGuOS6NIv6VVnepwpPYimoKQCWkGOOEdCVcmHq+IoNuxP1Buhq0WukI9hJWAmd p+b3OlJn1OmcFAHhQAX0VP8WYP7KO869ujnVO11hEVlHfJbm6pi/qp/Rv3oBZtsXYE1s nj4hYPP93AqoKeDVIq1pFOacyYd7atqPqUG3t/DO5OcBdoP/OHtczBGhpu3xZ0Ycixeb jFy/d4DW60oasxSroPiA+Amnmiq6FfHVPcMlklQ+EC7I1erHuymkr2JPBxliyVamM09L 9ylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=MWSbKUif8uCI26/Q5WwtcTQf0kerW5dI4Aa4kBgOWK0=; b=LKP4S62E9BkZ3/hZikGYHnWOynnvwCdmEANzQYFHVtDu+XvgV/NXA1cCGj/Pa5+d5u jAfckdUAgBtFcjW+x/pl9eTNKRNddbFJHXo2HOV/oZOJa1PAnFhD6OnHFniMPSvrND3X wuPxQW13IqkPWKpiU5y0ygmtFgKvaj1+FpjESTn9JLWXX6ECQ1Ed2bBhAloXhdZt3Zu0 +wQX6VDBprBlgkJNtfsQLrahOT1xQmdJ1dxUFgEXzBV6h8rhCGKDhKvLg4mQhk/ONuuY +C9UEC7eTJa5ZB3C/opT4nFH3Wa3a2aQUbsGw+1WWqWtq23tOxGba5DxJ0MPxm/XZhpp 4tIQ== X-Gm-Message-State: AOAM531p2EGMbJua9Ub3LlUH+Pp53FiGmnVQemYgf/hFuYACVuyMvseu ++bxibLAJjdvyW6YP8buUfAXcjXgeYI= X-Google-Smtp-Source: ABdhPJzUCs3pm1k0Wd0Uqj9370uRL5NDrAkQ21dI6OkTECiWeXgjXuFvGVzEFpLIcq2nR4gBuHGYSQ== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr4549312wmc.9.1615398740806; Wed, 10 Mar 2021 09:52:20 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m10sm211225wmh.13.2021.03.10.09.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 09:52:20 -0800 (PST) From: zimoun To: Leo Famulari Subject: Re: Generate diff with git-diff and use in patches field of packages In-Reply-To: References: <86mtvbcegn.fsf@gmail.com> Date: Wed, 10 Mar 2021 18:49:37 +0100 Message-ID: <86a6radhla.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615399987; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MWSbKUif8uCI26/Q5WwtcTQf0kerW5dI4Aa4kBgOWK0=; b=NdQYWy32tjDoO8BV91l2fwBuyu7cSIGcNKMdrgz5bNkgmQct90eaIrrWROM5AkqtMnxwVo E5Aja1o0Uk66xy7Km818oV7eRkxwo/sk0b2p0IBMdsSbUjrpBgSu0Mdf5uTVOaIF8Nake/ RD0pZ1yJAB/cYrqDu8p7SprBMIkIGf9gYciWr/EthsaOQf2A5+Q3jhyFaLGas9s9D2bfgd 3z2FPSnuN3WBoe/bNYnJyzWtWghe2pk9TaScoVPA2qMDVtqGBO3nli+cDxyLAvyCUsXPvm GQhr56EJd0jb8VBao3RcGOiQ54ITKAwqsIkR18br3W0804HIMo2A9QM0GNZQxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615399987; a=rsa-sha256; cv=none; b=phq9mcPkhrPW/t8KoSBiJm7rXV686OynegWElD8tWiFNe1aalrdxM9JaW3M9WVHrDXyauS 4Olk/Oh5bk0hv9LspRmT5uLyajwaOtxkA19rmTPKlgBRrpDsw20d1uKi61vlQoLVoogHVn 3TtedXx++KYkKDwwGyFIbkpuDkE4kgvJmIkfNjAj+uZyIg3HdI28JluVIhc1MufYvEZWE7 izUBW2ryOQWWc7cPguZBjvOZtU8O03V4Ow8IZ8PGPKECTRGX8TvdvgJu8eTezmjhUtu6YL b3pRULK7u+2ZY04TP22+Bfpoa0dfIZmWJ6nHrUKo4EIPQ8AfwxgJ+rzr0hOMZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MOKhjseq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MOKhjseq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 11232153E7 X-Spam-Score: -1.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: GXHSENSFG8/f Hi Leo, On Wed, 10 Mar 2021 at 12:09, Leo Famulari wrote: > On Wed, Mar 10, 2021 at 02:42:32PM +0100, zimoun wrote: >> If the package already uses git-fetch, why not directly uses the commit >> fixing the issue as source? > > It's different to build from a Git commit vs to cherry-pick a single > commit. I could miss something but I was not suggesting to cherry-pick. :-) Cherry-picking means use the current packaged version and backport to it the commit(s) fixing the issue. I am suggesting to update the packaged version to the upstream version at commit. But maybe it is not possible because the new upstream has changed some API or whatever breaking some dependants. Cheers, simon