From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CGzWKC6cY2T+LQAASxT56A (envelope-from ) for ; Tue, 16 May 2023 17:07:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OGCtKC6cY2TFNAEA9RJhRA (envelope-from ) for ; Tue, 16 May 2023 17:07:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84AD9A8A8 for ; Tue, 16 May 2023 17:07:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pywGa-0001s5-Pm; Tue, 16 May 2023 11:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pywGW-0001p7-AX for guix-patches@gnu.org; Tue, 16 May 2023 11:07:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pywGW-0002pk-2q for guix-patches@gnu.org; Tue, 16 May 2023 11:07:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pywGV-0001tz-Ug for guix-patches@gnu.org; Tue, 16 May 2023 11:07:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63074] [PATCH 2/2] tests: guix-graph.sh: Fix expected path from emacs to libffi. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 May 2023 15:07:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63074@debbugs.gnu.org, dev@jpoiret.xyz X-Debbugs-Original-To: Josselin Poiret via Guix-patches via , Josselin Poiret , 63074@debbugs.gnu.org Received: via spool by 63074-submit@debbugs.gnu.org id=B63074.16842495937192 (code B ref 63074); Tue, 16 May 2023 15:07:03 +0000 Received: (at 63074) by debbugs.gnu.org; 16 May 2023 15:06:33 +0000 Received: from localhost ([127.0.0.1]:46915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pywG1-0001rq-65 for submit@debbugs.gnu.org; Tue, 16 May 2023 11:06:33 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:41188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pywFx-0001qi-U3 for 63074@debbugs.gnu.org; Tue, 16 May 2023 11:06:30 -0400 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3063b921c7eso1931240f8f.0 for <63074@debbugs.gnu.org>; Tue, 16 May 2023 08:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684249583; x=1686841583; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UjJLg4hXB2p4L3rnJ8kxsc9IMamWQASHZ2e/Xk2pcU0=; b=Fhh5246zQKCPAivhVcizii4kj8RPQnkUUF1v26IEyagdJ3VvqMLPRyAXcoec03dPWT kZ9RqMVwDu/4RxX4rpDw3Yoz31V3SibGxN2jpgCRL3eJzbaSXckn4iZfOgMfpfuQ0kE2 6ff91ne6Sw/pIpg1a4R0G2du7/y62gpg82HxxUcCeqGh0LcmiVv/8vQcrWN+W6e7mi5Z QJD5XN4l9dr3mYxaAB5n+gzhndnDKUem4ZfldAlZltH1ULcezMEazKmJ/F2w8oiGj0fX QamoqlXacVEsBQvWBWz6gHlPEgyl5xdPAaV3s170EKGK8YeSVIwojNrO6K2tL5llR90v bOXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684249583; x=1686841583; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UjJLg4hXB2p4L3rnJ8kxsc9IMamWQASHZ2e/Xk2pcU0=; b=XO7WtpXw39PR7Qu5ROScCTCg6FYi/UsB2cRsAyy/PaCCep5To2LO1rEjGVUgEanYr0 DMkxA+5e1D+zcNoxAfMAdBuAbewdLAfrwjUwtxzsyojvzcp66+bjHpAbfYJ6EaRy4Gqj rzwXbVMo2nkRpxpIhTcjk3JoPTJK2wpVZRUSEvwmr5qOfd0hQowKyEXJqid6wMWVmHKB JDGijsK95bX9Y8m1L39kXAai7lpaXqzMjbg0GR1e1XOM/DU0nZbO/V06kjijlR8aX+vK ee+VHt7Xex+Rd3ysig6d61GpWbUu1BTemWTrVKJdbsA6x8ZBgvaR7y2CDf+Nc6vc3K/t zyOg== X-Gm-Message-State: AC+VfDy4Vs8OT+6Npw36VQkt7l3qUxa/pHkpvxhSHk8FB6ejJc0dGMpa VlQDfzW2NmrQM7dGbUwKr4/yFXpSEak= X-Google-Smtp-Source: ACHHUZ5UMut15RypKJakep0mz8J6v5fblYqbOJrgczWu2e8okxeiluokBs09qR4nxF0FwVZc4CPr+w== X-Received: by 2002:adf:ec4c:0:b0:2f9:12ae:4a29 with SMTP id w12-20020adfec4c000000b002f912ae4a29mr2047663wrn.5.1684249583091; Tue, 16 May 2023 08:06:23 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id d3-20020adff2c3000000b0030629536e64sm2902496wrp.30.2023.05.16.08.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 08:06:22 -0700 (PDT) From: Simon Tournier In-Reply-To: <17cedc45c05d54f39d47bac3bbcd51a2ebae5a39.1682452738.git.dev@jpoiret.xyz> References: <17cedc45c05d54f39d47bac3bbcd51a2ebae5a39.1682452738.git.dev@jpoiret.xyz> Date: Tue, 16 May 2023 14:57:05 +0200 Message-ID: <868rdo77tq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684249646; a=rsa-sha256; cv=none; b=NO09jsU27OV9fDXlOUPOgr25DfgI3vO0hXrGblnaWBhtbcDyzXvdufChwvtWl10le9vK/8 2mq8qxFLiqSTeNVRw4JYQFDyHGnXoctc6t7jV3ujh/4txflqqwQtyuzayE7ItzNzBRJ7Zh q03WGbE2Dpc3uQBoXn7D4iYLUI3Ljmxae5rLEKiTrptMCkRE7bZhAUfnCO9wICX8HnzIel BKp9r/AhRrgPN54M150kLoAcfdkQMFHBJQYWj0u9/c/bvbPba+szsl3nZ/u31k+7eNYNVZ ic5Xej+cc6YEjN1wujEnKKlkmuFo9+enXaM9qF4HMufhE41ELNpvjCz3F8/eFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Fhh5246z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684249646; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UjJLg4hXB2p4L3rnJ8kxsc9IMamWQASHZ2e/Xk2pcU0=; b=ZtgejeccyBXwFE0z6YftnBmJW3Px63U2487x9pNrdYU0XHisaoXiQ34iHBOXDBotaSHkTi uy/QNXO2kHiJSGt7y2pdjYMJ1ZLYwc0+QRAfU27Ex9nMfS8tSn8278elWauP7tLw8PWzKV IOQpYUDaLho3J9clPMqIOU/XwRUgbYs7x2eH5gYHzL8QSaGlN0NKrP1Yci3Zk9IGVqoxhR Sq0BGWQ0w/FPPDyDlN6uPkwU0ZJNirUAuIp5ZD5B/DeDlBd+3/RwCiCwSQ6XgMa6p7pYxu jb9CM9rvuXnHwhgTcrn/DBcOvFSHQsXbVtmA4EFhDNSWsw2rVLQl9XricGqa2Q== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Fhh5246z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.81 X-Spam-Score: 5.81 X-Migadu-Queue-Id: 84AD9A8A8 X-TUID: tq5m9lZR5Ttb Hi Josselin, On Tue, 25 Apr 2023 at 22:16, Josselin Poiret via Guix-patches via wrote: > * tests/guix-graph.sh: Change the expected path from emacs to libffi. `g= uix > graph --path` outputs only one possible path, and the one it outputs for = this > case has changed. > --- > tests/guix-graph.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/guix-graph.sh b/tests/guix-graph.sh > index 9824c6a65a..37ea0a7b8c 100644 > --- a/tests/guix-graph.sh > +++ b/tests/guix-graph.sh > @@ -87,7 +87,7 @@ guix graph --path emacs vim && false > path=3D"\ > emacs > gnutls > -guile > +p11-kit > libffi" > test "`guix graph --path emacs libffi | cut -d '@' -f1`" =3D "$path" Hum, that=E2=80=99s annoying. Well, indeed =E2=80=9Cguix graph --path=E2= =80=9D returns one of the shortest paths. And this result depends on how the graph is built and then walked. That=E2=80=99s deterministic (should be!) but can depend = on the Guix revision. Well, does it make sense to check the equality of such specific path? Maybe, instead the test could check some invariant property. For instance, that the length of the path between two packages must be the same as between the same packages but with a package transformation (replacement or else). Or some others. For example, that the length from A to C is equal to the length from A to B added to the length from B to C. WDYT? Cheers, simon