From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oJr3DpZ4ImAjaAAA0tVLHw (envelope-from ) for ; Tue, 09 Feb 2021 11:57:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QLjjCpZ4ImARBwAA1q6Kng (envelope-from ) for ; Tue, 09 Feb 2021 11:57:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F07549404E6 for ; Tue, 9 Feb 2021 11:57:09 +0000 (UTC) Received: from localhost ([::1]:33466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Rdk-0004hE-WD for larch@yhetil.org; Tue, 09 Feb 2021 06:57:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Rde-0004h1-N4 for guix-patches@gnu.org; Tue, 09 Feb 2021 06:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Rde-0006Rr-GJ for guix-patches@gnu.org; Tue, 09 Feb 2021 06:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Rde-0002UY-ED for guix-patches@gnu.org; Tue, 09 Feb 2021 06:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1) Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Feb 2021 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46376 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 46376@debbugs.gnu.org Received: via spool by 46376-submit@debbugs.gnu.org id=B46376.16128718089557 (code B ref 46376); Tue, 09 Feb 2021 11:57:02 +0000 Received: (at 46376) by debbugs.gnu.org; 9 Feb 2021 11:56:48 +0000 Received: from localhost ([127.0.0.1]:52802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9RdQ-0002U5-2L for submit@debbugs.gnu.org; Tue, 09 Feb 2021 06:56:48 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:56290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9RdN-0002Tv-Qt for 46376@debbugs.gnu.org; Tue, 09 Feb 2021 06:56:47 -0500 From: Jelle Licht In-Reply-To: References: <86a6sep7h0.fsf@posteo.net> Date: Tue, 09 Feb 2021 12:56:42 +0100 Message-ID: <867dnhpi85.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.26 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (strict), No valid DKIM" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F07549404E6 X-Spam-Score: -2.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: qLEv/IzKlpXj Hello Andy, I have some additional questions about your updated patch. Andy Tai writes: > updated patch attached >> > - (file-name (git-file-name name version)) >> > + (commit commit) >> > + ;; Fetch git submodules >> > + (recursive? #t))) >> >> Instead of stating what the code does, would you consider adding a >> comment why this is needed? >> > > commented as suggested I was unclear in my message: Of course there are some submodules that are being fetched; why should we fetch them in the first place? From a cursory glance, they seem required to do stuff such as running the tests, which in this iteration of the patch are not being run. FWIW, leaving out the `recursive? #t' still allows me to build tesseract-ocr: could you try and see if it makes a difference in your use of tesseract? >> > (inputs >> > - `(("leptonica" ,leptonica))) >> > + `( ("cairo" ,cairo) >> > + ("icu" ,icu4c) >> > + ("leptonica" ,leptonica) >> > + ("pango" ,pango))) I just built the package: no references are made to cairo, icu4c and pango, and tesseract seems to build fine without them: is there a specific reason why these were added to the inputs? >> > + (native-inputs >> > + `(("autoconf" ,autoconf) >> > + ("autoconf-archive" ,autoconf-archive) >> > + ("automake" ,automake) >> > + ("googletest" ,googletest) >> > + ("libtool" ,libtool) >> > + ("pkg-config" ,pkg-config))) >> > (arguments >> > '(#:configure-flags >> > (let ((leptonica (assoc-ref %build-inputs "leptonica"))) >> > - (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include"))))) >> > + (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include"))) >> > + ;; some test, applybox_test fails to build >> > + #:tests? #f)) >> 2 nits: Is it possible to patch or disable only the failing tests? > > tests failing to build probably due to some issue with parallel > builds; did not dig into it as probably will take much time; will be > TODO if time allows) I'll defer to someone with more experience with tesseract, as I have no experience to speak of on whether this leads to us having a (subtly) broken package. Adding the following arguments might help to validate your assumption: `#:make-flags (list "-j" "1")'. Thanks, - Jelle