From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UNvWL9V2XWC5FgAAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 06:53:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YArQKdV2XWApWQAA1q6Kng (envelope-from ) for ; Fri, 26 Mar 2021 05:53:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EECC2014B for ; Fri, 26 Mar 2021 06:53:25 +0100 (CET) Received: from localhost ([::1]:40046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPfPQ-0003m0-3T for larch@yhetil.org; Fri, 26 Mar 2021 01:53:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPfMB-00012x-GZ for guix-patches@gnu.org; Fri, 26 Mar 2021 01:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPfM9-0006SZ-PM for guix-patches@gnu.org; Fri, 26 Mar 2021 01:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPfM9-0007BO-NL for guix-patches@gnu.org; Fri, 26 Mar 2021 01:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Mar 2021 05:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43946@debbugs.gnu.org Received: via spool by 43946-submit@debbugs.gnu.org id=B43946.161673774327539 (code B ref 43946); Fri, 26 Mar 2021 05:50:01 +0000 Received: (at 43946) by debbugs.gnu.org; 26 Mar 2021 05:49:03 +0000 Received: from localhost ([127.0.0.1]:40157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPfLD-0007A6-1u for submit@debbugs.gnu.org; Fri, 26 Mar 2021 01:49:03 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:42967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPfLB-00079c-NS for 43946@debbugs.gnu.org; Fri, 26 Mar 2021 01:49:02 -0400 Received: by mail-wr1-f50.google.com with SMTP id x13so4435053wrs.9 for <43946@debbugs.gnu.org>; Thu, 25 Mar 2021 22:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=TkTU12trXelzpvCPBaM6DhGoOcXdIikjkN1vd1E7yN4=; b=ZCf6k1zIIpyhD+ynKlmJr+qBKbjo0YcewkHHDPhl31U28k3UHj3kUCWuihj9PyZ3eJ KtdVhBE9ckVyCKhzLh4dRMO+ecQIOOBL1lYzFkPqux8EYZTXemt2gjptmNmVT3bzCVZQ e+DrDETa71VEPbP1VyrAUDZVIpLyGCvbUSBTixG/+Ak5nxYW93mxzBncSLz2Fh8P9P2Y CAdyNPUajKptEpSqf1LXAZHDb+NKGOCMWEb0IsMJ1AV2MaqiiZZ3kqKgrI1XojKHY8+w q0Xoj3frBMe0GvKXJWY/6Y1G9BHPUCd94QVEfwchh1E7UPWIbRbMQEygyO5qsFDCqpSr AF+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=TkTU12trXelzpvCPBaM6DhGoOcXdIikjkN1vd1E7yN4=; b=BjckMLflbvWTxTgQeoPFzJto701HDQK8B0evFqAg6pzIyms/i2ieGKng3wGnggziiY lmRQlS+jhDGXLnG9pHiqELcVcKKFc9OJad1NlkOi6miklFwtL7rrKhRBc10daQTgx4XN S+3zefP9Aa2dwx9w1ihx0bVVgHnPqeoLcycgla29hIZohACcU+CVH1nqFmjN/eRjMJnN QQ//utwFUdSYffW50jrIMC/UeZ8spIceaCVh1IjsOwqnc7L9N/p/nJpjYSdyqVpml/M6 6m44ZONzUcve/2TZZ2S6ZwxckfZqHWm1JCNRS/FKZV9Y1hXvjvdNDceK3RC9hi1b9Oid ZhoQ== X-Gm-Message-State: AOAM533ye48rgz8jmeAjlWms7RP2D9ybGAetZNTRxzdIkp2yjUfZkr/7 q9ym84f+Yuev1y1noNJWTjOoDunn/JU= X-Google-Smtp-Source: ABdhPJywJUtk7JVN1onwtzGfD0qUnSfbOFogUNx+jt6uMoSXmYQ4DD/RschEZD8kdboVGK7g3k1G0w== X-Received: by 2002:adf:8151:: with SMTP id 75mr12504390wrm.152.1616737735726; Thu, 25 Mar 2021 22:48:55 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id p17sm8667754wmd.42.2021.03.25.22.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 22:48:55 -0700 (PDT) From: zimoun References: <20201012082003.19936-1-zimon.toutoune@gmail.com> <87zh1axr7c.fsf@gnu.org> Date: Fri, 26 Mar 2021 06:40:29 +0100 In-Reply-To: (zimoun's message of "Fri, 15 Jan 2021 15:00:20 +0100") Message-ID: <867dlucw1e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616738005; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TkTU12trXelzpvCPBaM6DhGoOcXdIikjkN1vd1E7yN4=; b=KeINvxjNH+tkBiu5Gm35Cb6ZnH31NuuFsaLGm8dp375WCO3GN3mDnCTsBHpAzPyuOPhl6Q 5n6kce5fKfQcVM9+rputyeK4zrcxfiFeuy2MC80JKZeaHm9p0pASS2p6pAiI9q1/X8QKn3 NqFTWZRQouMcuxrEVNfThTMpD0Pl/L6spvPWvsOXVl1+pCzbjfjIAI/VASUPy3nIvJBKAo 2SMXz5JecRxMmP20HPIu5aquvPmLvMnp0vPShhYbrWa3aQAg362cCwRZp/fDLNT0IwCCVD GMn0nqdwjChdeAyo9Xu2JResvEwexSN+3XqgmJeIR4Ygo2UuXzdLLuSg08ebUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616738005; a=rsa-sha256; cv=none; b=Omn3yENIODu6VFcvdVm3+thEhKAWeQhkZ9b798WQTVJiyRUvtu6dKyb3TEZ/A1Gx+7jnUZ MoNiXkreM+25Nnaw5xxZSLmnPel6asWd0ioq9Rxlg9ghmvGf8aBMErSqrbVmekwM67iUnj pwsau/N86rt7kMa7eybrgYmxbhnn+YBVnbjh36jmPF9i9yunfd1aTdBHH3zaruqQZ9IOGq YFdBMQqDmpzgAtOg5SkNBXhj2piC9G+qpdzVOFRCF4H33LJ6dE18Koe+DlWnpUVTsu9HUx hhtIGQ7m8WVhwgQdQjkMPQcCCTKv4AaBY+gO+k9MZJZVjr7hj5uFheF9EqN6Rg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZCf6k1zI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZCf6k1zI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3EECC2014B X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: c4lXs9wUf8wv Hi Ludo, On Fri, 15 Jan 2021 at 15:00, zimoun wrote: > On Fri, 15 Jan 2021 at 14:30, Ludovic Court=C3=A8s wrote: > >> > +We recommend to use the command @code{git format-patch --base} to >> > +include the commit where your patch applies. >> >> I=E2=80=99m not entirely convinced TBH, in part because I know I often p= ile a >> couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2= =80=99m doing=E2=80=9D >> (actually hoping that I do), and so the base commit would be useless in >> this case. [...] >> Closing? :-) > > As you want. :-) > But, I think "qui peut le plus peut le moins". Even if maybe my > wording is not the good one, I still think that the "base-commit" > where the patch applies should be provided, at least suggested. I still think that recommending to provide the commit on which it is known that the patch (or patch set) applies is a good recommendation. Especially when the submission rate is greater than the review rate and the tree is moving really quickly (yeah!). It is no extra work for the submitter and really helps for the reviewer. They applies at base-commit, checks, rebases and resolves conflicts if they are. Otherwise, the patch is useless or it needs to be rewritten by hand (or please indicate me how to do :-)). BTW, it helps automation tools. Sometimes, this base-commit is useless for the reviewer workflow but having it does not interfere. Having an information does not mean it must be used. However, not having an information implies it cannot be used. ;-) Cheers, simon