From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSexl-00060T-JQ
	for guix-patches@gnu.org; Wed, 05 Jul 2017 03:43:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSexi-0002ox-GZ
	for guix-patches@gnu.org; Wed, 05 Jul 2017 03:43:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50191)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dSexi-0002oq-DV
	for guix-patches@gnu.org; Wed, 05 Jul 2017 03:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSexi-0005ZI-7R
	for guix-patches@gnu.org; Wed, 05 Jul 2017 03:43:02 -0400
Subject: [bug#27550] [PATCH 0/2] cuirass: Prepare (guix git) integration.
Resent-Message-ID: <handler.27550.B27550.149924053721354@debbugs.gnu.org>
References: <20170701150043.14654-1-m.othacehe@gmail.com>
	<87inj9pvvf.fsf@gnu.org> <868tk5ogwe.fsf@gmail.com>
	<867ezpocf4.fsf@gmail.com> <87o9szsxai.fsf@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87o9szsxai.fsf@gnu.org>
Date: Wed, 05 Jul 2017 09:42:13 +0200
Message-ID: <864lurnxd6.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27550@debbugs.gnu.org


Hi Ludo,

> Looks nice!

Thanks :)

> Leftover ‘pk’.  :-)

Oops !

>
> Maybe s/store-dir/checkout/ for clarity.
>
> Please add a check for (guix git) in configure.ac.

Ok.

>
> Now there are ‘git-error’ exception that can be thrown from there.
> Should the ‘cuirass’ program catch them, report them on stderr, and keep
> going?  Maybe we can ignore that for now (throwing is better than
> silently ignoring Git problems anyway.)

Maybe we can ignore them for now, and when guile-git will support
git-error integer error code -> string conversion, we can report them
and keep going as you suggested ?

Mathieu