From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GFn/BzMYUWE3dAEAgWs5BA (envelope-from ) for ; Mon, 27 Sep 2021 03:02:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EE6jAzMYUWHjWgAAB5/wlQ (envelope-from ) for ; Mon, 27 Sep 2021 01:02:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81D9E848B for ; Mon, 27 Sep 2021 03:02:42 +0200 (CEST) Received: from localhost ([::1]:48992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUf2X-0007N7-61 for larch@yhetil.org; Sun, 26 Sep 2021 21:02:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUf1v-0007Kl-AY for guix-patches@gnu.org; Sun, 26 Sep 2021 21:02:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUf1u-0003qa-PR for guix-patches@gnu.org; Sun, 26 Sep 2021 21:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUf1u-0000P1-Kb for guix-patches@gnu.org; Sun, 26 Sep 2021 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50833] [PATCH] gnu: Add bower. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Sep 2021 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50833 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: jgart Cc: 50833@debbugs.gnu.org Received: via spool by 50833-submit@debbugs.gnu.org id=B50833.16327044871462 (code B ref 50833); Mon, 27 Sep 2021 01:02:02 +0000 Received: (at 50833) by debbugs.gnu.org; 27 Sep 2021 01:01:27 +0000 Received: from localhost ([127.0.0.1]:39086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUf1K-0000NW-NJ for submit@debbugs.gnu.org; Sun, 26 Sep 2021 21:01:27 -0400 Received: from out0.migadu.com ([94.23.1.103]:61380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUf1H-0000NM-RQ for 50833@debbugs.gnu.org; Sun, 26 Sep 2021 21:01:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632704481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g49/DGx1/Qm3Njdb2Axzug4di3PizzJbpfmjLoQiWg0=; b=Lm2FHG1EKzawWdOkRI4Vtrv2LlGWmJb8fQWmdxcrgSz9yZeCuM5MoRNFMB6vwUWGROHP9J ht+AnA5OlSM5tpTgd2wTbElJ+q43HiJ1dXY9N+cwWVTCK3jcHSGFQp8R/tg9ey354JNRQc F4W8W/p0PR16NJCDuxvyvNaN4vG0TFE= From: Sarah Morgensen References: <20210926190836.GB8410@gac.attlocal.net> <20210926231145.18651-1-jgart@dismail.de> Date: Sun, 26 Sep 2021 18:01:20 -0700 In-Reply-To: <20210926231145.18651-1-jgart@dismail.de> (jgart@dismail.de's message of "Sun, 26 Sep 2021 19:11:45 -0400 (1 hour, 17 minutes, 31 seconds ago)") Message-ID: <864ka6vnkv.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632704562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=g49/DGx1/Qm3Njdb2Axzug4di3PizzJbpfmjLoQiWg0=; b=t8Jd2uasPex8E0EmWH0avcaew5G9bl6Po73MpC6TvI7Fc5Ov5iVU9xLYVbhQz+M3V2w4uB t9Z5EWQNrXXTcj3x2Az5SUDfhfHyEPuYgPjTpy3tc/MTu+5Hhg+uJ8sFkIzJjZZKaXv+3F 44xeA/HkVAAyq5rfwFdX5bFUbxYK7jV5WXN4xvZVQDQG7SAv9Hq/R90QkleiSCdD7SSUas waj8vi+d3q8ubsKxBOsEitaWonR7w01R3g5OoN0zIgwWuGcMnIJanhYmiLLW4RtqDzDN9n rHm28p9b5/I31PR4P/t40pi0B3d22AsBD+M4lev74OOurJ6U5WRLuDZnXgeVuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632704562; a=rsa-sha256; cv=none; b=X5Y3iUz3n1dnY/Jplkj9Yc6YBhFN9a2wffO5wIMpIxwbwdIKNqtTOor7h1dXCGJ1C4k1GX fvC1vzmLjTXMjpnxJuodp94IA1s9nWhBVdMPJLCfuH3fqstrZb9NylyZrQVSZSL+GRd899 bk9E3uN99jI/hkLi9DJUql/5epk3xAeNz54jmeDr3kdpe8oN5WivE1jKCUMDdA34qKvW9N 2tVTNw39g+SQVQAWn3UrgvqvN/Z4UmDJN+UxU9JjaqcrAsMq7fpKCIaDf24S8Mpj2iNRjk rHleCyjoP+TUeWetmgTVNUTYGK7CGfok0+a6aq0JzdO9TD/ckA6GncOjL2JEjA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Lm2FHG1E; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.79 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Lm2FHG1E; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 81D9E848B X-Spam-Score: -1.79 X-Migadu-Scanner: scn1.migadu.com X-TUID: WsUvhuT3uzg6 Hi, Thanks for the patch. I don't use notmuch (yet) but I test-built this and I have a few suggestions :) jgart writes: > * gnu/packages/mail.scm (bower): New variable. > --- > gnu/packages/mail.scm | 54 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm > index b3bdf13537..f0624c12c4 100644 > --- a/gnu/packages/mail.scm > +++ b/gnu/packages/mail.scm > @@ -87,6 +87,7 @@ > #:use-module (gnu packages file) > #:use-module (gnu packages fontutils) > #:use-module (gnu packages freedesktop) > + #:use-module (gnu packages gawk) > #:use-module (gnu packages gdb) > #:use-module (gnu packages gettext) > #:use-module (gnu packages ghostscript) > @@ -114,6 +115,7 @@ > #:use-module (gnu packages lua) > #:use-module (gnu packages m4) > #:use-module (gnu packages man) > + #:use-module (gnu packages mercury) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages nettle) > #:use-module (gnu packages networking) > @@ -1302,6 +1304,58 @@ agent (@dfn{MUA}) experience as an alternative to the Emacs mode shipped with > Notmuch.") > (license license:gpl3+))) > > +(define-public bower > + (package > + (name "bower") > + (version "0.13") > + (home-page "https://github.com/wangp/bower") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url home-page) > + (commit (string-append version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0r5s16pc3ym5nd33lv9ljv1p1gpb7yysrdni4g7w7yvjrnwk35l6")))) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags > + (list > + "bower" "man" > + (string-append "CC=" ,(cc-for-target)) > + (string-append "prefix=" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'check > + (lambda* (#:key inputs outputs tests? #:allow-other-keys) > + (when tests? > + (chdir "tests") > + (invoke "make")))) Rather than chdir, you can just (invoke "make" "-C" "tests") or maybe even avoid the custom phase with test-target: #:test-target "--directory=tests" (Yes, it's a bit of a cheat, but test-target is just passed as the first argument to make, and we want the default target anyway, so it works.) > + (replace 'install > + (lambda* (#:key outpus #:allow-other-keys) > + (let ((bin (string-append (assoc-ref %outputs "out") "/bin")) > + (man (string-append (assoc-ref %outputs "out") "/share/man/man1"))) > + (chdir "..") > + (install-file "bower" bin) > + (install-file "bower.1" man))))))) It might be helpful to also install bower.conf.sample to "/share/bower", so we have an example config file. > + (native-inputs > + `(("diffutils" ,diffutils) ; needed for diff command > + ("gawk" ,gawk) > + ("mercury" ,mercury) > + ("pandoc" ,pandoc) > + ("util-linux" ,util-linux))) ; needed by rev command for test_process.m > + (inputs > + `(("gpgme" ,gpgme) > + ("ncurses" ,ncurses))) The README says that it also uses "base64" from coreutils, "file", and optionally "lynx"; a grep through the source shows the following commands used (some of them are just defaults): base64 file vi (used if EDITOR is not set) lynx (used for formatting HTML messages) xdg-open (used for opening links and MIME parts) xclip pandoc (used for composing multipart/alternative messages) /usr/bin/sendmail Other than "base64" and "file" I'm not sure which (if any) of these should be directly linked. "/usr/bin/sendmail" should be "sendmail" if it's not linked, though. "xdg-open" and "xclip" aren't available from my PATH, but they are configurable in bower.conf, so... yeah, I'm not sure. Just know that without changing the bower.conf value or installing "xdg-open", links won't open automatically. Same for the clipboard and reading/composing HTML messages. If it's not possible to 'substitute*' those values, 'wrap-program' could be used to add the correct directories to PATH, but that can introduce other issues. > + (synopsis "Terminal client for the notmuch email system") > + (description > +"@command{bower} is a curses frontend for the notmuch email system. > +@command{bower} is written in mercury.") Could you expand the description a bit, perhaps with some of the features you quoted in your first email? It also seems that configurability (seen above) is another of its draws, so maybe mention that as well :) (Also, in my opinion "written in X" isn't relevant for end-user packages, but I know others who would disagree, so...) > + (license license:gpl3+))) > + > (define-public notifymuch > (let > ((commit "9d4aaf54599282ce80643b38195ff501120807f0") Thanks again for your work! -- Sarah