From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kAOTBnvmNGIfngAAgWs5BA (envelope-from ) for ; Fri, 18 Mar 2022 21:07:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6OCIOnrmNGLqMwAAG6o9tA (envelope-from ) for ; Fri, 18 Mar 2022 21:07:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D1FA1C679 for ; Fri, 18 Mar 2022 21:07:22 +0100 (CET) Received: from localhost ([::1]:34700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVIsa-0000B8-Ru for larch@yhetil.org; Fri, 18 Mar 2022 16:07:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVIsI-0000AV-8V for guix-patches@gnu.org; Fri, 18 Mar 2022 16:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVIsH-0000zk-NW for guix-patches@gnu.org; Fri, 18 Mar 2022 16:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVIsH-0001cd-Im for guix-patches@gnu.org; Fri, 18 Mar 2022 16:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] What is the process from here? Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Mar 2022 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: fesoj000 , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.16476339916194 (code B ref 54309); Fri, 18 Mar 2022 20:07:01 +0000 Received: (at 54309) by debbugs.gnu.org; 18 Mar 2022 20:06:31 +0000 Received: from localhost ([127.0.0.1]:58455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVIrn-0001bq-0M for submit@debbugs.gnu.org; Fri, 18 Mar 2022 16:06:31 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:41855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVIrl-0001bb-ET for 54309@debbugs.gnu.org; Fri, 18 Mar 2022 16:06:29 -0400 Received: by mail-ej1-f65.google.com with SMTP id a8so19058909ejc.8 for <54309@debbugs.gnu.org>; Fri, 18 Mar 2022 13:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=sTKMryypjHqdiXMwe30f8v+J4k9SujErMCFD0o5urT0=; b=NPCQXCyYqGlOA9Gb66o1hl5geT9BCaMqWPx2w8T7FE5CwL7p6zUPoWxoCBp8pQj8ZP xnjTaIOENJylrF7wA1BE6rO6yd+YitOfl/t/JJSmYaUE7GuGQDxcbkqpn0xVHRNCMj8o IW23lJv2zCU9NZjosNg/pPLwi04QoyX1WmDxbmI/6A6YnbbYVOF5SsyQXlNdY5B7rVDy WF12VLbRZawtayaX87a6uK3lOr+dTLwbwZR5HBRftk7nr8TSI/1jI8KbwhUtGO9eI78P dmRrw1FmjI8cEl67sXnBeiNagYLImaU3KZpkM1ivAjQXc4z6aSvfoq+7M9QnzQprgisB Mdyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=sTKMryypjHqdiXMwe30f8v+J4k9SujErMCFD0o5urT0=; b=H98+iPmoABhrNW+NsLgrsxXHoNdIpoODs6G8YnI0e7OUlgq5voQztbTcv1e9rPnIdG 11AIGdvBV71F3N/SITQctyY2MNUENtKAo59TIYlcRTosGiOdK/2aE/WQGwgLSczm7Cxz c2nhCN/uEsVlV4DfbX+DqoN/TA3lFODWzNqy6IlwmwWEpxRZTVr5cG00G15suZnq/W82 EwDwotcXBCnin5G9NBqeAStHe8brAZ3aHnPQh/Sxdgf47UUPlZcOQfvEqbyFMOgfX82D fVefuQqUb1hcCYRmHcSyre+kB9CeCsA4JiV9MMQKSm1wZ4i+znoOSP0s3qwJO6ZdHZle ilkA== X-Gm-Message-State: AOAM530j3gh0PNNnedcTDkaccurTYCBIyYADDC0yJW+RsR01iTev09aK YshGO94zSkTnjrwp5EX/6K4= X-Google-Smtp-Source: ABdhPJwkQ4eB+H8IsdelzddpZFikJl2Jfe5KvSBvm1eKQJpVwrTztsd7w0bVkLx7L6cViaudyGoe+Q== X-Received: by 2002:a17:907:3d8c:b0:6df:4bdc:a282 with SMTP id he12-20020a1709073d8c00b006df4bdca282mr10693052ejc.464.1647633983491; Fri, 18 Mar 2022 13:06:23 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h21-20020a170906829500b006cef3dcd067sm4036997ejx.174.2022.03.18.13.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 13:06:22 -0700 (PDT) Message-ID: <8640c4e7b1a46e76ea4df8c21a290d1aa72de0d8.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 18 Mar 2022 21:06:21 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647634042; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sTKMryypjHqdiXMwe30f8v+J4k9SujErMCFD0o5urT0=; b=a5PLoqOrOBFv4R5uyZV5/PFbpT0uprxVYZhWaatbfAi6f5X70yILCxscZ/WiZXb8hhNDl5 Ueljg77lJumzqSYOLpjyrY3qByNkO75vx+Xz8O/g46kOQb5LgpKXdP/L8Vg3Y7gnJV6wRl MzhM13PgYLa+N7KoQQTI4PWq8AqzvnF1AziVTZJh7XIXyI8o+kLdmq8/dUZjcsjxMoF87f kHMRej70YjeoaAKn0YhVY/OI4XyrtlLlZK+mmbmavRSxLge1oKjU6lej9T1uj4eXLlcJwK nKF0DY2Gj7yvqbsdaVLOwcDMnIAUXuxgZyUNX1ccZ2NGdMK7GKkUv6RM23x4KA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647634042; a=rsa-sha256; cv=none; b=H5y2V5FQIQi6a7XakylaYGmL8Lzn8CYxflGy7ULx1bmr2dxMU+m2eJgolodaFmMhlaQiN/ y1heY96mpqyrPjV36VaqaObEerly5w/a6w8WXRqj697X/bZz5djCwEbkDpXlr+uNCEUJfK fsVEH14q4lBnzg3c17U5LQr/b9kNxQO06pILfpVEG0o4lMAVkgJ1tCdxdymc0QkTsHv0HE Z8K887S9pX9OMCyDiWIoRqT3hfeN+Z06w+O93r6UwwPpSfUD5MuSicEWqZOq7UlOjAt3yK CzC5F64TxJuBbBYv0us0rty74VJjUefyhNbDVYbac8rO7XimoQnyUygM85N27Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NPCQXCyY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NPCQXCyY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9D1FA1C679 X-Spam-Score: 6.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: yijjqbMP/EwC Hi, Am Freitag, dem 18.03.2022 um 20:17 +0100 schrieb fesoj000: > Hi there, > > i don't think this is the right spot to ask this, but i am not sure > where else i could ask this. > > What is the patch acceptance process? I am wondering, what are steps > from patch to commit? I have quite some packages, services and other > patches laying around in varying quality. I recently started > cleaning them up. I plan to get them integrated into master at some > point. In general it's send a patch, wait for review (this might take some time), argue with the reviewer, reluctantly send v2, v3, ... until your patch passes the quality criteria, gets stamped and arrives upstream via avian carrier. > So, i assume that there has to be interest and time from a guix > developer to review, maybe test and then integrate the > changes/packages into one of the branches. Note that there have already been two people reviewing; you currently owe me a v2 addressing the TOCTOU "race" of creating the audit directory without 700 permissions. > Is there something i can do to help the process along? Maybe we > could use this very patch as an example. Currently i am uncertain if > this patch is appropriate for master, because of the risk that > changing the auditd default log directory might break some setups. > This could be 'fixed' by writing a news snippet. But i > am not sure. Or is there still something else missing? In general, you should read the reviews carefully, reflect on them, implement suggested changes (or come up with better alternative solutions) and resend the patches with said changes; rinse and repeat until you hear a "LGTM". If the reviewer in question is a committer, you might hear a "Thanks, pushed" instead. As a rule of thumb, others will rarely actively fix up your code and if they do it's mostly minor things. Any work more than that takes them away from other review or their own submissions. Cheers