From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26652@debbugs.gnu.org
Subject: bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option.
Date: Thu, 04 May 2017 13:46:47 +0200 [thread overview]
Message-ID: <8637ck6dzs.fsf@gmail.com> (raw)
In-Reply-To: <87r305r9kn.fsf@gnu.org>
Hi Ludo,
Thanks for the review :)
>> (display (_ "
>> + -m, --manifest=FILE select all the packages in FILE manifest"))
>
> “select all the package from the manifest in FILE” maybe?
Ok.
> Also, maybe s/get-manifest-packages/packages-from-manifest/, because
> ‘get-’ is quite unusual. :-)
Seems better !
>
>> + (packages
>> + (or manifest-packages args-packages)))
>
> Maybe (append (match (assoc-ref opts 'manifest)
> (#f '())
> ((? string? file) (packages-from-manifest file)))
> args-packages)
Mmh, I dont think we want to append manifest packages and args-packages.
We want only manifest packages if a manifest is specified IMO.
>
> ?
>
> Could you also update guix.texi to mention this option and the intended
> use case?
Sure.
I sent an updated patch taking your remarks into account.
Mathieu
next prev parent reply other threads:[~2017-05-04 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 12:58 bug#26652: [PATCH 0/2] fresh: add -m manifest option Mathieu Othacehe
2017-04-25 13:00 ` bug#26652: [PATCH 1/2] profiles: Add manifest->packages Mathieu Othacehe
2017-04-25 13:00 ` bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option Mathieu Othacehe
2017-05-03 20:04 ` Ludovic Courtès
2017-05-04 11:46 ` Mathieu Othacehe [this message]
2017-04-25 16:47 ` bug#26652: [PATCH 1/2] profiles: Add manifest->packages Maxim Cournoyer
2017-04-25 17:00 ` Mathieu Othacehe
2017-04-25 18:50 ` Maxim Cournoyer
2017-05-03 19:59 ` Ludovic Courtès
2017-05-04 10:22 ` bug#26652: [PATCH] scripts: refresh: Add -m manifest option Mathieu Othacehe
2017-06-02 16:35 ` Ludovic Courtès
2017-06-04 7:09 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8637ck6dzs.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=26652@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.