all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Data Services: use cases
Date: Tue, 17 Nov 2020 22:43:06 +0100	[thread overview]
Message-ID: <863617oe1h.fsf@gmail.com> (raw)
In-Reply-To: <86o8jxorky.fsf@gmail.com>

Hi Chris

>> Service will store when the branch was updated (it uses the date of the
>> email as a proxy for this).
>
> Now, after this discussion, I am not convinced anymore that the email
> header date is the right thing because we (user) do not have this
> information when debugging locally; only the Git checkout.  Anyway.

Just another example to show the issues about the dates.  Let’s give a
look at Gmsh (which I know a bit).

From this page (not matter the failure, which is another story):

<https://data.guix.gnu.org/repository/1/branch/master/package/gmsh/output-history>

the Data Service that the commit changing the output is b5e51a06.  I
claim the Data Service is wrong. :-) And I suspect issue with the dates;
as we have already talked about.


From the Data Service, the range commit is:

   b5e51a06 (first)
   3b026eb3 (last) 

Give a look at:

--8<---------------cut here---------------start------------->8---
$ git --no-pager log --pretty=format:"%h %ad|%cd %s" 3b026eb3^..b5e51a06 --date=local
b5e51a06de Thu Oct 22 16:14:07 2020|Fri Oct 23 16:35:39 2020 gnu: python-black: Update to 20.8b1.
7128174201 Sun Sep 20 23:42:04 2020|Fri Oct 23 16:35:39 2020 gnu: linux-libre-with-bpf: Update to 5.8.
1893c80fc1 Mon Oct 12 18:08:47 2020|Fri Oct 23 16:35:39 2020 gnu: kodi: Add nfs functionality.
c5372cd488 Fri Oct 23 12:12:34 2020|Fri Oct 23 16:35:39 2020 gnu: hdf5: Default to 1.10.
c9a656a5d0 Fri Oct 23 12:11:41 2020|Fri Oct 23 16:35:38 2020 gnu: imp: Update to 2.13.0.
bfb65a6768 Fri Oct 23 12:10:32 2020|Fri Oct 23 16:35:38 2020 installer: Make the network management selection window tighter.
3b026eb3b1 Fri Oct 23 15:34:50 2020|Fri Oct 23 15:40:36 2020 Revert "gnu: u-boot: Update to 2020.10."
--8<---------------cut here---------------end--------------->8---

I am sure because I know the Gmsh internals that the offending is:
“c5372cd488 gnu: hdf5: Default to 1.10.”  which is verified by:

        $ guix graph --path gmsh hdf5
        gmsh@4.6.0
        hdf5@1.10.7

and note that using the commit b5e51a06de pointed by the Data Service,
the culprit should be python-black.  But this package does not appear in the
graph of gmsh:

        $ guix graph --path gmsh python-black -t bag
        guix graph: error: no path from 'gmsh@4.6.0' to 'python-black@20.8b1'


Ok, so then let examine guix-commits and the mbox file, since the Data
Serive uses that.


From the message ID <20201023143628.6130.60435@vcs0.savannah.gnu.org> it reads,

  Date: Fri, 23 Oct 2020 10:36:29 -0400 (EDT)

which is the date reported by the Data Service.  So far so good. :-)

The message says:

  civodul pushed a change to branch master
  in repository guix.

      from 3b026eb  Revert "gnu: u-boot: Update to 2020.10."
       new bfb65a6  installer: Make the network management selection window tighter.
       new c9a656a  gnu: imp: Update to 2.13.0.
       new c5372cd  gnu: hdf5: Default to 1.10.
       new 1893c80  gnu: kodi: Add nfs functionality.
       new 7128174  gnu: linux-libre-with-bpf: Update to 5.8.
       new b5e51a0  gnu: python-black: Update to 20.8b1.

Hum, it is because civodul probably sent a series by batch.  But this
should not be used since it is not a real commit. IMHO.


Now, let compare c5372cd (good) and b5e51a0 (bad):

c5372cd gnu: hdf5: Default to 1.10.

        From MAILER-DAEMON Fri Oct 23 10:36:34 2020
        Date: Fri, 23 Oct 2020 10:36:30 -0400 (EDT)
        X-List-Received-Date: Fri, 23 Oct 2020 14:36:32 -0000

b5e51a0  gnu: python-black: Update to 20.8b1.

        From MAILER-DAEMON Fri Oct 23 10:36:41 2020
        Date: Fri, 23 Oct 2020 10:36:32 -0400 (EDT
        X-List-Received-Date: Fri, 23 Oct 2020 14:36:34 -0000


Therefore, the Data Service somehow uses incorrect dates.

Well, the Data Service should filter out the messages only containing
the header X-Git-Rev (commit hash) and use the date (Date) of the
message, which is, IMHO, the most accurate way to do.  Instead of rely
on the date of message containing such headers:

        X-Git-Oldrev: 3b026eb3b1dd92c653d1a640b1280b96cfea3084
        X-Git-Newrev: b5e51a06de08f446a07f678ff806cd71a355f7

which can miss the correct commit introducing a change of derivation.


Hope that helps,
simon


  reply	other threads:[~2020-11-17 21:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 13:26 Data Services: use cases zimoun
2020-10-13  8:44 ` Pierre Neidhardt
2020-10-21  9:27   ` Ludovic Courtès
2020-10-21  9:39     ` Pierre Neidhardt
2020-10-21 10:19     ` zimoun
2020-11-16 19:28       ` Christopher Baines
2020-11-16 20:24         ` zimoun
2020-11-16 20:54           ` Christopher Baines
2020-11-16 21:12             ` zimoun
2020-11-16 21:50               ` Christopher Baines
2020-11-16 22:38                 ` zimoun
2020-11-17 21:43                   ` zimoun [this message]
2020-11-17 21:57                     ` Fix incorrect date and commit in Data Service zimoun
2020-11-17 22:44                       ` zimoun
2020-11-16 19:26     ` Data Services: use cases Christopher Baines
2020-11-16 19:20   ` Christopher Baines
2020-11-17  7:48     ` Pierre Neidhardt
2020-11-17  8:04       ` Christopher Baines
2020-11-17  8:49         ` Pierre Neidhardt
2020-11-17 19:34           ` Christopher Baines
2020-11-17 19:42             ` Pierre Neidhardt
2020-11-16 19:17 ` Christopher Baines
2020-11-16 20:34   ` zimoun
2020-11-16 21:08     ` Christopher Baines
2020-11-17 13:19       ` Linking to the data service Ludovic Courtès
2020-11-17 16:26         ` zimoun
2020-11-17 16:18       ` Data Services: use cases zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=863617oe1h.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.