From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UDo1NhDo+WB2QwEAgWs5BA (envelope-from ) for ; Thu, 22 Jul 2021 23:50:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uFCMMRDo+WCKdgAAB5/wlQ (envelope-from ) for ; Thu, 22 Jul 2021 21:50:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 736B5239DC for ; Thu, 22 Jul 2021 23:50:08 +0200 (CEST) Received: from localhost ([::1]:32804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6gZz-0007ZP-Bn for larch@yhetil.org; Thu, 22 Jul 2021 17:50:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6gZu-0007YM-Rr for guix-patches@gnu.org; Thu, 22 Jul 2021 17:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6gZu-0000vs-Ix for guix-patches@gnu.org; Thu, 22 Jul 2021 17:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6gZu-00051w-Ep for guix-patches@gnu.org; Thu, 22 Jul 2021 17:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49499] [PATCH] gnu: add the tos;dr initiative's extension Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jul 2021 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: terramorpha@cock.li Cc: 49499@debbugs.gnu.org Received: via spool by 49499-submit@debbugs.gnu.org id=B49499.162699058619309 (code B ref 49499); Thu, 22 Jul 2021 21:50:02 +0000 Received: (at 49499) by debbugs.gnu.org; 22 Jul 2021 21:49:46 +0000 Received: from localhost ([127.0.0.1]:41747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6gZd-00051M-NR for submit@debbugs.gnu.org; Thu, 22 Jul 2021 17:49:46 -0400 Received: from out2.migadu.com ([188.165.223.204]:46449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6gZY-000519-Lu for 49499@debbugs.gnu.org; Thu, 22 Jul 2021 17:49:45 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626990578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Do+4PcEC1rNpKx5y8jwgJslPgcqfQGfOpyobCfa0Vzk=; b=k3axYX9na6RV2TPyR5rem1TrjHpRb8DK+qi/QpkdXXussUi0jsQy6P9RtF0agK/4O4rB/F /CCFErcbvmFrOHB8n6Wob4ALCEXFDC/Du0kpnqJLX0zvZPDAmqeZTIkMYgv+wdYazDExqg DzYuEEfUFUYsV5mmrwOd+Z9zVqX7cms= From: Sarah Morgensen References: <9d44234caf247026a5c19af90f5d4471@cock.li> Date: Thu, 22 Jul 2021 14:49:36 -0700 In-Reply-To: <9d44234caf247026a5c19af90f5d4471@cock.li> (terramorpha@cock.li's message of "Fri, 09 Jul 2021 15:33:08 -0400") Message-ID: <8635s6rpcf.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626990608; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Do+4PcEC1rNpKx5y8jwgJslPgcqfQGfOpyobCfa0Vzk=; b=TnB13uWSKeJupNTiAxU38QwKhOiAADbd+cnEWGEi4tLgzdLGnvwf2jOLxBHlup2k+TK36C uzwe2l9YSHhr3XcCzdiah48hw6+JOa4bGLhOvDPhPjkk2Bsg2y9PA8KnnLece91cnBPXgD H5BNIzwhGLY4jpOWDvydqmpzkRgV4l541hEnbFOpbfvWWlpaINfP5rIA7S+7gdrmEDo6oO 4ScHzE3CBHzMl7OU6EEXV4KsTm+KuUJNbwYaWrUAeQxCm0X4P5IZoo3HF5nxs0K6A8q26B kVHThD5NX2wGbWmbaKxa8NXfecU8uv5IYG514BqUmWr5pKCHA9tdbvAQ2HNj4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626990608; a=rsa-sha256; cv=none; b=ZATb3oMUEuuOfGASxoT+7QM0jM0vE7D4k9LJjcB3qxjIVE8k7i+CliIGbETMPw6AZCGSM+ sZCVYuslwt0UebvJr9Xld6xvB3A3LW4lb053CtGT5aNLx7PW+rX0SXZwNC2WuaYkx2b/bn pbW7HPFs3t3Epw4npBlKF/MhNZSWQlWkiS27Ut/DA1AGEMbdkkgCnB/9bpKfv9y2UJ/YW6 5CHUdpc0qkVs5FimjhQXu2Ok8EyNvtKxLJ8rbkzCBCAd+k4vbPaypxJGVw1V5TnLWdyCes E4NTeMacx0dKScylwdQ8hwlyu2DwVzESi36xmpFbGptajN/I0IreOw3HwJ2v1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=k3axYX9n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=k3axYX9n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 736B5239DC X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: pi4bzxzzYSpB Hi, Thanks for the patch. Unfortunately I am unable to apply your patch; it looks like your mail client wrapped long lines which broke the patch. (That's why most of us send patches with `git send-email`, to avoid this problem.) I also have a few suggestions for your patch, annotated below... terramorpha@cock.li writes: > This is a package definition for the terms of service;didn't read initiative. It > is useful to easily > know the privacy issues with whatever website the user is using. > > diff --git a/gnu/packages/browser-extensions.scm > b/gnu/packages/browser-extensions.scm > index a6120baf96..6cbe77b9c3 100644 > --- a/gnu/packages/browser-extensions.scm > +++ b/gnu/packages/browser-extensions.scm > @@ -121,3 +121,41 @@ ungoogled-chromium.") > > (define-public ublock-origin/chromium > (make-chromium-extension ublock-origin "chromium")) > + > +(define tosdr > + (package > + (name "tosdr") > + (version "4.1.1") > + (source (origin > + (uri > + (git-reference (url > "https://github.com/tosdr/browser-extensions.git") This line is too long and should be wrapped. > + (commit version))) > + (sha256 (base32 > "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0")) Likewise. > + (method git-fetch))) > + (inputs `(("bash" ,bash) > + ("coreutils" ,coreutils) > + ("node" ,node) > + ("zip" ,zip) > + ("unzip" ,unzip))) These should be native-inputs rather than inputs, since they are just used in building. Perhaps consider just using copy-build-system instead, to avoid manually including these inputs and setting PATH below. You can look at the ublock-origin package as an example (though I would use the copy-build-system instead, adding back in a 'build phase, either removing the "rm -rf build" from `build.sh` beforehand or unzipping the zip immediately afterwards). > + (arguments > + `(#:builder > + (begin > + (use-modules (guix build utils)) > + (set-path-environment-variable "PATH" > + '("bin") > + (map cdr %build-inputs)) > + (copy-recursively (assoc-ref %build-inputs "source") ".") > + (invoke "sh" "./build.sh") > + (invoke "unzip" "dist/chrome.zip" "-d" %output) > + #t) > + #:modules ((guix build utils)))) > + (build-system trivial-build-system) > + (synopsis "extension for the Terms of Service; Didn't Read initiative") The synopsis should begin with a capital letter. > + (description "This extension informs you instantly of your rights online by > +showing an unintrusive icon in the toolbar. You can click on this icon to get > +summaries from the Terms of Service; Didn't Read initiative.") > + (license license:agpl3) > + (home-page "https://tosdr.org/"))) > + > +(define-public tosdr-chromium > + (make-chromium-extension tosdr)) -- Sarah