From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mE+ICAGDQWH9RwEAgWs5BA (envelope-from ) for ; Wed, 15 Sep 2021 07:22:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gLZRBAGDQWFNOwAA1q6Kng (envelope-from ) for ; Wed, 15 Sep 2021 05:22:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 792F7447F for ; Wed, 15 Sep 2021 07:22:08 +0200 (CEST) Received: from localhost ([::1]:33622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQNN1-0001ME-GJ for larch@yhetil.org; Wed, 15 Sep 2021 01:22:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQNMw-0001Lz-L4 for guix-patches@gnu.org; Wed, 15 Sep 2021 01:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQNMw-0000yX-D6 for guix-patches@gnu.org; Wed, 15 Sep 2021 01:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQNMw-0008TD-4w for guix-patches@gnu.org; Wed, 15 Sep 2021 01:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50333] [PATCH] Fixed missing files in org-roam 2.1.0 Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Sep 2021 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50333 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adolfo De =?UTF-8?Q?Un=C3=A1nue?= Cc: 50333@debbugs.gnu.org Received: via spool by 50333-submit@debbugs.gnu.org id=B50333.163168330332535 (code B ref 50333); Wed, 15 Sep 2021 05:22:02 +0000 Received: (at 50333) by debbugs.gnu.org; 15 Sep 2021 05:21:43 +0000 Received: from localhost ([127.0.0.1]:50573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQNMc-0008Sh-VJ for submit@debbugs.gnu.org; Wed, 15 Sep 2021 01:21:43 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:41907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQNMa-0008SU-P0 for 50333@debbugs.gnu.org; Wed, 15 Sep 2021 01:21:41 -0400 Received: by mail-wm1-f46.google.com with SMTP id g19-20020a1c9d13000000b003075062d4daso1123931wme.0 for <50333@debbugs.gnu.org>; Tue, 14 Sep 2021 22:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=/J+sio05fA5bkeKP1QH/Tz1lYFnsNU84r4whthJJIIM=; b=QbltPdu8208rUnmvQ5BrK1O/9Kq7uT7R/CuZx32gxgdUMQmZSYhon5Dq5MulPtankA Dgq+g3fBu2F0Rjbscj0/oHg74s9iwfVVcMI7WUQJXi0nH0HuaNUR1/mzhHSIkJ9jiOhQ yBhDb/i91jkDwAZe/qrTPpV5lzztFpsy/Uc/YUTtJv5wvDH5sV2Zoz0qLcjW8R6+Yfaw iWeevGKystCNNoE+vd9iK6btaMw3tLh+IfBuvgG91qvwry0FaRfu2enqCh7H3xbY1paa Ien+4iKmIiKaXKSi02wU3lipkQqEC987+LoPx8yYzIqJw80vFFFpOHEa73mLDJIkS3uJ nEbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=/J+sio05fA5bkeKP1QH/Tz1lYFnsNU84r4whthJJIIM=; b=T6c/LzN75d4LLQB+W11qu9suA/PBW+J1lgr0bl07wj1asCQnefdXR1HSpai13Rqiad bABLwv4bc9lcmimKO/IfAO0yLnmMvDeIF73x1BtgPlgOxeHiFheaaj2QRFaIbiVzVxNB LsVgjorM8wf0Bb15O7/UQP+gDDtRjBlAi+RmfMtvrX40HbNK6z1rw1SUK+iS9kd9C4Ip UDjrvBLRqLO/UJ16+/RxeOtS+NcFu048tVrqR7ScGhUPbGtZpdFsA2Gy7G/4Sp43klbl j0AlY3w7gnV/1VPnDDBEaQhJ2ND72QB7pgOA90jB/PUfT4e6x7/4DXD6l6tx1lXH2UeM m4MA== X-Gm-Message-State: AOAM531TbigfqwSGOfcsk7q8mqNXyDbZR8BOPbDnpAuiFo5HvCpRgUKQ K48tYE8C4l76lVoOVRBhBDZmDgFevQY2vA== X-Google-Smtp-Source: ABdhPJyL4xAvoSCwOB+lWSjNTSGRKDQtHB72a1ZEprqYjJ5GSdYP1oX76T+UjXXmRlKuFSas5imu5g== X-Received: by 2002:a1c:a713:: with SMTP id q19mr2502349wme.42.1631683294749; Tue, 14 Sep 2021 22:21:34 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id c2sm12384466wrs.60.2021.09.14.22.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 22:21:34 -0700 (PDT) From: zimoun In-Reply-To: <87o88ureh9.fsf@unanue.mx> References: <877dfzebfd.fsf@unanue.mx> <87v93icnst.fsf@unanue.mx> <86ilz3tkai.fsf@gmail.com> <87o88ureh9.fsf@unanue.mx> Date: Wed, 15 Sep 2021 07:03:43 +0200 Message-ID: <8635q6e8gg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631683328; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/J+sio05fA5bkeKP1QH/Tz1lYFnsNU84r4whthJJIIM=; b=pAfhfUdRKXpaHE68vv64vk/ppWwIj8zA47K9xbqlvA0DEwBkhfh8eziOdivaVQMqmCba+Z hohjyVNVCI5n8VHt4Iep4hYUUJiXhsHM+UB99pZW+6tKtSE1hP4lenPb8YLItsdPtCyDMj crAYe1NFNFbEu2aBfEdKXl6RdSC02kHje6f5FKtng1Qui7Rrsa4H+SywYqT3rRAcujT773 je3o5IpHWTxlZR+AMEaeBpYiLMsdVF0n7z5rv12KsECWOA3aUdy+onSy6vvAR5ceQoHanf EorIDlQUD3YnwaLkVPYatFf6nrQiyWrA4KTx8KvZvkqexPPV9YYPG8rMtj8OhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631683328; a=rsa-sha256; cv=none; b=UpIJeLGgeduhtZX9tkHqhnvKAoNWQeOV5YhwLF9YmZJwvGKpGv4KJKA4vQmS7Hna2ckaWk qUe7Np/yctzn8aqpoJNYJR2QfL/cTqHcyggeqHMN43XyGF5HL3EHkBgpm3jj7GD8ug1j6t 6Xufm93q4uzrWGYCFWDs2rrJXnQWAtBu95812i3PvwwZDafN6R2nzm5hX7ByntlaAA+jwD ygTy9Y6AWQh4xeIaksHbSBSxSsTpESLuRqDaNwKEniEYyLRi4Oiz+KCmWcuedRp44ub0C0 d5U21w53TzMCbAQyS1f9dKx2l7F/AU0ZIbWyrC0rV4WCU6qzC4x5di7q3erKMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QbltPdu8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QbltPdu8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 792F7447F X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4gi18SehNGy5 Hi, On Tue, 14 Sep 2021 at 17:10, Adolfo De Un=C3=A1nue wrot= e: > zimoun writes: >>> Subject: [PATCH] Fixed missing files in org-roam v2.1.0 >> >> The commit message should be: >> >> --8<---------------cut here---------------start------------->8--- >> gnu: emacs-org-roam: Adding extensions. >> >> * guix/emacs-xyz.scm (emacs-org-roam)[arguments]: Add phases to=20 >> install >> extensions. >> --8<---------------cut here---------------end--------------->8--- >> >> Or something along these lines. > > Should I apply your suggested changes, commit them, use this=20 > commit > message, create the patch and send them again? Yeah, you can address and send then an updated patch. Doing so, please increment the re-roll count which eases to know that patch is the last. For instance, the ones you sent looks like: --8<---------------cut here---------------start------------->8--- [ Adolfo De Un=C3=A1nue ] [bug#50333] [PATCH] Fixed missing files in org-ro= am 2.1.0 [ Adolfo De Un=C3=A1nue ]=20 [ Adolfo De Un=C3=A1nue ]=20 --8<---------------cut here---------------end--------------->8--- and the reviewer has to open all 3 to know what happens. Compare with for instance: --8<---------------cut here---------------start------------->8--- [ Marius Bakke ] [bug#50377] [PATCH 0/2] Support 'git describe' =E2=80=A6 [ Marius Bakke ] [bug#50377] [PATCH 1/2] git: 'resolve-refer =E2=80=A6 [ Marius Bakke ] [bug#50377] [PATCH 2/2] transformations =E2=80=A6 [ Marius Bakke ] [bug#50377] [PATCH v2 1/2] git: 'resolv =E2=80=A6 [ Marius Bakke ] [bug#50377] [PATCH v3 0/2] Support 'git des =E2=80=A6 [ Marius Bakke ] [bug#50377] [PATCH v3 1/2] git: 'resolv =E2=80=A6 [ Ludovic Court=C3=A8s ] [bug#50377] [PATCH 0/2] Support =E2= =80=A6 [ Marius Bakke ] [bug#50377] [PATCH v3 2/2] transformati =E2=80=A6 [ Ludovic Court=C3=A8s ] [bug#50377] [PATCH 0/2] Support =E2= =80=A6 [ Xinglu Chen ] [bug#50377] [PATCH v3 0/2] Support 'git =E2=80=A6 --8<---------------cut here---------------end--------------->8--- Well, I suggest you to use =E2=80=9Cgit format-patch -v4=E2=80=9D. :-) >>> + (let ((commit "f819720c510185af713522c592833ec9f2934251") >> >> Usually, the package uses tagged version instead of random=20 >> commit. When >> it is not possible because upstream do not tag, it seems good to=20 >> provide >> an explanation why the lasted tagged version cannot be used; >> explanations as a comment or in the cover letter. >> > > As you guessed, org-roam has not tagged this new (breaking)=20 > change, > that's why I am using the commit Yeah, but is it released? Or simply the development version? If it is the development version, usually it is on per user basis, i.e., you can use a package transformation. Inclusion of releases is preferred. >>> + (add-after 'install 'install-extensions >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (copy-recursively >>> + "extensions" >>> + (string-append (assoc-ref outputs "out") >>> + (string-append >>> + "/share/emacs/site-lisp/org-roam-" >>> + ,version))) >>> + #t)) >> >> Patch#50333 will install the extensions with =E2=80=9Cguix install >> emacs-org-roam=E2=80=9D. Instead the attempt of patch#50374 is to=20 >> install with >> =E2=80=9Cguix install emacs-org-roam-extensions=E2=80=9D. Well, I do no= t know=20 >> if >> patch#50374 is correct, though. >> >> Because I am not an Org-Roam user, I do not have an opinion=20 >> about this >> extensions. Maybe it is better to distribute them along the=20 >> package >> emacs-org-roam or in a separate package, I do not know. WDYT? > > I mean, structurally the upstream owner just moved some files to a=20 > new > folder, my guess is that it shouldn't be a different packages=20 > since it > is still part of org-roam. Note that some packages are only one upstream source but indeed different packages. For instance, notmuch and emacs-notmuch (for the most recent :-)). Another example, IIRC, some time ago, Org-contrib was a folder under Org but distributed by 2 packages. Well, it is sometime the same package and simply that upstream reorganize stuff. :-) BTW, why is it needed to explicitly copy the =E2=80=9Cextensions=E2=80=9D f= iles? Without this added phase, does it not work? All the best, simon