From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id LPuKHbKhSmE7FQAAgWs5BA (envelope-from ) for ; Wed, 22 Sep 2021 05:23:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aNWQGLKhSmGDawAAbx9fmQ (envelope-from ) for ; Wed, 22 Sep 2021 03:23:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 985F89605 for ; Wed, 22 Sep 2021 05:23:29 +0200 (CEST) Received: from localhost ([::1]:58400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSsr2-0005Wq-ES for larch@yhetil.org; Tue, 21 Sep 2021 23:23:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSsqd-0005UM-9v for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSsqb-0001cG-Ut for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSsqb-0001fF-PT for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table. References: In-Reply-To: Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 03:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49619@debbugs.gnu.org Received: via spool by 49619-submit@debbugs.gnu.org id=B49619.16322809236279 (code B ref 49619); Wed, 22 Sep 2021 03:23:01 +0000 Received: (at 49619) by debbugs.gnu.org; 22 Sep 2021 03:22:03 +0000 Received: from localhost ([127.0.0.1]:48440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSspe-0001dD-Tv for submit@debbugs.gnu.org; Tue, 21 Sep 2021 23:22:03 -0400 Received: from out2.migadu.com ([188.165.223.204]:11540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSspb-0001cg-L2 for 49619@debbugs.gnu.org; Tue, 21 Sep 2021 23:22:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632280917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=bLzOT7kT7wLTGcKtgsWa7fxKj/ZmPig6UrM3zmbEauw=; b=Qcrxs/JEgagKWaPTRqg2dGJaRtb80nPDcqDIxhm/0l0B/+DKbwe8WernHMCHVCTupAamvy RMweykUoo6sjw2DiugyfzSRgxN1onpKqjo+JGK4XAjShq56GFkkkQNBVPOudsDuFB25v1q z38gYRS1oxbexCuyAEynFAibJpWLdOM= From: Sarah Morgensen Date: Tue, 21 Sep 2021 20:21:53 -0700 Message-ID: <8635pxxpke.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632281010; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=bLzOT7kT7wLTGcKtgsWa7fxKj/ZmPig6UrM3zmbEauw=; b=eFEFDJhdupZjRYf8fl3z7KWxQap5ztd06xwVf53xAgvjc8l1ba02ytiENg++26saz/g5qm ZL4EZYI+wIayBOpcYnhUG1lwuWeTZptYMSVlY6uEbBbXhk08nUw+3CvgedYmZ8oVKQ6LtR L7BspEolH2fEEH5D4KqKrU1YbBxO82j8U52gFzbVpkskt8yHwkwwwEqToBpvHmJOoFKzXd hiHp2D2Q1ZX6g2y2Dc+Hqp5v+nfoSWu9aMhDqvk1COdF8Ph4CHHof8cmb+52rHoD2kQQ0N vs5loBwafEu+9Um/HG4CQF+hSpguWih3AHdxQrYTeXOldZkas27J62RMX8wjRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632281010; a=rsa-sha256; cv=none; b=XoVnK2tryvjL8ENPBU/t82ujJ2Dd5rYdRm5PuMWyJL34XgPzNyhPpYVsJd3WIgBakLr/Jx gmbTcyOP5H+H4Ff0nzHOJgIitQJKlejzJCuL8oFWjwHLjLR1yeUqQ6Kgx0ZAcfvLNYCRuF 82MxQeyNteAG2o2owo9yVmaQTot9xBh2q7Zo6hwpqNoIabGbm5MWFMd+XQKki4Y2QXdZZn saIFfKGnaLk+MvGVZQg/7wZVNLvR2dkc6Z4KInfvVNhKW+vrfM1qI98QwacqTcIYePiIWR m96dPoBr9GK903/eL7wdfX9k+0Z0exIM9WPzzR5tCY1C90qyVAiDS8ZnxJp6dw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b="Qcrxs/JE"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b="Qcrxs/JE"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 985F89605 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5uZKcfTG/+6b --=-=-= Content-Type: text/plain Hi, phodina writes: > Hi Sarah! > > Are these fixes now compliant to upstream the patch? It's pretty good. I went ahead and made a few changes (attached below): I tweaked the descriptions, I changed very-pretty-table to veryprettytable so the python importer can find it in the future, I changed pirate-get's propagated-inputs to inputs since it's an end-user package, and I changed the license of pirate-get to AGPL-3. * Package review checklist (WIP) Lack of a check is not proof of noncompliance. 1. [X] Package builds (guix build package) [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le [ ] i686 [ ] i586 [ ] mips64le 2. [X] Build is reproducible (guix build --rounds=n package) 3. [X] Tests enabled (if available) or disabled with in-source comment 4. [X] No extraneous dependencies (guix size package) 5. [X] No unnecessary pre-built binaries/blobs 6. [X] Dependencies unvendored when available in Guix 7. [X] Cross-compile friendly (cc-for-target, patches with inputs) 8. [X] License matches source 9. [X] No problematic lints (guix lint package) 10. [X] Formatting follows guidelines - [X] Lines wrap at 80 characters - [X] Indentation passes etc/indent-code.el - [X] Two spaces used between sentences For new packages: 1. [X] Source url is robust * mirror:// used with url-fetch when possible * No auto-generated archives from source repo (prefer cloning) 2. [X] Synopsis is short, descriptive, and meaningful to a wide audience 3. [X] Description is objective, takes 5-10 lines, uses full sentences, and provides the information users need to decide whether the software fits their needs. I also gave it a spin, and it works fine as long as the SSL_CERT_DIR environment variable is defined (I think that's beyond the scope of this package). LGTM. Thanks for your work! -- Sarah --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=v4-0001-gnu-Add-python-veryprettytable.patch Content-Description: gnu: Add python-veryprettytable. >From e468a5f5722a31ce9999ddba43a8de120521a938 Mon Sep 17 00:00:00 2001 Message-Id: From: phodina Date: Sat, 18 Sep 2021 12:44:21 +0000 Subject: [PATCH v4 1/2] gnu: Add python-veryprettytable. * gnu/packages/python-xyz.scm (python-veryprettytable): New variable. --- gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 4e2e719afc..b1f162d079 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -1793,6 +1793,33 @@ helpers.") (properties `((python2-variant . ,(delay python2-humanfriendly)))) (license license:expat))) +(define-public python-veryprettytable + (package + (name "python-veryprettytable") + (version "0.8.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "veryprettytable" version)) + (sha256 + (base32 + "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f")))) + (build-system python-build-system) + (propagated-inputs + `(("python-colorama" ,python-colorama) + ("python-termcolor" ,python-termcolor))) + (home-page + "https://github.com/smeggingsmegger/VeryPrettyTable") + (synopsis + "Visually appealing ASCII table output format for Python") + (description + "VeryPrettyTable is a Python library for displaying tabular data in a +visually appealing ASCII or HTML table. Output is highly configurable, +including text alignment, padding, borders, sort order, and more. Data can be +inserted directly, read from a CSV file, or imported using a Python DB-API +database cursor such as @code{sqlite3}.") + (license license:bsd-3))) + (define-public python2-humanfriendly (let ((base (package-with-python2 (strip-python2-variant python-humanfriendly)))) base-commit: a916d50566e77ae730e34f1753ceb78cc6bf0a5a -- 2.33.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=v4-0002-gnu-Add-python-pirate-get.patch Content-Description: gnu: Add python-pirate-get. >From 5e99c1f791c990dd76cd63a9ab2a5196656c5c6f Mon Sep 17 00:00:00 2001 Message-Id: <5e99c1f791c990dd76cd63a9ab2a5196656c5c6f.1632277047.git.iskarian@mgsn.dev> In-Reply-To: References: From: phodina Date: Sat, 18 Sep 2021 12:45:04 +0000 Subject: [PATCH v4 2/2] gnu: Add python-pirate-get. * gnu/packages/python-xyz.scm (python-pirate-get): New variable. --- gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index b1f162d079..86962e35b8 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -1820,6 +1820,34 @@ inserted directly, read from a CSV file, or imported using a Python DB-API database cursor such as @code{sqlite3}.") (license license:bsd-3))) +(define-public python-pirate-get + (package + (name "python-pirate-get") + (version "0.4.0") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pirate-get" version)) + (sha256 + (base32 + "07s5ss9dxccx1mip7pyga1fagywkqchxmzz55ng47ac9053ffxkq")))) + (build-system python-build-system) + (inputs + `(("python-colorama" ,python-colorama) + ("python-pyperclip" ,python-pyperclip) + ("python-veryprettytable" ,python-veryprettytable))) + (home-page + "https://github.com/vikstrous/pirate-get") + (synopsis + "Command line interface for The Pirate Bay") + (description + "@code{pirate-get} is an unofficial command line interface for searching +The Pirate Bay, inspired by @command{apt}. Results can be saved as JSON, +@code{.torrent} files, or magnet links, or they can be opened directly in +@command{transmission-remote}. @code{pirate-get} also supports searching +mirrors or a local copy of The Pirate Bay's database.") + (license license:agpl3))) + (define-public python2-humanfriendly (let ((base (package-with-python2 (strip-python2-variant python-humanfriendly)))) -- 2.33.0 --=-=-=--