all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Zhu Zihao <all_but_last@163.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Oleg Pykhalov <go.wigust@gmail.com>, 51747@debbugs.gnu.org
Subject: [bug#51747] [PATCH]: gnu: nix: Update to 2.4.
Date: Wed, 12 Jan 2022 12:21:47 +0800	[thread overview]
Message-ID: <8635lto9z3.fsf@163.com> (raw)
In-Reply-To: <190ec030edbca1c16fb030c51acd60ffc6bae269.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]


Maxime Devos <maximedevos@telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> Zhu Zihao schreef op wo 12-01-2022 om 01:19 [+0800]:
>> +    (name "libcpuid") [...]
>> +    (supported-systems '("x86_64-linux" "i686-linux"))
>
> Given that 'cpuid' is a CPU instruction, I don't think
> this is Linux-specific; presumably it works on the Hurd
> as well.  According to the README, it also supports some BSDs,
> Mac OS and Windows!
>
> Could you change it to
>
> (filter (lambda (t) (or (x86-64-target? t) (or (x86-32-target? t))))
>         %supported-systems)
>
> instead (untested)?
>
> Also, the source code contains a blob
> <https://github.com/anrieff/libcpuid/blob/master/libcpuid/msrdriver.c>,
> could you remove it in an origin snippet?
>
> There might be more blobs, I didn't look at all files.
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]

Interesting, It looks that these blobs are for Windows system. I don't
care about MS Windows, but blobs are tightly integrated in the source.

The source reports that they're compiled from the source in contrib/MSR
Driver/Kernel. They're PE COFF format, If we want to compile it ourself,
we have to use mingw cross compiler. This increase the complexity of
build script.

AFAIK, nix use libcpuid only in linux context. My idea is replace these
blobs with empty bytes. Maybe leave a note for who want mingw cross build. 

-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]

  reply	other threads:[~2022-01-12  4:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 12:35 [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Zhu Zihao
     [not found] ` <handler.51747.B.16365478179399.ack@debbugs.gnu.org>
2021-11-10 13:53   ` [bug#51747] Acknowledgement ([PATCH]: gnu: nix: Update to 2.4. ) Zhu Zihao
2021-11-10 15:47     ` Zhu Zihao
2021-11-17 11:21       ` Zhu Zihao
2021-12-04 15:28         ` Zhu Zihao
2022-01-11  8:23           ` [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Oleg Pykhalov
2022-01-11  9:46             ` Zhu Zihao
2022-01-11 17:19             ` Zhu Zihao
2022-01-11 19:04               ` Maxime Devos
2022-01-12  4:21                 ` Zhu Zihao [this message]
2022-01-12  5:19                   ` Oleg Pykhalov
2022-01-12  7:08                     ` Zhu Zihao
2022-01-12  8:26                   ` Maxime Devos
2022-01-13  4:54                 ` Zhu Zihao
2022-01-13  7:54                   ` Zhu Zihao
2022-01-14 13:06                   ` Maxime Devos
2022-01-14 16:51                     ` Zhu Zihao
2022-01-14 18:39                       ` Maxime Devos
2022-01-15  1:58                         ` Zhu Zihao
2022-01-15  5:47                         ` Zhu Zihao
2022-01-15 10:52                           ` Maxime Devos
2022-01-15 16:06                             ` Zhu Zihao
2022-01-21 14:29                               ` bug#51747: " Oleg Pykhalov
2022-01-23 11:02                             ` [bug#51747] " Maxime Devos
2022-01-11 19:05               ` Maxime Devos
2022-01-14  9:31             ` Zhu Zihao
2022-01-14 12:56               ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8635lto9z3.fsf@163.com \
    --to=all_but_last@163.com \
    --cc=51747@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.