Re: [PATCH] gnu: moc: Update to 2.5.2.

[Kei Kebreau <kei@openmailbox.org>]

[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]

Kei Kebreau <kei@openmailbox.org> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll
>>> commit it to master.
>>> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001
>>> From: Kei Kebreau <kei@openmailbox.org>
>>> Date: Tue, 10 Jan 2017 19:18:42 -0500
>>> Subject: [PATCH] gnu: moc: Update to 2.5.2.
>>>
>>> * gnu/packages/music.scm (moc): Update to 2.5.2.
>>> ---
>>>  gnu/packages/music.scm | 10 ++++++++--
>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>>> index 59fd508f6..803e0a6e5 100644
>>> --- a/gnu/packages/music.scm
>>> +++ b/gnu/packages/music.scm
>>> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.")
>>>  (define-public moc
>>>    (package
>>>      (name "moc")
>>> -    (version "2.5.1")
>>> +    (version "2.5.2")
>>>      (source (origin
>>>                (method url-fetch)
>>>                (uri (string-append "http://ftp.daper.net/pub/soft/"
>>> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.")
>>>                                    name "-" version ".tar.bz2"))
>>>                (sha256
>>>                 (base32
>>> -                "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
>>> +                "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk"))
>>> +              (modules '((guix build utils)))
>>> +              (snippet
>>> +               ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>>> +               '(substitute* "main.c"
>>> +                  (("printf \\(\"            Built : %s\", __DATE__\\);") "")
>>> +                  (("printf \\(\" %s\", __TIME__\\);") "")))))
>>
>> The commit message should mention the change to [source]. I would prefer
>> if this was a separate patch, unless the __DATE__ and __TIME__ macros
>> were introduced in this version, but no strong opinion.
>>
>> LGTM!
>
> Thanks for the review! The macros you mention were indeed introduced in
> this version. I'll modify the commit message to include the changes to
> [source] and push it to master.

Does this commit message look good to you?

* gnu/packages/music.scm (moc): Update to 2.5.2.
[source](modules, snippet): Remove timestamps from the output.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]