From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d86FG-0003Bm-2e
	for guix-patches@gnu.org; Tue, 09 May 2017 10:36:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d86F9-0003Wn-Tt
	for guix-patches@gnu.org; Tue, 09 May 2017 10:36:10 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59858)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d86F9-0003Wj-NY
	for guix-patches@gnu.org; Tue, 09 May 2017 10:36:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d86F9-0003SO-FX
	for guix-patches@gnu.org; Tue, 09 May 2017 10:36:03 -0400
Subject: bug#26339: [PATCH v2 01/12] system: Pass <bootloader-parameter> to
	grub.
Resent-Message-ID: <handler.26339.B26339.149434055613273@debbugs.gnu.org>
References: <20170417090148.13791-1-m.othacehe@gmail.com>
	<20170417090148.13791-2-m.othacehe@gmail.com> <87zienofiy.fsf@gnu.org>
	<20170508155109.19fa060d@scratchpost.org> <87tw4vs89q.fsf@gmail.com>
	<87shkew1wy.fsf@fastmail.com>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87shkew1wy.fsf@fastmail.com>
Date: Tue, 09 May 2017 16:36:26 +0200
Message-ID: <861sryjdw5.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26339@debbugs.gnu.org


Hi Marius,

> Thanks a lot for working on this. I've tested it extensively while
> working on UEFI support and it works great with native EFI grub[0]. Can
> you push the updated patches to a "wip-bootloader" branch on Savannah?
> Please also send a `git request-pull` here ;-)

Cool ! Thanks for your feedback !

I'll publish my v4 in wip-bootloader then.

> No comments on the code, but I did notice many docstrings need to be
> updated.

Ok, Danny pointed some of them, I'll add the missing ones.

Thanks,

Mathieu