From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qAmFD4NF+2DcxQAAgWs5BA (envelope-from ) for ; Sat, 24 Jul 2021 00:41:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CAj0CoNF+2BUVwAAbx9fmQ (envelope-from ) for ; Fri, 23 Jul 2021 22:41:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9CBDFEC6 for ; Sat, 24 Jul 2021 00:41:06 +0200 (CEST) Received: from localhost ([::1]:34818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m73qr-0000jc-Mb for larch@yhetil.org; Fri, 23 Jul 2021 18:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m73qo-0000jT-75 for guix-patches@gnu.org; Fri, 23 Jul 2021 18:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m73qo-0000Fr-0A for guix-patches@gnu.org; Fri, 23 Jul 2021 18:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m73qn-0004VE-TT for guix-patches@gnu.org; Fri, 23 Jul 2021 18:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49094] [PATCH] gnu: Add video-contact-sheet Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Jul 2021 22:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49094 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pradana Adrinusa AUMARS Cc: 49094@debbugs.gnu.org Received: via spool by 49094-submit@debbugs.gnu.org id=B49094.162708001317246 (code B ref 49094); Fri, 23 Jul 2021 22:41:01 +0000 Received: (at 49094) by debbugs.gnu.org; 23 Jul 2021 22:40:13 +0000 Received: from localhost ([127.0.0.1]:44865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m73q0-0004U5-Cv for submit@debbugs.gnu.org; Fri, 23 Jul 2021 18:40:13 -0400 Received: from out0.migadu.com ([94.23.1.103]:23809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m73pu-0004Tj-4D for 49094@debbugs.gnu.org; Fri, 23 Jul 2021 18:40:11 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627080004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FVTGS5Sfrhpqi/cBmti+jmK4sCuKaSJw/wgC5wmxYoA=; b=gameZF6VNfW49Qk53yEBa2NQ7bvE8ccKi3Brh/x7ufbAFAwQ19lXhVTMmKRBd/YSR3J0JJ FtLJU9LBkPyC5RhPpyKzc7u4t/gKkNf7gr94mjW1A2JchsBq424gbYE4lNFg7lxLHq0qAU dF9okBUdhaYkLRL9/NDp3Ov8U3iLbPs= From: Sarah Morgensen References: <3627c385f0509614621b154cd26dc9ed4f503a51.camel@courrier.dev> Date: Fri, 23 Jul 2021 15:40:02 -0700 In-Reply-To: <3627c385f0509614621b154cd26dc9ed4f503a51.camel@courrier.dev> (Pradana Adrinusa AUMARS's message of "Fri, 18 Jun 2021 16:27:02 +0200") Message-ID: <861r7or6wt.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627080067; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FVTGS5Sfrhpqi/cBmti+jmK4sCuKaSJw/wgC5wmxYoA=; b=piDah4kW4Mu8wy5YiX5GzosyaRZLn7AmHs/iaggCq6qRYn99wlBWOmUw7S8Fgcbs6cXwPy UsfLhYc2rLKdq+PT/iQoiH5UheF55/23oTtREtRTYU3iv4kw8dBRSCw97CvjpqCay+8FJH 5+Phv75P0aA7uP0FFrvJuuZ+WcvcQz0D7ssl+Y9Z3a1DZNxMpFLzXEGcq72daihCnpQhpx py96P3RmrMVTaeK8moauBz5yCvod4PH4p+WyGdPon5rBq13iymH+V1HFrStbJOQAdif9Nx r/qc19flTNfVJcjTzBafNj08Y1tMYcpaEEaFUqGE+ZDeWNe+O57ekmfcSS6qLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627080067; a=rsa-sha256; cv=none; b=aW2tIZq992fxtFQwZbLtTE6o87wYP5vZOfNFbZ+NMMqUAGH4UA314nCQMRN/7nGGriBeIx apLUnNT2uN2rZWzoVstHFoRpSSRwWDF51deFVIbsRgShMkDcy5DFBFLOt7Rx1UXi9IriMx 9bMpQ1ydIBIrzMiSr+l41olJq7a5cXOHN2uDdo2S0ahnPlBhP5Fsi3mbclKhAmAbUj5uEV shXsp7IXrsrYUDo+vNb7RMBhBmGT6SUnCgURE5VDR1CJlHGmJvW5auvp9OyOYo9eX355AN ckrv5VEXVOYvBlbCa4kWBYfct6AJ+VB7v76hQRMu9QRq85IScCSE39jaQqegiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=gameZF6V; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=gameZF6V; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A9CBDFEC6 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: NsKjCaEJzcIk Hello, Thank you for the patch. Unfortunately, I cannot apply it because your mail client has wrapped some lines, corrupting the patch. (Also, adding to the end of the file rather than the middle tends to cause patches not to apply, so probably avoid this as well.) I do still have a few suggestions, annotated below: Pradana Adrinusa AUMARS writes: >>>From 9851db2b3036ee3d5e8ef85ed8bae2f6398702e0 Mon Sep 17 00:00:00 2001 > From: Pradana AUMARS > Date: Fri, 18 Jun 2021 16:13:07 +0200 > Subject: [PATCH] gnu: Add video-contact-sheet > > --- > gnu/packages/video.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index e3f4f59b4c..ba3035cf45 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -51,6 +51,7 @@ > ;;; Copyright =C2=A9 2021 Andrew Tropin > ;;; Copyright =C2=A9 2021 David Wilson > ;;; Copyright =C2=A9 2021 Maxim Cournoyer > +;;; Copyright =C2=A9 2021 Pradana Aumars > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -96,6 +97,7 @@ > #:use-module (gnu packages avahi) > #:use-module (gnu packages backup) > #:use-module (gnu packages base) > + #:use-module (gnu packages bash) > #:use-module (gnu packages bison) > #:use-module (gnu packages boost) > #:use-module (gnu packages cdrom) > @@ -5180,3 +5182,32 @@ information) NALUs (Network Abstraction Layer > Unit) for inclusion into an h.264 > elementary stream are provided.") > (home-page "https://github.com/szatmary/libcaption") > (license license:expat))) > + > +(define-public video-contact-sheet > + (package > + (name "video-contact-sheet") > + (version "1.13.4") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://p.outlyer.net/vcs/files/vcs-" > version > + ".tar.gz")) Lines should be wrapped at 80 characters when possible. Indentation should be with spaces instead of tabs. Also, it looks like 'http://p.outlyer.net/vcs/files/' has a permanent redirect to 'http://p.outlyer.net/files/vcs/' so that should be updated. > + (sha256 > + (base32 > + "0jsl93r0rnybjcipqbww5hwsr9ln6kz1qnf32qfxdvhfw52n27fw")) > )) > + (build-system gnu-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'build) > + (delete 'check)) > + #:make-flags (list (string-append "prefix=3D" (assoc-ref %outputs > "out"))))) > + (inputs > + `(("bash" ,bash) > + ("ffmpeg" ,ffmpeg) > + ("imagemagick" ,imagemagick))) > + (synopsis "Bash script to create contact sheets (preview images) > from videos") > + (description "This is a bash script meant to create video contact > sheets (previews) of videos. Any video supported by mplayer and ffmpeg > can be used. A note of warning: Unlike most similar tools it, by > default, makes screenshots the same size as the video, see below for ^ the manual > details on how to change this. > + > +Take a look at the documentation and/or use the =E2=80=93help and =E2=80= =93fullhelp > options to learn how to use it.") This last sentence should probably not be in the description. Please also wrap these lines at 80 characters as well (see other packages for examples), and use two spaces between sentences. > + (home-page "http://p.outlyer.net/vcs/") > + (license license:lgpl3))) -- Sarah