From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id lF3PC9YGRGFVEwAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 05:09:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KFH4BtYGRGGJTwAA1q6Kng (envelope-from ) for ; Fri, 17 Sep 2021 03:09:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79A8EA98E for ; Fri, 17 Sep 2021 05:09:09 +0200 (CEST) Received: from localhost ([::1]:39714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR4FQ-00071a-KP for larch@yhetil.org; Thu, 16 Sep 2021 23:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR4FK-00071R-8O for bug-guix@gnu.org; Thu, 16 Sep 2021 23:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR4FK-0007Ur-12 for bug-guix@gnu.org; Thu, 16 Sep 2021 23:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR4FJ-0001xM-SH for bug-guix@gnu.org; Thu, 16 Sep 2021 23:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50595: Faliure in guix import go Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Sep 2021 03:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50595 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Stephen Paul Weber Received: via spool by 50595-submit@debbugs.gnu.org id=B50595.16318480837445 (code B ref 50595); Fri, 17 Sep 2021 03:09:01 +0000 Received: (at 50595) by debbugs.gnu.org; 17 Sep 2021 03:08:03 +0000 Received: from localhost ([127.0.0.1]:58149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR4EM-0001w0-Ie for submit@debbugs.gnu.org; Thu, 16 Sep 2021 23:08:02 -0400 Received: from out1.migadu.com ([91.121.223.63]:18822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR4EK-0001vb-2s for 50595@debbugs.gnu.org; Thu, 16 Sep 2021 23:08:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631848079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DOYTcbTlzObcu3MiQlT76bXrVWjqpSJSWDNwcSYZkG8=; b=Gaqd5wvtk0lk7mcmUPPVwGA+7I4O38wx82wR6wAeCVsYg20ezCzbCpwpBY2xBTSXrWyKmF w9sZNoEcT6D+Snh9CAaPuYmey+tAlqZrsq7nO3/yC4bvJsZdvFPVf7yvEZctmDbkpNDejC 9lG8rVqqoyI4wsdiemmtxXe6a2oOR7A= From: Sarah Morgensen References: <20210915003242.GA22238@singpolyma-beefy.lan> Date: Thu, 16 Sep 2021 20:07:52 -0700 In-Reply-To: <20210915003242.GA22238@singpolyma-beefy.lan> (Stephen Paul Weber's message of "Tue, 14 Sep 2021 19:32:42 -0500 (2 days, 59 minutes, 30 seconds ago)") Message-ID: <861r5nj3w7.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50595@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631848149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=DOYTcbTlzObcu3MiQlT76bXrVWjqpSJSWDNwcSYZkG8=; b=QTxTRj756GTeAKwXzAH2tgvxIYfQ2K+GsE96p1QwgDU0v7ELpIJgwU98Po/N8LfRzN0EWa eLymOIB8ek/3O/CzbQuWKRJKMONvCI7Q5E2q8Lfw1Ms4MKC2ffMHRmZLdz8kNyVADs/9Eh sej7b9McboJ0f00PsrwaeiCIyTOIlGA68wM0loSH1cfpFhq1iOF3tY52a0ffPfZR1rKZvs 01/uMc14WnDUyUiRhc7YhCYzkqU7XJ7aIlqbGkIC7q16iIufp19JcycuGaicEKgMuar9UN aqxNHtnMJCwuPeKmssZRqok9Mswop3LtQjoCT1qHMuyGWgEORX7s2DBEYTBrvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631848149; a=rsa-sha256; cv=none; b=WvD6SiGtlp38oPO7bs4zIKHBIBRNpZT/BHl7ffZCzSlTca9pRTcmw6ugf33dNTV7jBFY2P 6rAF+U7TGgL2ZM65DVIKRd44opSYbsyC/RcZOulyL7qUOQPpr2CO6OgY+Zeo2tz7eBAiD3 7k2o3T9PiXQ6ijn5hwTl0P04R2weBtvXOjY630r0Wd1OzYfGUysu4zTlV3VPvT4x3jg+Tw W9G+ZK332gG3ocmCVFbUNUAa/dcve1fr0oQ3rT3/R69V6yFPz3ryyfZR6QkJXP0ac5dP2U GGS8vgC/I9189eD4w6e81aU//8i4ilZ2BGbDjBKAS6Kspd3Fy17KhSAKoQJctw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Gaqd5wvt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Gaqd5wvt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 79A8EA98E X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: hpK+fW8UUh7A --=-=-= Content-Type: text/plain Hello, Thanks for your report! Stephen Paul Weber writes: > $ guix import go -r bdd.fi/x/runitor > > guix import: warning: Failed to import package "bdd.fi/x/runitor". > reason: ("struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" (#f) (#f)). It seems this is occurring because "https://bdd.fi/x/runitor?go-get=1" does not have the tag in the element, as the Go spec requires (it's a direct child of the element). However, it seems fairly harmless to relax this requirement in our importer, so the following patch should fix this. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-import-go-Match-go-import-meta-tags-anywhere.patch Content-Description: import: go: Match go-import meta tags anywhere. >From ca17299a3011171d6889202003d1e888b22303ec Mon Sep 17 00:00:00 2001 Message-Id: From: Sarah Morgensen Date: Thu, 16 Sep 2021 18:27:09 -0700 Subject: [PATCH] import: go: Match "go-import" meta tags anywhere. Some personal sites forget to put in a element, so look anywhere for them. * guix/import/go.scm (fetch-module-meta-data): Match "go-import" meta tags anywhere in the page. --- guix/import/go.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/go.scm b/guix/import/go.scm index dad007d511..43abe004b3 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -480,7 +480,7 @@ build a package." (strip-.git-suffix/maybe repo-url))))) ;; (let* ((meta-data (http-fetch* (format #f "https://~a?go-get=1" module-path))) - (select (sxpath `(// head (meta (@ (equal? (name "go-import")))) + (select (sxpath `(// (meta (@ (equal? (name "go-import")))) // content)))) (match (select (html->sxml meta-data #:strict? #t)) (() #f) ;nothing selected base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1 -- 2.33.0 --=-=-=--