From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cEDKNCzLVGEpagEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 22:23:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kF5tMCzLVGFdbgAAB5/wlQ (envelope-from ) for ; Wed, 29 Sep 2021 20:23:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48435C290 for ; Wed, 29 Sep 2021 22:23:06 +0200 (CEST) Received: from localhost ([::1]:49636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVg6b-0008CG-CG for larch@yhetil.org; Wed, 29 Sep 2021 16:23:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVg5Z-0007T9-U1 for guix-patches@gnu.org; Wed, 29 Sep 2021 16:22:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVg5Z-0003NO-LT for guix-patches@gnu.org; Wed, 29 Sep 2021 16:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVg5Z-0005ze-Hd for guix-patches@gnu.org; Wed, 29 Sep 2021 16:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 1/2] guix: packages: Document 'computed-origin-method'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 20:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Mark H Weaver , 50620@debbugs.gnu.org Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163294687422973 (code B ref 50620); Wed, 29 Sep 2021 20:22:01 +0000 Received: (at 50620) by debbugs.gnu.org; 29 Sep 2021 20:21:14 +0000 Received: from localhost ([127.0.0.1]:50365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVg4n-0005yS-Ts for submit@debbugs.gnu.org; Wed, 29 Sep 2021 16:21:14 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVg4m-0005yF-69 for 50620@debbugs.gnu.org; Wed, 29 Sep 2021 16:21:12 -0400 Received: by mail-wr1-f43.google.com with SMTP id u18so6269971wrg.5 for <50620@debbugs.gnu.org>; Wed, 29 Sep 2021 13:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=Jvi8XyeBw1FFkjych6VDEpkIl9nOfr9upigC0fRps9g=; b=SU904B8ewPlfxp7nwzw7FC1Ew/FvE7pRTY7Jxue+sqpi62+QLRusAcPIO7yxLDcC0r I7nYZWFgyhl7aafTj+uIMxRAODDi3TrlGIDS6YRbESRPmiemO0qaNekHntD5YkRr0p86 GafkAcrnSGlkvgcOKXXyJh4RBScR1i3rUCLIgdHgSTA5ZSa5QLZYcstKmObbcTvt6GGc sTCqcWgHYv4pfRPk/Y8Z5rzZeM2PU6jbqPYk5ioLJBCEt7MhnitS9y/3/obhqbqFena1 1TKlkgHL3EWkbLrlVdHo4BdO0jUgsWOhJzHkUuDVaKoRhKl/LKR04L/y6cxP000UMGc1 Kqhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Jvi8XyeBw1FFkjych6VDEpkIl9nOfr9upigC0fRps9g=; b=qIQEJAXmMuYgZmEZ2H2U/pRsalAW/fCia6/6QABKYk/KmsKKaCcGNLaXUWMW3opT9T 62UtbbarwXgo2qe5wO15bestslv8TfXFceT4n2kf4wplf/5bkaDsnZKZksy1f2flVox+ 0D9SDg09MjvGb6k4FZOOygfE0aTxhpvxPdWdYjLc6UAFZLcY4DaXe7jwvBCrc4upaYUG op3SQ2OQgGb5XfFYfShIfn+fSWf7G+pum9+MDhrYonkIUCZ6u9RreQXddmspPYVFMA06 1IbT3tNVB4UwS7u0wrEKOVOtaJ3TzYb7CBLOqintrMnf+qo4zxDyX35AZGKgXBAee76D 7WYg== X-Gm-Message-State: AOAM531v4Orn4cVZ99NUToTtUw3ve1DRMceJN+yYrKgnMZy0peqaINR5 FoC+4gKv/Ft/4RGVvH0hxOlGDk4XOur9NA== X-Google-Smtp-Source: ABdhPJznAz2kbWzsLZypdFvC2GvYdm47i9AiH3b+lA6H9RnMn3raBAa2ur3v8gmXk+hQY81vjW3F2g== X-Received: by 2002:adf:b185:: with SMTP id q5mr538919wra.359.1632946866310; Wed, 29 Sep 2021 13:21:06 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id i2sm820916wrq.78.2021.09.29.13.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 13:21:05 -0700 (PDT) From: zimoun In-Reply-To: References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> <1803ff0456849f456c6994d47cbe50d1a8ff6a09.camel@gmail.com> <56dcce10a751153d89f515028cd18c9125f6b84f.camel@gmail.com> <756ae01852047a7adc2522c025c8cd7283dc7e55.camel@gmail.com> Date: Wed, 29 Sep 2021 22:15:02 +0200 Message-ID: <861r57dtq1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632946986; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jvi8XyeBw1FFkjych6VDEpkIl9nOfr9upigC0fRps9g=; b=oPyXy0IALhUeE7ox3OxeVLFC0KjV31mZRR3I7Rs8NwEdkxlKmxaZPixD4junWsBrqPHHj+ k2hOlUXauUZq/BWA88yGq93pMHMgQv9meF6omxVOksjCmIDlk6WDozPV5dKsJBxVcJmb40 oyvjCxplwOaqLm4IQh6YI3SUl+DA8WlRuMGMSUVyepZjffklzMsaJn+Zl5b6blfIRCC3pH qJqCRvFdwxw6HlxKxiQFF6MjogudeV+te7aO8J++I8ApbgT0MraetEMd3oJAT5LuE64YIR bruSvNxRrHmrrd0v0zDH8VrOVQ72LG0J/oMHDi0oWr9YGFxtU8AUpoJ0Ad8rMw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632946986; a=rsa-sha256; cv=none; b=IofNBKobhUyCQlXGBhD+ujtaXuPhzOziy2gvg1CZIDcLal2aVXeGRRph7nb3U5Zxrk4Aa/ Xb+s6GTunqPK40Sd967iUPHC8kMa31Y6dzaS1jKpkzOg9EZfbd8IuZathXHfG1FQj3uzCM OeTzhLscg81GEaXuySo44HVbEOgqeaxdFhRluYIYwhhWFcPBmqVrEgP1aPy5Xmnep/9iTA LG/2VH4BicKmHxDIgfIFBLt5ktaDgvcdG20nmBdYHRK8GjiavnsQ82OAvtn1iu12ihiKJ1 Il6pIiXfIVIVeY7bzIUDVrudtr8OVVBC4vVCaPSSRV1hX/cgdKPUCi2iACxZvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SU904B8e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=SU904B8e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 48435C290 X-Spam-Score: -1.70 X-Migadu-Scanner: scn1.migadu.com X-TUID: wOKMAhXJyqvR Hi Liliana, On Wed, 29 Sep 2021 at 21:10, Liliana Marie Prikler wrote: > I could > roll my own channel with the exact same computed-origin-method > copypasta'd once more and it wouldn't be detected, though that's > probably off-topic.[1] If it is in your own channel, then it will not be part of the file https://guix.gnu.org/sources.json. >From my understanding, you are arguing about corner cases that does not happen now. And if it happens in the near future, we will fix it, depending on what will really happen in this very future. ;-) > I was a little confused when I read factorize from Ludo or refactorize > from you. I know this technique under the name "refactoring". Indeed. Maybe a false-friend from French. :-) >> *refactorize: I think (guix packages) is better because it defines [...] >> half-mentioned this rationale. > > To that I would counter, that (guix packages) only defines package and [...] > issue referencing the GNU namespace to get to it. I hear your argument. Well, I will not discuss it. Raise as an answer to Ludo, maybe. >> To be honest, I thought that this tiny improvement of the SWH >> coverage would have been much more easier and that that trivial task >> would not have taken more than 15 days with lengthy discussions. :-) > > To be honest, part of the lengthy discussion was me being confused > about your intent =E2=80=93 in multiple ways. If you wanted a "quick and= dirty > fix" you could have went with checking those two modules explicitly on > the guix-artwork side and it would have had a fairly small impact. > Reading this patch first and the discussion second, I had assumed your > intent was rather to formalize a method that had hitherto only been > used informally and the move to the guix namespace amplifies that imo. The cover letter [1] says: =C2=ABThis patch follows the discussion from [0]= .=C2=BB where [0] points to the Mark=E2=80=99s approval as an answer to a patch whi= ch applies to website/apps/packages/builder.scm. Then the cover letter [1] says: =C2=ABIn short, it simplifies the code generating the file 'sources.json' used by Software Heritage to ingest all the tarballs.=C2=BB 1: I am sorry if this cover letter was not enough explicit about my intent. >From my point of view, the aim of this cover letter was to invite to read first the discussion and second read the patch. My bad if this aim had been missed. I apologize for the confusion. Being optimistic, this discussion leads to some concerns about this =E2=80=99computed-origin-method=E2=80=99 and ideas for improving. IMHO, it= is worth to open another issue providing the wish of multi-origin packages and reference to this. WDYT? All the best, simon