[Added Maxime because this patch should fix his worries too]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote:

> I applied it to a Git checkout of the Guix source code, and tried
> rebuilding Guix, as described here in the Contributing chapter of the
> manual:
>
> https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html
>
> However, it crashes like this:
[...]
> The reason for this error is that licenses in the gnu/packages/video.scm
> module are "prefixed" to avoid a namespace collision between packages
> and licenses with the same name, such as zlib and expat:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80
>
> You can check other packages in that module for examples of how to
> prefix the license.
>
>> +    (license gpl2+)

Thanks, fixed.

>
> I checked several of the .py files in the source code, and setup.py,
>and
> they all seem to specify that the program is made available under the
> terms of version 2 of the GPL, but no later versions. So, this package
> should use "gpl2", not "gpl2+".

I was confused due to the example on LICENSE containing phrase 'or (at
your option) any later version' but turns out that was an example.

>
>> +    (arguments
>> +     '(#:tests? #f))))
>
> We always run upstream test suites in Guix packages, because it helps
> validate our packaging and finds bugs to assist upstream development.
> If we do not run the tests, we add a code comment explaining why. In
> Scheme, comments begin with the ; (semicolon) character.
>
> So, can you send a revised patch that adjusts the license and either
> runs the test suite or explains why not?

It is attached in this mail.

>
> Thanks in advance!
>

Thanks!