From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aFY4BKe6+WYKDAEA62LTzQ:P1 (envelope-from ) for ; Sun, 29 Sep 2024 20:37:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aFY4BKe6+WYKDAEA62LTzQ (envelope-from ) for ; Sun, 29 Sep 2024 22:37:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=pIJVNXC8; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Bm93SdLW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727642279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DgwZK48tutqwgtnxP4qr0vrNGo+T0ggaHAmGguQETtQ=; b=unsFXm+0t0o5P+KaKHkJ3geGqZ5BRT8JPKlzFhU88BRtrkccW1SPORkp+GbPf7tsROMZfR 14ja/X6R2pWOL5PI26xPkQteqmM18ELJsY8XRcLrJ9zBmHqAOR8aoEkRolzkS4PrLDhfpF orjoB8dcIEj9VNse69cW5aI04A40Gyblgq0clcJWzQHNzUvgcu8+n/JShpA9xFp1lLT+gn h34nGGvmx9P2qPxhE5vtmL2ZzLQyJiJ/VVGD4dpUPRlDJ0U9GUE7JvEQPW3CUIrzoozJzc Mqx4M6NWtOyWCyyd2UckuWDYy6gbZ+T/a4sTcvvl77u52Ts1hhVJDGnMbYV5GA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727642279; a=rsa-sha256; cv=none; b=Q7HPQUgWqB+V1w33QEM/2/JugKNbLNu7j8sip5WDCyDyYiJV6aIId/DyEGccA467U7efpg jG7f1Zs7FM14q86XkrtVclv7XcEFkNNyEMK3mA9LFjVtadNkfhV0WkXaWrGF1+CN2WKbPo bmpgwsc0r9SRcbTqNfqw1545YPvIW3nVElUhBDZNxRF9HOEmMQCv5uZpMVb5l/tPIzBtR3 7rjK+Q4XBRXo1Oj5L7pIJ4qlZJHZhCJE3uhiPok5dG9q2U7cunH3bpR/4Ab9W9l2r2aWDE Ras7prWl1Bewbyy5Vr3J1PFuAxLaH+wR96ZOLCCdvPuheQCHN7Obm3xRHL8/hw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=pIJVNXC8; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Bm93SdLW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA03C43C64 for ; Sun, 29 Sep 2024 22:37:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sv0fd-0005wV-E7; Sun, 29 Sep 2024 16:37:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sv0fb-0005w0-OH for guix-patches@gnu.org; Sun, 29 Sep 2024 16:37:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sv0fb-0002xh-Em for guix-patches@gnu.org; Sun, 29 Sep 2024 16:37:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=DgwZK48tutqwgtnxP4qr0vrNGo+T0ggaHAmGguQETtQ=; b=pIJVNXC83LTKDVTQ2nqBj6OY+v1Qi5snQ3hjL0TGM+FzfZsFlTC9bGSklJ/oXhdOM1G9W4NDw3J5FL+jXkX4TJ+R7E29FdBFGjN6PeaVuOSKtk1ViTXyioWLREWw9jGfsxuyx+9ksIGu3uh6ALCDQJMQXXYQxOdZ+r4ArQYvAur7cicBkQ13uKXqwwhMVNaMSM5MIIf6/DjTaInDZUlWWL+2bQErdfHsC1EZtGoAjmiVNbAppgmupxriqWYyHIG7wef4QHrmDe2B+2u5oI5cN00GifRwNhPy0MPYClfz3nXYLSv37wpP1rbggxRFsDf7k6xj0k1s3SCvgs2V18/d0Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sv0g6-0005Si-R9; Sun, 29 Sep 2024 16:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73558] [PATCH 2/4] gnu: gsl: Build with =?UTF-8?Q?=E2=80=98-O2_?= =?UTF-8?Q?-g=E2=80=99?= unconditionally. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: andreas@enge.fr, bavier@posteo.net, sharlatanus@gmail.com, guix-patches@gnu.org Resent-Date: Sun, 29 Sep 2024 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73558 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 73558@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andreas Enge , Eric Bavier , Sharlatan Hellseher X-Debbugs-Original-Xcc: Andreas Enge , Eric Bavier , Sharlatan Hellseher Received: via spool by 73558-submit@debbugs.gnu.org id=B73558.172764226420963 (code B ref 73558); Sun, 29 Sep 2024 20:38:02 +0000 Received: (at 73558) by debbugs.gnu.org; 29 Sep 2024 20:37:44 +0000 Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv0fn-0005S3-So for submit@debbugs.gnu.org; Sun, 29 Sep 2024 16:37:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv0fi-0005RO-0b for 73558@debbugs.gnu.org; Sun, 29 Sep 2024 16:37:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sv0f6-0002wZ-J4; Sun, 29 Sep 2024 16:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=DgwZK48tutqwgtnxP4qr0vrNGo+T0ggaHAmGguQETtQ=; b=Bm93SdLWHVm7x7Jse8cC qU5N1vxcCDq/nHkEEP0OYJiiJDOBs99t+QShdkR/fdzFyyRlNr+W6tWBs9152TRBlnssH5/08RyXP A/zRgPkbka61Pk5nx949ZrKMjEjSwbaz94jecNseWq/CIEMaAoNuTRbkHce5SAmXNUyApvIEoRX1B 9YOzSm8bwnsr89z4ECSxo19uMgZr3+aZ9mWGWNwdGq7LQs8O9zqdqrZzPc1CGO3CZRmYk2uj1rftf 7U7x9W39CLXphpyUjCetv9YZw7La2ZsouphP+FysZIyEDqDqFmXw6QWFpURCDl3Sm9/eLUB14vhIM vTQSwSLQpRKLgg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Sun, 29 Sep 2024 22:36:41 +0200 Message-ID: <85a2d861d815ffee24f109c2c5fe2cdba64e23ca.1727642162.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: EA03C43C64 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -3.01 X-Migadu-Spam-Score: -3.01 X-TUID: 5IdVlSlolbWP Fixes a regression introduced in 53bec65c51c3f2b7e318db4dc7a5c3a09ad00214 that would cause gsl to be built without optimizations and without debugging symbols (equivalent to “-O0 -g0”). * gnu/packages/maths.scm (gsl)[arguments]: Remove #:make-flags. Change-Id: I5297e3602bffbb7655d655622cc3d7595f82b25a --- gnu/packages/maths.scm | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index 9032b5268a..d318dc3d0b 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -728,17 +728,7 @@ (define-public gsl (outputs '("out" "static" "debug")) (build-system gnu-build-system) (arguments - (list ;; FIXME: Setting CFLAGS=-fPIC is not only unnecessary, it's also - ;; harmful because it removes the default '-O2 -g', meaning that the - ;; library ends up being compiled as -O0. Consequently, some - ;; numerical tests fail, notably on i686-linux. TODO: Remove - ;; 'CFLAGS=-fPIC' for all systems and revisit or remove - ;; 'disable-failing-tests' phases accordingly. - #:make-flags (if (and (not (%current-target-system)) - (string=? (%current-system) "i686-linux")) - #~'() - #~(list "CFLAGS=-fPIC")) - #:phases + (list #:phases #~(modify-phases %standard-phases #$@(cond ((and (target-riscv64?) -- 2.46.0