From: "Ludovic Courtès" <ludo@gnu.org>
To: 73558@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Andreas Enge" <andreas@enge.fr>,
"Eric Bavier" <bavier@posteo.net>,
"Sharlatan Hellseher" <sharlatanus@gmail.com>
Subject: [bug#73558] [PATCH 2/4] gnu: gsl: Build with ‘-O2 -g’ unconditionally.
Date: Sun, 29 Sep 2024 22:36:41 +0200 [thread overview]
Message-ID: <85a2d861d815ffee24f109c2c5fe2cdba64e23ca.1727642162.git.ludo@gnu.org> (raw)
In-Reply-To: <db4c0559ec7e965c6e8d3d0c1dc8ce3b7fe87930.1727642162.git.ludo@gnu.org>
Fixes a regression introduced in
53bec65c51c3f2b7e318db4dc7a5c3a09ad00214 that would cause gsl to be
built without optimizations and without debugging symbols (equivalent to
“-O0 -g0”).
* gnu/packages/maths.scm (gsl)[arguments]: Remove #:make-flags.
Change-Id: I5297e3602bffbb7655d655622cc3d7595f82b25a
---
gnu/packages/maths.scm | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 9032b5268a..d318dc3d0b 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -728,17 +728,7 @@ (define-public gsl
(outputs '("out" "static" "debug"))
(build-system gnu-build-system)
(arguments
- (list ;; FIXME: Setting CFLAGS=-fPIC is not only unnecessary, it's also
- ;; harmful because it removes the default '-O2 -g', meaning that the
- ;; library ends up being compiled as -O0. Consequently, some
- ;; numerical tests fail, notably on i686-linux. TODO: Remove
- ;; 'CFLAGS=-fPIC' for all systems and revisit or remove
- ;; 'disable-failing-tests' phases accordingly.
- #:make-flags (if (and (not (%current-target-system))
- (string=? (%current-system) "i686-linux"))
- #~'()
- #~(list "CFLAGS=-fPIC"))
- #:phases
+ (list #:phases
#~(modify-phases %standard-phases
#$@(cond
((and (target-riscv64?)
--
2.46.0
next prev parent reply other threads:[~2024-09-29 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 20:32 [bug#73558] Request for merging "wip-gsl-upgrade" branch Ludovic Courtès
2024-09-29 20:36 ` [bug#73558] [PATCH 1/4] gnu: gsl: Add debug output Ludovic Courtès
2024-09-29 20:36 ` Ludovic Courtès [this message]
2024-09-29 20:36 ` [bug#73558] [PATCH 3/4] gnu: gsl: Update to 2.8 Ludovic Courtès
2024-09-29 20:36 ` [bug#73558] [PATCH 4/4] gnu: lib2geom: Update to 1.4 Ludovic Courtès
2024-09-29 20:56 ` [bug#73558] Request for merging "wip-gsl-upgrade" branch Ludovic Courtès
2024-10-02 16:55 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a2d861d815ffee24f109c2c5fe2cdba64e23ca.1727642162.git.ludo@gnu.org \
--to=ludo@gnu.org \
--cc=73558@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=bavier@posteo.net \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.