From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37590) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBI9X-0005No-BX for guix-patches@gnu.org; Mon, 09 Mar 2020 09:09:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBI9W-00011d-BF for guix-patches@gnu.org; Mon, 09 Mar 2020 09:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBI9W-00011B-7z for guix-patches@gnu.org; Mon, 09 Mar 2020 09:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBI9W-0002uZ-3V for guix-patches@gnu.org; Mon, 09 Mar 2020 09:09:02 -0400 Subject: [bug#39747] [PATCH 3/7] gnu: java-openjfx-graphics: Implement a complete compilation. Resent-Message-ID: From: levenson@mmer.org References: <20200222201755.50425-1-levenson@mmer.org> <20200222201755.50425-3-levenson@mmer.org> <20200304030012.GB1199@jasmine.lan> Date: Mon, 09 Mar 2020 14:08:02 +0100 In-Reply-To: <20200304030012.GB1199@jasmine.lan> (Leo Famulari's message of "Tue, 3 Mar 2020 22:00:12 -0500") Message-ID: <84y2s9smkt.fsf@delta.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 39747@debbugs.gnu.org, Alexey Abramov I have updated the patch. Leo Famulari writes: > On Sat, Feb 22, 2020 at 09:17:51PM +0100, Alexey Abramov wrote: >> + (name "java-openjfx-graphics") >> + (arguments >> + `(#:jar-name "java-openjfx-graphics.jar" > >> + #:source-dir "modules/graphics/src/main/java" >> + #:tests? #f ; requires X >> + #:test-dir "modules/graphics/src/test" >> + #:test-include (list "**/*Test.*") >> + #:modules ((guix build ant-build-system) >> + (guix build utils) >> + (srfi srfi-1) >> + (srfi srfi-26) >> + (ice-9 regex) >> + (ice-9 match)) > > [...] > > Wow, this might be one of the longest package definitions in Guix :) Yeah, OpenJDK has two build instruction procedures for u8 and u9. I was thinking about some helpers to reduce the amount of code but wasn't sure if it's going to work/help for u9. My goal was to package davmail, so I started packaging what I had been using to run it. > I can't review it in detail but if it's working for you, okay. Just make > sure to run `./pre-inst-env guix lint java-openjfx-graphics` and fix any > cosmetic issues. In my case it complains about: 1. Patch file name, which is added to the java-openjfx-build package. I can rename it, but I am guessing it will start complaining on java-openjfx-build. Bug? Or am I doing something wrong? 2. java-openjfx-build is not under Software Heritage, hence the message. 3. Lines are too long, All lines are shorter than 120 for sure. I would prefer to keep them as it is. It is easier to read. > Maybe some of the Guix Java experts can give it a closer review... That would be great, cause I did build a lot of native libraries, but not all of them. fontT2k for example which is a fallback library for some fonts engines. -- Alexey