From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53363)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQew-0005Tw-Vm
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQev-0001Nz-SL
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:14:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45595)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jBQev-0001Ng-P0
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:14:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQev-0001iN-Kd
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:14:01 -0400
Subject: [bug#39741] [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: Add new
 variable.
Resent-Message-ID: <handler.39741.B39741.15837919896507@debbugs.gnu.org>
From: levenson@mmer.org
In-Reply-To: <20200304030754.GD1199@jasmine.lan> (Leo Famulari's message of
 "Tue, 3 Mar 2020 22:07:54 -0500")
References: <20200222201755.50425-1-levenson@mmer.org>
 <20200222201755.50425-7-levenson@mmer.org>
 <20200304030754.GD1199@jasmine.lan>
Date: Mon, 09 Mar 2020 23:13:05 +0100
Message-ID: <84r1y1p47i.fsf@delta.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 39746@debbugs.gnu.org, 39741@debbugs.gnu.org, Alexey Abramov <levenson@mmer.org>

Leo Famulari <leo@famulari.name> writes:

> On Sat, Feb 22, 2020 at 09:17:55PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm (java-openjfx-build): Add patch to the base package.
>> * gnu/packages/patches/java-openjfx-build-web-Check-xlocale.h-header-file.patch: New
>>   file. Remove hardcoded xlocale definitions.
>
> I have the same comments as previously. We need to fix up the commit
> message, add java-openjfx-web in a separate commit, and add some
> description to the xlocale patch file.

I fixed the comment, add description to the patch and split the change
into two commits.

> Can you send a revised patch series? You can add the argument
> '--subject-prefix=v2' to your `git send-email` or `git format-patch`
> command to distinguish the new patches from the old ones.
>
> Thanks!

Thank you for subject-prefix tip! 

-- 
Alexey